BiometricPrompt is not hiding if error code is different than ERROR_CANCELED or BiometricPrompt.ERROR_LOCKOUT [143683687]

Fixed

Bug

Status Update

No update yet.

Description

te...@gmail.com

created issue #1

Oct 31, 2019 04:08PM

BUILD INFO
- Device type:
- OS version:
- Biometric library version: 1.0.0-rc02

STEPS TO REPRODUCE
[Be as specific as possible please]
Write robolectric test
1. Show BiometricPrompt
2. Invoke onAuthenticationError(BiometricPrompt.ERROR_HW_UNAVAILABLE, "some message")

EXPECTED RESULTS
prompt should be dismissed because no further authentication can take place

OBSERVED RESULTS
prompt is not dismissed

Comments

cu...@google.com <cu...@google.com> Oct 31, 2019 07:20PM

Reassigned to cu...@google.com.

cu...@google.com <cu...@google.com> #2Nov 1, 2019 11:35PM

I guess technically, the ProGuard rule should be on androidx.work.NonBlockingWorker subclasses, but I'd also be okay with just not using reflection to access the Worker(Context, WorkerParamters) constructor and skipping the need for a ProGuard rule at all.

te...@gmail.com <te...@gmail.com> #3Nov 4, 2019 09:43AM

Fixed in

https://android-review.googlesource.com/c/platform/frameworks/support/+/767262

cu...@google.com <cu...@google.com> Nov 5, 2019 11:58PM

Accepted by cu...@google.com.

ap...@google.com <ap...@google.com> #4Nov 6, 2019 05:25PM

Marked as fixed.

The fix will be available in alpha10.

an...@google.com <an...@google.com> #5Nov 26, 2019 06:07PM

I tried to use the ProGuard configuration which is linked in

comment #3

in my project.
The release build fails and the following warnings are printed:

22:22:06.567 [QUIET] [system.out] Note: the configuration keeps the entry point 'androidx.work.NonBlockingWorker { NonBlockingWorker(android.content.Context,androidx.work.WorkerParameters); }', but not the descriptor class 'androidx.work.WorkerParameters'
22:22:06.567 [QUIET] [system.out] Note: the configuration keeps the entry point 'androidx.work.NonBlockingWorker { void internalInit(android.content.Context,androidx.work.WorkerParameters); }', but not the descriptor class 'androidx.work.WorkerParameters'
22:22:06.567 [QUIET] [system.out] Note: the configuration keeps the entry point 'androidx.work.Worker { Worker(android.content.Context,androidx.work.WorkerParameters); }', but not the descriptor class 'androidx.work.WorkerParameters'

The app is opensource if you want to run the release build yourself. Here is the branch (WIP):

https://github.com/EventFahrplan/EventFahrplan/tree/workmanager
Please run: ./gradlew --info --debug aCcc34c3Release

Issue 143683687