FragmentScenario should be closeable and release resources [143774122]

Fixed

Feature Request

androidx-bug-bounty

Status Update

No update yet.

Description

hu...@google.com

created issue #1

Nov 1, 2019 07:40PM

FragmentScenario uses ActivityScenario internally but never calls close() which causes EmptyFragmentActivity to be left after test.

Comments

hu...@google.com <hu...@google.com> #2Nov 1, 2019 07:44PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <jbwoods@google.com>
Link: https://android-review.googlesource.com/3531312

Convert navigation-testing to KMP

Expand for full commit details

Convert navigation-testing to KMP 
 
Moving the navigation-testing module to KMP. This supports all the same 
platforms as the rest of Navigation and has converted all uses of Bundle 
to the new SaveState. 
 
RelNote: "Navigation Testing is now a KMP module." 
Test: all tests pass 
Bug: 398265336 
Change-Id: I2b7707a56f263be30420cae57e3b38480d7f0625

Files:

M docs-tip-of-tree/build.gradle
A navigation/navigation-testing/bcv/native/current.txt
M navigation/navigation-testing/build.gradle
M navigation/navigation-testing/src/androidInstrumentedTest/AndroidManifest.xml
M navigation/navigation-testing/src/androidInstrumentedTest/kotlin/androidx/navigation/testing/TestNavHostControllerTest.kt
M navigation/navigation-testing/src/androidInstrumentedTest/kotlin/androidx/navigation/testing/TestNavigatorStateTest.kt
M navigation/navigation-testing/src/androidInstrumentedTest/res/navigation/test_graph.xml
M navigation/navigation-testing/src/androidMain/AndroidManifest.xml
M navigation/navigation-testing/src/androidMain/kotlin/androidx/navigation/testing/TestNavHostController.android.kt
M navigation/navigation-testing/src/androidMain/kotlin/androidx/navigation/testing/TestNavigatorState.android.kt
A navigation/navigation-testing/src/androidUnitTest/kotlin/androidx/navigation/testing/RobolectricTest.android.kt
M navigation/navigation-testing/src/androidUnitTest/kotlin/androidx/navigation/testing/TestSavedStateHandleFactory.kt
A navigation/navigation-testing/src/commonMain/kotlin/androidx/navigation/testing/SavedStateHandleFactory.kt
M navigation/navigation-testing/src/commonMain/kotlin/androidx/navigation/testing/TestNavigatorProvider.kt
D navigation/navigation-testing/src/main/AndroidManifest.xml
D navigation/navigation-testing/src/main/java/androidx/navigation/testing/SavedStateHandleFactory.kt

Hash: 31ae4c7ebb13918db0e022b19246b7a47755ac65
Date: Fri Mar 07 09:11:14 2025

jb...@google.com <jb...@google.com> Jan 7, 2020 08:15PM

Assigned to hu...@google.com.

sh...@ebay.com <sh...@ebay.com> #3Apr 21, 2020 08:50AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <jbwoods@google.com>
Link: https://android-review.googlesource.com/3545603

Implement jvmTest for navigation-testing

Expand for full commit details

Implement jvmTest for navigation-testing 
 
Adding a copy of TestSavedStateHandleFactory to jvmCommonTest to ensure 
that is runs on all nonAndroid platforms. 
 
The `nullLiteralArgument` and `emptyStringArgument` tests are expected 
to fail as they require the encoding and decoding the types which is 
behavior only supported on the jetbrains fork. 
 
Test: added tests 
Bug: 398265336 
Change-Id: I4c1dcfb697d6e9e16995b249b9a8351bd925e0f3

Files:

M navigation/navigation-testing/build.gradle
A navigation/navigation-testing/src/jvmCommonTest/kotlin/androidx/navigation/testing/TestSavedStateHandleFactory.kt

Hash: 139d2423c7625f19ececc94b2df5bfde24e2cf95
Date: Fri Mar 14 23:48:06 2025

hu...@google.com <hu...@google.com> Sep 18, 2020 09:33PM

Accepted by hu...@google.com.

hu...@google.com <hu...@google.com> Jan 15, 2021 11:58PM

Assigned to il...@google.com.

il...@google.com <il...@google.com> #4Jan 16, 2021 12:04AM

Reassigned to jb...@google.com.

See example CL in aosp/1430179. Probably just needs to be moved to androidx-main and reworked since FragmentScenario is now written in Kotlin.

ap...@google.com <ap...@google.com> #5Jan 25, 2021 12:28AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit f2087040fd4cfef94d308a16d884deb75240f7dd
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Fri Jan 22 11:04:17 2021

[GH] Make FragmentScenario closeable

## Proposed Changes

- Make FragmentScenario closeable (See original CL: [aosp/1430179](

https://android-review.googlesource.com/c/platform/frameworks/support/+/1430179/))

## Testing

Test: See JUnit test

## Issues Fixed

Fixes: 143774122

This is an imported pull request from

https://github.com/androidx/androidx/pull/121.

Resolves #121
Github-Pr-Head-Sha: 56209fab7315652cf548b6f0dd173a9b1de2a966
GitOrigin-RevId: f18f88ad0e56ca8bb35d4bedfc758e23af5c5d64
Change-Id: If207da9852d9245b7c639972508622210b0c247b

M fragment/fragment-testing/api/current.txt
M fragment/fragment-testing/api/public_plus_experimental_current.txt
M fragment/fragment-testing/api/restricted_current.txt
M fragment/fragment-testing/src/androidTest/java/androidx/fragment/app/testing/FragmentScenarioTest.kt
M fragment/fragment-testing/src/main/java/androidx/fragment/app/testing/FragmentScenario.kt

https://android-review.googlesource.com/1556961