Fixed
Status Update
Comments
hu...@google.com <hu...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit e2ac3b6793a301fe493b4e657e9cf1a02c780887
Author: Ian Lake <ilake@google.com>
Date: Fri Mar 18 23:02:22 2022
Call enableSavedStateHandles() immediately after performAttach()
Now that enableSavedStateHandles() no longer requires immediate
access to a ViewModel, we can safely call it immeidately after
performAttach().
Test: existing tests still pass
BUG: 215406268
Change-Id: I348ae5f95cb607e92e2f38bccc2b6d5b5876fb16
M navigation/navigation-common/build.gradle
M fragment/fragment/build.gradle
M activity/activity/src/main/java/androidx/activity/ComponentActivity.java
M fragment/fragment-ktx/build.gradle
M fragment/fragment/src/main/java/androidx/fragment/app/Fragment.java
M activity/activity-ktx/build.gradle
M activity/activity/build.gradle
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentViewLifecycleOwner.java
M navigation/navigation-common/src/main/java/androidx/navigation/NavBackStackEntry.kt
https://android-review.googlesource.com/2032475
Branch: androidx-main
commit e2ac3b6793a301fe493b4e657e9cf1a02c780887
Author: Ian Lake <ilake@google.com>
Date: Fri Mar 18 23:02:22 2022
Call enableSavedStateHandles() immediately after performAttach()
Now that enableSavedStateHandles() no longer requires immediate
access to a ViewModel, we can safely call it immeidately after
performAttach().
Test: existing tests still pass
BUG: 215406268
Change-Id: I348ae5f95cb607e92e2f38bccc2b6d5b5876fb16
M navigation/navigation-common/build.gradle
M fragment/fragment/build.gradle
M activity/activity/src/main/java/androidx/activity/ComponentActivity.java
M fragment/fragment-ktx/build.gradle
M fragment/fragment/src/main/java/androidx/fragment/app/Fragment.java
M activity/activity-ktx/build.gradle
M activity/activity/build.gradle
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentViewLifecycleOwner.java
M navigation/navigation-common/src/main/java/androidx/navigation/NavBackStackEntry.kt
jb...@google.com <jb...@google.com>
sh...@ebay.com <sh...@ebay.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 29973ff449dbac17299da3c113017e01dbde09d8
Author: Ian Lake <ilake@google.com>
Date: Fri Mar 18 22:16:45 2022
Remove dependency on ViewModels in enableSavedStateHandles()
Rather than requiring the creation of a ViewModel as part of
the call to enableSavedStateHandle(), defer that creation
until createSavedStateHandle() is actually called. This
ensures that enableSavedStateHandles() is safe to call before
the owner is attached to a Context, etc.
Relnote: "You can now retrieve a previously registered
`SavedStateProvider` from a `SavedStateRegistry` via
`getSavedStateProvider()`."
Test: updated tests
BUG: 215406268
Change-Id: I7ea470c1af0385b8bc9d8ca653c84cc8d224e6cf
M savedstate/savedstate/api/restricted_current.txt
M savedstate/savedstate/src/main/java/androidx/savedstate/SavedStateRegistry.java
M savedstate/savedstate/api/current.txt
M lifecycle/lifecycle-viewmodel-savedstate/build.gradle
M lifecycle/lifecycle-viewmodel-savedstate/src/main/java/androidx/lifecycle/SavedStateHandleSupport.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidTest/java/androidx/lifecycle/viewmodel/savedstate/SavedStateHandleSupportTest.kt
M savedstate/savedstate/api/public_plus_experimental_current.txt
https://android-review.googlesource.com/2032091
Branch: androidx-main
commit 29973ff449dbac17299da3c113017e01dbde09d8
Author: Ian Lake <ilake@google.com>
Date: Fri Mar 18 22:16:45 2022
Remove dependency on ViewModels in enableSavedStateHandles()
Rather than requiring the creation of a ViewModel as part of
the call to enableSavedStateHandle(), defer that creation
until createSavedStateHandle() is actually called. This
ensures that enableSavedStateHandles() is safe to call before
the owner is attached to a Context, etc.
Relnote: "You can now retrieve a previously registered
`SavedStateProvider` from a `SavedStateRegistry` via
`getSavedStateProvider()`."
Test: updated tests
BUG: 215406268
Change-Id: I7ea470c1af0385b8bc9d8ca653c84cc8d224e6cf
M savedstate/savedstate/api/restricted_current.txt
M savedstate/savedstate/src/main/java/androidx/savedstate/SavedStateRegistry.java
M savedstate/savedstate/api/current.txt
M lifecycle/lifecycle-viewmodel-savedstate/build.gradle
M lifecycle/lifecycle-viewmodel-savedstate/src/main/java/androidx/lifecycle/SavedStateHandleSupport.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidTest/java/androidx/lifecycle/viewmodel/savedstate/SavedStateHandleSupportTest.kt
M savedstate/savedstate/api/public_plus_experimental_current.txt
hu...@google.com <hu...@google.com>
hu...@google.com <hu...@google.com>
il...@google.com <il...@google.com> #4
This decoupling has been complete and will be available in Lifecycle 2.5.0-alpha06.
ap...@google.com <ap...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-main
commit f2087040fd4cfef94d308a16d884deb75240f7dd
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Fri Jan 22 11:04:17 2021
[GH] Make FragmentScenario closeable
## Proposed Changes
- Make FragmentScenario closeable (See original CL: [aosp/1430179](https://android-review.googlesource.com/c/platform/frameworks/support/+/1430179/ ))
## Testing
Test: See JUnit test
## Issues Fixed
Fixes: 143774122
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/121 .
Resolves #121
Github-Pr-Head-Sha: 56209fab7315652cf548b6f0dd173a9b1de2a966
GitOrigin-RevId: f18f88ad0e56ca8bb35d4bedfc758e23af5c5d64
Change-Id: If207da9852d9245b7c639972508622210b0c247b
M fragment/fragment-testing/api/current.txt
M fragment/fragment-testing/api/public_plus_experimental_current.txt
M fragment/fragment-testing/api/restricted_current.txt
M fragment/fragment-testing/src/androidTest/java/androidx/fragment/app/testing/FragmentScenarioTest.kt
M fragment/fragment-testing/src/main/java/androidx/fragment/app/testing/FragmentScenario.kt
https://android-review.googlesource.com/1556961
Branch: androidx-main
commit f2087040fd4cfef94d308a16d884deb75240f7dd
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Fri Jan 22 11:04:17 2021
[GH] Make FragmentScenario closeable
## Proposed Changes
- Make FragmentScenario closeable (See original CL: [aosp/1430179](
## Testing
Test: See JUnit test
## Issues Fixed
Fixes: 143774122
This is an imported pull request from
Resolves #121
Github-Pr-Head-Sha: 56209fab7315652cf548b6f0dd173a9b1de2a966
GitOrigin-RevId: f18f88ad0e56ca8bb35d4bedfc758e23af5c5d64
Change-Id: If207da9852d9245b7c639972508622210b0c247b
M fragment/fragment-testing/api/current.txt
M fragment/fragment-testing/api/public_plus_experimental_current.txt
M fragment/fragment-testing/api/restricted_current.txt
M fragment/fragment-testing/src/androidTest/java/androidx/fragment/app/testing/FragmentScenarioTest.kt
M fragment/fragment-testing/src/main/java/androidx/fragment/app/testing/FragmentScenario.kt
Description