FragmentScenario should be closeable and release resources [143774122]

Fixed

Feature Request

androidx-bug-bounty

Status Update

No update yet.

Description

hu...@google.com

created issue #1

Nov 1, 2019 07:40PM

FragmentScenario uses ActivityScenario internally but never calls close() which causes EmptyFragmentActivity to be left after test.

Comments

hu...@google.com <hu...@google.com> #2Nov 1, 2019 07:44PM

Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.

jb...@google.com <jb...@google.com> Jan 7, 2020 08:15PM

Assigned to hu...@google.com.

sh...@ebay.com <sh...@ebay.com> #3Apr 21, 2020 08:50AM

Great! Thanks a lot, I'll look for the live updates soon!

hu...@google.com <hu...@google.com> Sep 18, 2020 09:33PM

Accepted by hu...@google.com.

hu...@google.com <hu...@google.com> Jan 15, 2021 11:58PM

Assigned to il...@google.com.

il...@google.com <il...@google.com> #4Jan 16, 2021 12:04AM

Reassigned to jb...@google.com.

See example CL in aosp/1430179. Probably just needs to be moved to androidx-main and reworked since FragmentScenario is now written in Kotlin.

ap...@google.com <ap...@google.com> #5Jan 25, 2021 12:28AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit f2087040fd4cfef94d308a16d884deb75240f7dd
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Fri Jan 22 11:04:17 2021

[GH] Make FragmentScenario closeable

## Proposed Changes

- Make FragmentScenario closeable (See original CL: [aosp/1430179](

https://android-review.googlesource.com/c/platform/frameworks/support/+/1430179/))

## Testing

Test: See JUnit test

## Issues Fixed

Fixes: 143774122

This is an imported pull request from

https://github.com/androidx/androidx/pull/121.

Resolves #121
Github-Pr-Head-Sha: 56209fab7315652cf548b6f0dd173a9b1de2a966
GitOrigin-RevId: f18f88ad0e56ca8bb35d4bedfc758e23af5c5d64
Change-Id: If207da9852d9245b7c639972508622210b0c247b

M fragment/fragment-testing/api/current.txt
M fragment/fragment-testing/api/public_plus_experimental_current.txt
M fragment/fragment-testing/api/restricted_current.txt
M fragment/fragment-testing/src/androidTest/java/androidx/fragment/app/testing/FragmentScenarioTest.kt
M fragment/fragment-testing/src/main/java/androidx/fragment/app/testing/FragmentScenario.kt

https://android-review.googlesource.com/1556961