FragmentScenario should be closeable and release resources [143774122]

Fixed

Feature Request

androidx-bug-bounty

Status Update

No update yet.

Description

hu...@google.com

created issue #1

Nov 1, 2019 07:40PM

FragmentScenario uses ActivityScenario internally but never calls close() which causes EmptyFragmentActivity to be left after test.

Comments

hu...@google.com <hu...@google.com> #2Nov 1, 2019 07:44PM

Project: platform/frameworks/support
Branch: androidx-main

commit 57ca221882695bd6a52549f4d9ea3b812e6fe87c
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Mon Mar 22 16:09:30 2021

[GH] [FragmentStrictMode] Detect <fragment> tag usage

## Proposed Changes

- Detect `<fragment>` tag usage inside XML layouts

## Testing

Test: See `FragmentStrictModeTest#detectFragmentTagUsage`

## Issues Fixed

Fixes: 153738235

This is an imported pull request from

https://github.com/androidx/androidx/pull/141.

Resolves #141
Github-Pr-Head-Sha: 4ea052596e4341b9f11bcf335e2bc38045a91f19
GitOrigin-RevId: 62e7487aa4874eef6bb556490e193717cf937251
Change-Id: Iae48578e85e4e4897f806d7ade2e2a660adf9479

M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentLayoutInflaterFactory.java
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.java
A fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentTagUsageViolation.java

https://android-review.googlesource.com/1649748

jb...@google.com <jb...@google.com> Jan 7, 2020 08:15PM

Assigned to hu...@google.com.

sh...@ebay.com <sh...@ebay.com> #3Apr 21, 2020 08:50AM

Is there any update on this issue? Is it fixed in latest version or it still exist?

hu...@google.com <hu...@google.com> Sep 18, 2020 09:33PM

Accepted by hu...@google.com.

hu...@google.com <hu...@google.com> Jan 15, 2021 11:58PM

Assigned to il...@google.com.

il...@google.com <il...@google.com> #4Jan 16, 2021 12:04AM

Reassigned to jb...@google.com.

See example CL in aosp/1430179. Probably just needs to be moved to androidx-main and reworked since FragmentScenario is now written in Kotlin.

ap...@google.com <ap...@google.com> #5Jan 25, 2021 12:28AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit f2087040fd4cfef94d308a16d884deb75240f7dd
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Fri Jan 22 11:04:17 2021

[GH] Make FragmentScenario closeable

## Proposed Changes

- Make FragmentScenario closeable (See original CL: [aosp/1430179](

https://android-review.googlesource.com/c/platform/frameworks/support/+/1430179/))

## Testing

Test: See JUnit test

## Issues Fixed

Fixes: 143774122

This is an imported pull request from

https://github.com/androidx/androidx/pull/121.

Resolves #121
Github-Pr-Head-Sha: 56209fab7315652cf548b6f0dd173a9b1de2a966
GitOrigin-RevId: f18f88ad0e56ca8bb35d4bedfc758e23af5c5d64
Change-Id: If207da9852d9245b7c639972508622210b0c247b

M fragment/fragment-testing/api/current.txt
M fragment/fragment-testing/api/public_plus_experimental_current.txt
M fragment/fragment-testing/api/restricted_current.txt
M fragment/fragment-testing/src/androidTest/java/androidx/fragment/app/testing/FragmentScenarioTest.kt
M fragment/fragment-testing/src/main/java/androidx/fragment/app/testing/FragmentScenario.kt

https://android-review.googlesource.com/1556961