Fixed
Status Update
No update yet.
Comments
il...@google.com
il...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit cd8fc14c6f2ad77d563e726eb30aa36f324259d0
Author: Ian Lake <ilake@google.com>
Date: Fri Jul 10 13:22:43 2020
Support per destination arguments in NavDeepLinkBuilder
In addition to continuing to support setArguments()
as a way to set global arguments that apply to all
destinations, add an optional Bundle parameter to
setDestination() and addDestination() to allow per
destination arguments.
Test: updated tests pass
BUG: 147913689
Relnote: "`NavDeepLinkBuilder` now allows you to set
arguments at a per destination level in addition to
the global arguments set via `setArguments()`."
Change-Id: I3a18cbb67b5836db013804a6d6c468cb0bc22102
M navigation/navigation-runtime/api/2.4.0-alpha01.txt
M navigation/navigation-runtime/api/current.txt
M navigation/navigation-runtime/api/public_plus_experimental_2.4.0-alpha01.txt
M navigation/navigation-runtime/api/public_plus_experimental_current.txt
M navigation/navigation-runtime/api/restricted_2.4.0-alpha01.txt
M navigation/navigation-runtime/api/restricted_current.txt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavDeepLinkBuilderTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavDeepLinkBuilder.java
https://android-review.googlesource.com/1360905
Branch: androidx-master-dev
commit cd8fc14c6f2ad77d563e726eb30aa36f324259d0
Author: Ian Lake <ilake@google.com>
Date: Fri Jul 10 13:22:43 2020
Support per destination arguments in NavDeepLinkBuilder
In addition to continuing to support setArguments()
as a way to set global arguments that apply to all
destinations, add an optional Bundle parameter to
setDestination() and addDestination() to allow per
destination arguments.
Test: updated tests pass
BUG: 147913689
Relnote: "`NavDeepLinkBuilder` now allows you to set
arguments at a per destination level in addition to
the global arguments set via `setArguments()`."
Change-Id: I3a18cbb67b5836db013804a6d6c468cb0bc22102
M navigation/navigation-runtime/api/2.4.0-alpha01.txt
M navigation/navigation-runtime/api/current.txt
M navigation/navigation-runtime/api/public_plus_experimental_2.4.0-alpha01.txt
M navigation/navigation-runtime/api/public_plus_experimental_current.txt
M navigation/navigation-runtime/api/restricted_2.4.0-alpha01.txt
M navigation/navigation-runtime/api/restricted_current.txt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavDeepLinkBuilderTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavDeepLinkBuilder.java
ga...@gmail.com
Thanks, we could reproduce the bug after some time.
A pending fix is athttps://review.source.android.com/24433
A pending fix is at
fo...@google.com
Fix submitted to AOSP tree.
ap...@google.com
I see same problem with ubuntu 11.04 natty fresh install, as it was fresh i loaded sdk r12, with sun java 6 u26.
ap...@google.com
Is there a workaround available till SDK R13 besides running at scale < 0.5 or >= 1.0?
Description
When defining an explicit deep-link using NavDeepLinkBuilder, only a single Argument bundle can be provided for every Fragment destination inferred from XML. This can cause conflicts between arguments of the same name shared by different Destinations, and no argument verification is performed, so it's possible for parent Fragments to crash at navigateUp() time.
Request: A NavDeepLinkBuilder api that allows composition of explicit [destId, args] pairs to construct a destination stack. Preferably, accepting NavDirections as the parameter, so existing SafeArgs generated wrappers can be reused for argument safety.