ANTLR Tool version mismatch with Room build error [150106190]

Fixed

Bug

Status Update

No update yet.

Description

he...@gmail.com

created issue #1

Feb 24, 2020 03:33PM

I am using classpath 'com.android.tools.build:gradle:3.5.3', Room 2.2.3, Dagger 2.26 and AS 3.5.3. When I am building my project I get this error

ANTLR Tool version 4.5.3 used for code generation does not match the current runtime version 4.7.1ANTLR Runtime version 4.5.3 used for parser compilation does not match the current runtime version 4.7.1ANTLR Tool version 4.5.3 used for code generation does not match the current runtime version 4.7.1ANTLR Runtime version 4.5.3 used for parser compilation does not match the current runtime version 4.7.1error: cannot generate view binders java.lang.StackOverflowError

And then a list of calls that caused the java.lang.StackOverflowError
at android.databinding.tool.expr.Expr.resolveListeners(Expr.java:209)
at android.databinding.tool.expr.Expr.resolveListeners(Expr.java:211)
at android.databinding.tool.expr.Expr.resolveListeners(Expr.java:211)
at android.databinding.tool.expr.Expr.resolveListeners(Expr.java:211)
at android.databinding.tool.expr.Expr.resolveListeners(Expr.java:211)
at android.databinding.tool.expr.Expr.resolveListeners(Expr.java:211)
at android.databinding.tool.expr.Expr.resolveListeners(Expr.java:211)
at android.databinding.tool.expr.Expr.resolveListeners(Expr.java:211) (etc)

It seems that it is known issue with data binding and room mismatch from what I read online but the solution of forcing a particular version of antlr4 doesn't work for me.

When forcing a version of antlr4 like so

configurations.all() {
resolutionStrategy.force "org.antlr:antlr4-runtime:4.5.3"
resolutionStrategy.force "org.antlr:antlr4-tool:4.5.3"
}
I can;'t compile Room with error Caused by: java.lang.ClassNotFoundException: org.antlr.v4.runtime.CharStreams

when forcing it to 4.7.1 it does nothing. Same error with version mismatch. Downgrading Room does nothing.

Comments

vi...@google.com <vi...@google.com> Feb 26, 2020 04:58AM

Assigned to vi...@google.com.

vi...@google.com <vi...@google.com> Feb 26, 2020 07:19AM

Assigned to yb...@google.com.

yb...@google.com <yb...@google.com> #2Feb 27, 2020 06:19AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit afc23fbda873bf19c761bc0f124c99ff4b1a99e9
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Mon Oct 22 15:25:27 2018

Generate correct code for a no argument Kotlin default DAO function.

Kotlin default functions takes 'this' as first parameter and Room
was generating code that passed it but also added a comma thinking
more parameters where to be appended, but on a no arg function, the
comma was kept followed by a closing parenthesis causing wrong code
to be generated.

This change fixes the issue by removing the comma when appending 'this',
but always prefixing a comma on all parameters if the call type is
DEFAULT_KOTLIN.

Bug: 117527454
Test: ./gradlew :room:integration-tests:kotlintestapp:cC
Change-Id: I5792280b85c66f90da3485767e480300ee72bda5

M room/compiler/src/main/kotlin/androidx/room/writer/DaoWriter.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/dao/BooksDao.kt

https://android-review.googlesource.com/798412

https://goto.google.com/android-sha1/afc23fbda873bf19c761bc0f124c99ff4b1a99e9

he...@gmail.com <he...@gmail.com> #3Feb 27, 2020 05:01PM

A fox for this issue will be available in Room 2.1.0-alpha02

yb...@google.com <yb...@google.com> #4Feb 28, 2020 02:57AM

I love foxes

https://media.giphy.com/media/Kt3lpGbEkM8i4/giphy.gif

he...@gmail.com <he...@gmail.com> #5Feb 28, 2020 03:01PM

delete

ap...@google.com <ap...@google.com> #6Mar 23, 2020 07:54PM

delete

ap...@google.com <ap...@google.com> #7Apr 6, 2020 11:15PM

Project: platform/prebuilts/androidx/external
Branch: androidx-master-dev

commit c96fb26024f5125484d6f80eca05d570055deb53
Author: Yigit Boyar <yboyar@google.com>
Date: Mon Mar 16 17:22:40 2020

Add shadow plugin to prebuilts

This plugin allows us to jarjar dependencies that might conflict with others.

Bug: 150106190
Test: n/a
Change-Id: I0f344313b27d6ba6e1273142a721dad254124705

A com/github/jengelman/gradle/plugins/shadow/5.2.0/LICENSE
A com/github/jengelman/gradle/plugins/shadow/5.2.0/shadow-5.2.0-sources.jar
A com/github/jengelman/gradle/plugins/shadow/5.2.0/shadow-5.2.0-sources.jar.md5
A com/github/jengelman/gradle/plugins/shadow/5.2.0/shadow-5.2.0-sources.jar.sha1
A com/github/jengelman/gradle/plugins/shadow/5.2.0/shadow-5.2.0.jar
A com/github/jengelman/gradle/plugins/shadow/5.2.0/shadow-5.2.0.jar.md5
A com/github/jengelman/gradle/plugins/shadow/5.2.0/shadow-5.2.0.jar.sha1
A com/github/jengelman/gradle/plugins/shadow/5.2.0/shadow-5.2.0.pom
A com/github/jengelman/gradle/plugins/shadow/5.2.0/shadow-5.2.0.pom.md5
A com/github/jengelman/gradle/plugins/shadow/5.2.0/shadow-5.2.0.pom.sha1

https://android-review.googlesource.com/1260624

ap...@google.com <ap...@google.com> #8Apr 6, 2020 11:15PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 562a37df135f25e77f9103f695308d3945c2e2c7
Author: Yigit Boyar <yboyar@google.com>
Date: Mon Mar 16 13:00:36 2020

Shadow Room's antlr dependency

Anltr runtime does a version check between itself and generated
code and might print a warning if they don't match.
To be safe, Room compiler jarjar's its Antlr dependency so that
it cannot conflict with other annotation processors which might
also use antlr (e.g. data binding)

To ensure it does not break, I've added a verification task to
Room compiler module and also added it as a dependeny to the
buildOnServer task.

The task checks the generated pom for room-compiler to make sure
it does not include antlr but it includes at least one another
dependency (kotlin-stdlib).

I've also added checks for the room-compiler-jar contents to double
check antlr is there and its package is moved.

Bug: 150106190
Test: buildOnServer verifies the output

Change-Id: I2c99cba0b3b42369a4b495e5c086f18f5d0b3bff

M build.gradle
M buildSrc/src/main/kotlin/androidx/build/dependencies/Dependencies.kt
M buildSrc/src/main/kotlin/androidx/build/uptodatedness/TaskUpToDateValidator.kt
M room/benchmark/build.gradle
M room/compiler/build.gradle
M room/integration-tests/autovaluetestapp/build.gradle
M room/integration-tests/kotlintestapp/build.gradle
M room/integration-tests/noappcompattestapp/build.gradle
M room/integration-tests/testapp/build.gradle

https://android-review.googlesource.com/1259721

yb...@google.com <yb...@google.com> Apr 7, 2020 02:20AM

Marked as fixed.

it...@gmail.com <it...@gmail.com> #9Apr 7, 2020 01:59PM

Hi, what is the version this change will be available?

yb...@google.com <yb...@google.com> #10Apr 7, 2020 03:42PM

it is only on master, this might take a while to release as we'll probably make a minor version bump and an alpha to ensure it works fine.

meanwhile, you can try it via: http://androidx.dev/

Room master is fairly stable so there is less risk in using its snapshots (but of course, they are snapshots so there is some risk of instability :) )