Add a Lint warning when using the RequestPermission contract and not using Fragment 1.2.0-alpha02 or higher [152554847]

Fixed

Bug

Status Update

No update yet.

Description

il...@google.com

created issue #1

Mar 26, 2020 11:13PM

Component used: Activity Version used: 1.2.0-alpha02

When using the RequestPermission or RequestPermissions contracts, they will only work if using Fragment 1.2.0-alpha02 or higher since previous versions of FragmentActivity did not call super.onRequestPermissionsResult() (which is how ComponentActivity and hence ActivityResultRegistry get permission results).

Ideally, usages of either of these contracts would show a Lint error if the user depends on an older version of Fragments since these contacts won't work. It should have a quick fix that upgrades them to a new enough version of Fragments.

Comments

ap...@google.com <ap...@google.com> #2Jun 17, 2020 03:38AM

We are Facing this same issue after updating to compose 1.3.0 and also only on Android 9 Devices.

ap...@google.com <ap...@google.com> #3Jun 17, 2020 03:38AM

Note: Some of the latest comments from

b/212982463

could be relevant to this issue

jb...@google.com <jb...@google.com> #4Jun 17, 2020 02:48PM

Marked as fixed.

Hi, Is there any update on this. Any temp workaround would be helpful as well. Currently we have 10s of thousand users per day getting affected by this.

jb...@google.com <jb...@google.com> Jul 2, 2020 01:00AM

Status: Assigned (reopened)

ap...@google.com <ap...@google.com> #5Jul 7, 2020 05:45PM

Project: platform/frameworks/support
Branch: androidx-main

commit e3164fbf4137f9cf60da424aef4b1d9ea5202b6c
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Thu Dec 15 18:00:23 2022

Make our fake Views we use as graphic layer to save nothing as the View's saved instance state.

Because the Views were attached to the hierarchy and had an id their state was saved polluting the state Activity saves in Bundle. Such views have no real state as they are not used as real views.

Test: ComposeViewSavedStateSizeTest
Bug: 260322832
Change-Id: I0b755a3d6a164b6c26aa592e13e206dc45cd5dd9

A compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/platform/ComposeViewSavedStateSizeTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/ViewLayer.android.kt

https://android-review.googlesource.com/2359699

ap...@google.com <ap...@google.com> #6Jul 8, 2020 09:31PM

Project: platform/frameworks/support
Branch: androidx-main

commit 326b394002e0f899fdc0bffc622761bc67bca21b
Author: Andrey Kulikov <andreykulikov@google.com>
Date: Thu Dec 15 16:16:31 2022

Destroy layers added on the nodes when the node is removed

Currently the layer objects are not being removed from the AndroidComposeView in this situation, which means we are not reusing the layers and we keep them attached until the whole AndroidComposeView is not garbage collected.

Test: new test in MeasureAndLayoutDelegateTest
Bug: 260322832
Change-Id: Iaeee5662b4646230cebdafd2484c691df657edda

M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/layout/Helpers.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/layout/MeasureAndLayoutDelegateTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/NodeCoordinator.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/NodeKind.kt

https://android-review.googlesource.com/2359119

jb...@google.com <jb...@google.com> #7Jul 8, 2020 09:37PM

Marked as fixed.

Great. Thank you very much for fixing this. Really appreciate the quick response. Could you share which version this fix will be released?

my...@gmail.com <my...@gmail.com> #8Jul 22, 2020 11:51PM

Hi there! Most likely next release of Compose UI, by mid January. Cheers.

il...@google.com <il...@google.com> #9Jul 22, 2020 11:56PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.ui:ui:1.3.3
androidx.compose.ui:ui:1.4.0-alpha04