Add a Lint warning when using the RequestPermission contract and not using Fragment 1.2.0-alpha02 or higher [152554847]

Fixed

Bug

Status Update

No update yet.

Description

il...@google.com

created issue #1

Mar 26, 2020 11:13PM

Component used: Activity Version used: 1.2.0-alpha02

When using the RequestPermission or RequestPermissions contracts, they will only work if using Fragment 1.2.0-alpha02 or higher since previous versions of FragmentActivity did not call super.onRequestPermissionsResult() (which is how ComponentActivity and hence ActivityResultRegistry get permission results).

Ideally, usages of either of these contracts would show a Lint error if the user depends on an older version of Fragments since these contacts won't work. It should have a quick fix that upgrades them to a new enough version of Fragments.

Comments

ap...@google.com <ap...@google.com> #2Jun 17, 2020 03:38AM

Hi, thanks for reporting, we'll have a look. If you could provide us with a minimum sample app to reproduce the issue, that'd be very helpful.

ap...@google.com <ap...@google.com> #3Jun 17, 2020 03:38AM

I confirm I managed to reproduce with API 23 emulator and the following patch on the sample app. Will investigate further.

Patch below.

***

Index: app/src/main/java/androidx/viewpager2/integration/testapp/cards/CardView.kt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- app/src/main/java/androidx/viewpager2/integration/testapp/cards/CardView.kt (revision 38ea42c142729c777dcf8f3e4bd5100aeca981ec)
+++ app/src/main/java/androidx/viewpager2/integration/testapp/cards/CardView.kt (date 1565281963000)
@@ -16,9 +16,11 @@

package androidx.viewpager2.integration.testapp.cards

+import android.text.SpannableStringBuilder
import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
+import android.widget.EditText
import android.widget.TextView

import androidx.annotation.ColorRes
@@ -28,7 +30,7 @@
/** Inflates and populates a [View] representing a [Card] */
class CardView(layoutInflater: LayoutInflater, container: ViewGroup?) {
val view: View = layoutInflater.inflate(R.layout.item_card_layout, container, false)
- private val textSuite: TextView
+ private val textSuite: EditText
private val textCorner1: TextView
private val textCorner2: TextView

@@ -42,7 +44,7 @@
* Updates the view to represent the passed in card
*/
fun bind(card: Card) {
- textSuite.text = card.suit
+ textSuite.text = SpannableStringBuilder(card.suit)
view.setBackgroundResource(getColorRes(card))

val cornerLabel = card.cornerLabel
Index: app/src/main/res/layout/item_card_layout.xml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- app/src/main/res/layout/item_card_layout.xml (revision 38ea42c142729c777dcf8f3e4bd5100aeca981ec)
+++ app/src/main/res/layout/item_card_layout.xml (date 1565281963000)
@@ -31,13 +31,15 @@
android:textAppearance="@android:style/TextAppearance.Large"
tools:text="A"/>

- <TextView
+ <EditText
android:id="@+id/label_center"
- android:layout_width="wrap_content"
+ android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_gravity="center"
+ android:inputType="text"
+ android:maxLines="1"
android:textAppearance="@android:style/TextAppearance.Large"
- tools:text="♠"/>
+ tools:text="♠" />

<TextView
android:id="@+id/label_bottom"

jb...@google.com <jb...@google.com> #4Jun 17, 2020 02:48PM

Marked as fixed.

Corrected video

jb...@google.com <jb...@google.com> Jul 2, 2020 01:00AM

Status: Assigned (reopened)

ap...@google.com <ap...@google.com> #5Jul 7, 2020 05:45PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 47ac9fee0e3d43b4da33f53b8a2ff590f0d46079
Author: Jakub Gielzak <jgielzak@google.com>
Date: Tue Aug 20 13:57:06 2019

Addressed issues with EditText causing scroll

EditText methods: bringPointIntoView, and handleFocusGainInternal
trigger requestChildRectangleOnScreen in ViewPager2's internal
RecyclerView.

This can cause:
- unwanted scrolling -- e.g. when typing on some API versions
- a jump to page 0 -- EditText sometimes reports over -1M px mScrollX

This fix bypasses requestChildRectangleOnScreen calculations taking
advantage of the fact that PagerSnapHelper constraints valid scroll
values to a snapped position ones, and as a result, the problem is
reduced to choosing the correct currentItem.

Bug: 138044582
Bug: 139432498
Test: ./gradlew viewpager2:connectedCheck

Change-Id: Ia4d3e4e6734183e64f261c7cc76d669deae78da5

A viewpager2/src/androidTest/java/androidx/viewpager2/widget/EditTextFocusTest.kt
M viewpager2/src/main/java/androidx/viewpager2/widget/ViewPager2.java

https://android-review.googlesource.com/1107013

https://goto.google.com/android-sha1/47ac9fee0e3d43b4da33f53b8a2ff590f0d46079

ap...@google.com <ap...@google.com> #6Jul 8, 2020 09:31PM

Fix [1] for this is planned to be released in 1.0.0-beta04.

[1]

http://aosp/1107013

jb...@google.com <jb...@google.com> #7Jul 8, 2020 09:37PM

Marked as fixed.

beta04 with a fix for this was released today

my...@gmail.com <my...@gmail.com> #8Jul 22, 2020 11:51PM

This change seems to crash lint with NoSuchMethodError on Android Studio 4.1.0-beta04.

  /home/circleci/code/mobile: Error: Unexpected failure during lint analysis (this is a bug in lint or one of the libraries it depends on)
  
  Message: com.android.tools.lint.detector.api.Project.getCurrentVariant()Lcom/android/builder/model/Variant;
  
  The crash seems to involve the detector androidx.activity.lint.ActivityResultFragmentVersionDetector.
  You can try disabling it with something like this:
      android {
          lintOptions {
              disable "InvalidFragmentVersionForActivityResult"
          }
      }
  
  Stack: NoSuchMethodError:ActivityResultFragmentVersionDetector.checkDslPropertyAssignment(ActivityResultFragmentVersionDetector.kt:97)←Detector.checkDslPropertyAssignment(Detector.kt:418)←UastGradleVisitor.handleMethodCall(UastGradleVisitor.kt:190)←UastGradleVisitor.access$handleMethodCall(UastGradleVisitor.kt:34)←UastGradleVisitor$visitBuildScript$1.visitCallExpression(UastGradleVisitor.kt:40)←KotlinUFunctionCallExpression.accept(KotlinUFunctionCallExpression.kt:205)←ImplementationUtilsKt.acceptList(implementationUtils.kt:23)←UBlockExpression$DefaultImpls.accept(UBlockExpression.kt:21)
  
  You can set environment variable LINT_PRINT_STACKTRACE=true to dump a full stacktrace to stdout. [LintError]

il...@google.com <il...@google.com> #9Jul 22, 2020 11:56PM

Re #8 - please file a new bug with a sample project.