Add a Lint warning when using the RequestPermission contract and not using Fragment 1.2.0-alpha02 or higher [152554847]

Fixed

Bug

Status Update

No update yet.

Description

il...@google.com

created issue #1

Mar 26, 2020 11:13PM

Component used: Activity Version used: 1.2.0-alpha02

When using the RequestPermission or RequestPermissions contracts, they will only work if using Fragment 1.2.0-alpha02 or higher since previous versions of FragmentActivity did not call super.onRequestPermissionsResult() (which is how ComponentActivity and hence ActivityResultRegistry get permission results).

Ideally, usages of either of these contracts would show a Lint error if the user depends on an older version of Fragments since these contacts won't work. It should have a quick fix that upgrades them to a new enough version of Fragments.

Comments

ap...@google.com <ap...@google.com> #2Jun 17, 2020 03:38AM

Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.

ap...@google.com <ap...@google.com> #3Jun 17, 2020 03:38AM

Great! Thanks a lot, I'll look for the live updates soon!

jb...@google.com <jb...@google.com> #4Jun 17, 2020 02:48PM

Marked as fixed.

This has been fixed internally and will be available in the Activity 1.2.0-alpha07 release.

jb...@google.com <jb...@google.com> Jul 2, 2020 01:00AM

Status: Assigned (reopened)

ap...@google.com <ap...@google.com> #5Jul 7, 2020 05:45PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit a17089efb14fcfb5e3938680f0d3b3103245092c
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Jul 01 17:59:41 2020

Publish the activity lint rule

We should actually publish the lint rule.

Also ignoring any project dependencies since they would be using the
most recent version of fragments anyway.

Test: ./gradlew bOS
Bug: 152554847
Change-Id: Ica57230490024b6aff32fcc3ec83d1c6f800f05f

M activity/activity-ktx/build.gradle
M activity/activity-lint/src/main/java/androidx/activity/lint/ActivityResultFragmentVersionDetector.kt
M activity/activity-lint/src/test/java/androidx/activity/lint/ActivityResultFragmentVersionDetectorTest.kt
M activity/activity/build.gradle
M activity/integration-tests/testapp/build.gradle

https://android-review.googlesource.com/1354243

ap...@google.com <ap...@google.com> #6Jul 8, 2020 09:31PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit be64fe99f1e6800d2df7bc1a0a5ca4ffc38a2f6a
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Jul 07 15:09:23 2020

Make ActivityResult lint look for transitive dependencies

Instead of only looking for explicit fragment dependencies, the
ActivityResultFragmentVersionDetector should also take into
consideration transitive dependencies. This ensures we can catch older
versions in apps that use libraries like appcompat and navigation.

Test: ./gradlew bOS all exisiting tests pass
Bug: 152554847
Change-Id: Id0a3b6c69a685cc46b71f1977a348189780b385a

M activity/activity-ktx/build.gradle
M activity/activity-lint/src/main/java/androidx/activity/lint/ActivityResultFragmentVersionDetector.kt
M activity/integration-tests/testapp/build.gradle

https://android-review.googlesource.com/1356393

jb...@google.com <jb...@google.com> #7Jul 8, 2020 09:37PM

Marked as fixed.

The new lint check can now detect the fragment library as a transitive dependency.

my...@gmail.com <my...@gmail.com> #8Jul 22, 2020 11:51PM

This change seems to crash lint with NoSuchMethodError on Android Studio 4.1.0-beta04.

  /home/circleci/code/mobile: Error: Unexpected failure during lint analysis (this is a bug in lint or one of the libraries it depends on)
  
  Message: com.android.tools.lint.detector.api.Project.getCurrentVariant()Lcom/android/builder/model/Variant;
  
  The crash seems to involve the detector androidx.activity.lint.ActivityResultFragmentVersionDetector.
  You can try disabling it with something like this:
      android {
          lintOptions {
              disable "InvalidFragmentVersionForActivityResult"
          }
      }
  
  Stack: NoSuchMethodError:ActivityResultFragmentVersionDetector.checkDslPropertyAssignment(ActivityResultFragmentVersionDetector.kt:97)←Detector.checkDslPropertyAssignment(Detector.kt:418)←UastGradleVisitor.handleMethodCall(UastGradleVisitor.kt:190)←UastGradleVisitor.access$handleMethodCall(UastGradleVisitor.kt:34)←UastGradleVisitor$visitBuildScript$1.visitCallExpression(UastGradleVisitor.kt:40)←KotlinUFunctionCallExpression.accept(KotlinUFunctionCallExpression.kt:205)←ImplementationUtilsKt.acceptList(implementationUtils.kt:23)←UBlockExpression$DefaultImpls.accept(UBlockExpression.kt:21)
  
  You can set environment variable LINT_PRINT_STACKTRACE=true to dump a full stacktrace to stdout. [LintError]

il...@google.com <il...@google.com> #9Jul 22, 2020 11:56PM

Re #8 - please file a new bug with a sample project.