Build an infrastructure for Fragment Strict Mode [153737341]

Fixed

Feature Request

androidx-bug-bounty

Status Update

No update yet.

Description

il...@google.com

created issue #1

Apr 10, 2020 05:55PM

Component used: Fragment

StrictMode is an Android system level feature for enabling the detection of potential problematic behavior and penalizing issues found (i.e., by enabling logging, throwing exceptions, etc.).

We should build the same type of infrastructure for Fragments so that developers can enable runtime checking for bad behaviors and validate that they (or libraries they depend on) aren't using deprecated APIs or known potential problematic behaviors.

Importantly, this should only be as a second line of defense behind deprecation warnings or Lint warnings to catch these issues at build time or to handle cases where third party libraries / dependencies are triggering these behaviors so that bugs can be filed against them.

We should support at least penaltyLog(), penaltyDeath(), and penaltyListener().

Given that we should maintain behavior compatibility, we should not add any enableDefaults() or detectAll() methods and instead have developers opt into exactly the detect***() methods they want. This should also remove the need for permit***() methods since they'll all default to off.

Ideally, this is something that developers can either:

Set globally via FragmentStrictMode.setDefaultPolicy(FragmentStrictMode.Policy)
Set on a specific FragmentManager (and its children FragmentManagers) via fragmentManager.setStrictModePolicy(FragmentStrictMode.Policy) (this would override the default policy)

This API shouldn't be made public until there is at least two detect***() calls added. These will be filed as separate issues.

Comments

ap...@google.com <ap...@google.com> #2Feb 18, 2021 09:42PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ap...@google.com <ap...@google.com> #3Feb 18, 2021 09:42PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit e154ee09dbd591ffdae6a749cf04a53fd2cbcb13
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Tue Feb 16 10:29:29 2021

[GH] Add initial infrastructure for FragmentStrictMode

## Proposed Changes

- Add initial infrastructure for `FragmentStrictMode`

Found this in the issue tracker and think it's a great idea. I tried to keep the first version as lean and as closely aligned to `StrictMode` as possible. I also plan on creating some follow-up PRs to add a few checks (see issue tracker), as soon as the infrastructure is discussed and somewhat agreed upon. For now the classes are restricted to the library, until we have the first few checks.

## Testing

Test: See `FragmentStrictModeTest`

## Issues Fixed

Fixes: 153737341

This is an imported pull request from

https://github.com/androidx/androidx/pull/123.

Resolves #123
Github-Pr-Head-Sha: e79ad8e4c100f12e637877e5cc6c0764a11de680
GitOrigin-RevId: 5c1aa683d57c18c300f5e4c21dcffd219ac8d675
Change-Id: Ib634f058efddf686db3de6be0dc6b7af1a3de718

M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
A fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
A fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.java
A fragment/fragment/src/main/java/androidx/fragment/app/strictmode/Violation.java

https://android-review.googlesource.com/1575225

ap...@google.com <ap...@google.com> #4Mar 2, 2021 06:27PM

Project: platform/frameworks/support
Branch: androidx-main

commit 39b483d097bcd3b63f4a6200ee33ed1ceda9ca7c
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Tue Mar 02 17:08:35 2021

[GH] Call FragmentStrictMode listeners on main thread of host

## Proposed Changes

- Don't call listeners on the violating thread anymore, instead use the main thread of the host.
- Follow-up to #123, see [here](

https://github.com/androidx/androidx/pull/123#discussion_r568251886) and [here](

https://github.com/androidx/androidx/pull/123#discussion_r570648776)

## Testing

Test: `FragmentStrictModeTest#listenerCalledOnCorrectThread`

## Issues Fixed

Fixes: 153737341

This is an imported pull request from

https://github.com/androidx/androidx/pull/131.

Resolves #131
Github-Pr-Head-Sha: 4c0f698f812a6eec0cffe65cbde2f4388b4e6c1f
GitOrigin-RevId: 77da4ec0f36c1518c635c40f5304603a7f460d28
Change-Id: Ica37a16e5f258b765c105224cf0dcab61b29c52e

M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentHostCallback.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.java

https://android-review.googlesource.com/1612828

ap...@google.com <ap...@google.com> #5Mar 10, 2021 08:31PM

Project: platform/frameworks/support
Branch: androidx-main

commit e2e9e6ba772ac721ddd5448b456f5a49513f8128
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon Mar 08 09:20:24 2021

Ignore strictmode directory in jetifier

Instead of ignoring strictmode classes individually for jetifier, ignore
the entire directory.

RelNote: N/A
Test: ./gradlew bOS
Bug: 153737341
Change-Id: I5d3ba42b5b9369e5e6291e2b21254414b5999ad9

M jetifier/jetifier/migration.config

https://android-review.googlesource.com/1622522

Issue 153737341

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Feb 18, 2021 09:42PM

ap...@google.com <ap...@google.com> #3Feb 18, 2021 09:42PM

ap...@google.com <ap...@google.com> #4Mar 2, 2021 06:27PM

ap...@google.com <ap...@google.com> #5Mar 10, 2021 08:31PM

Add comment

Issue metadata