Build an infrastructure for Fragment Strict Mode [153737341]

Fixed

Feature Request

androidx-bug-bounty

Status Update

No update yet.

Description

il...@google.com

created issue #1

Apr 10, 2020 05:55PM

Component used: Fragment

StrictMode is an Android system level feature for enabling the detection of potential problematic behavior and penalizing issues found (i.e., by enabling logging, throwing exceptions, etc.).

We should build the same type of infrastructure for Fragments so that developers can enable runtime checking for bad behaviors and validate that they (or libraries they depend on) aren't using deprecated APIs or known potential problematic behaviors.

Importantly, this should only be as a second line of defense behind deprecation warnings or Lint warnings to catch these issues at build time or to handle cases where third party libraries / dependencies are triggering these behaviors so that bugs can be filed against them.

We should support at least penaltyLog(), penaltyDeath(), and penaltyListener().

Given that we should maintain behavior compatibility, we should not add any enableDefaults() or detectAll() methods and instead have developers opt into exactly the detect***() methods they want. This should also remove the need for permit***() methods since they'll all default to off.

Ideally, this is something that developers can either:

Set globally via FragmentStrictMode.setDefaultPolicy(FragmentStrictMode.Policy)
Set on a specific FragmentManager (and its children FragmentManagers) via fragmentManager.setStrictModePolicy(FragmentStrictMode.Policy) (this would override the default policy)

This API shouldn't be made public until there is at least two detect***() calls added. These will be filed as separate issues.

Comments

ap...@google.com <ap...@google.com> #2Feb 18, 2021 09:42PM

Jeremy, is this still an issue? I think the problem was that you had two transitions targeting the same View for the same action (e.g. two Slide() transitions).

ap...@google.com <ap...@google.com> #3Feb 18, 2021 09:42PM

Marked as fixed.

I have a similar issue with plain AnimatorSet:

set.start()
set.pause()
set.setCurrentPlayTime(100)
set.setCurrentPlayTime(0)
set.setCurrentPlayTime(100)
set.resume()

doesn't play animation in resume().

ap...@google.com <ap...@google.com> #4Mar 2, 2021 06:27PM

Should clarify that if I filter out setCurrentPlayTime(0) (or replace it with setCurrentPlayTime(1)) it works well.

Also even with setCurrentPlayTime(0), onAnimationEnd is notified with correct delay (as if the animation has played).

ap...@google.com <ap...@google.com> #5Mar 10, 2021 08:31PM

@ #4:

I think that is intended for Animator. If you set the currentPlayTime to 0 or the total duration the animator completes. We do some special checks in fragments to handle it.

Issue 153737341

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Feb 18, 2021 09:42PM

ap...@google.com <ap...@google.com> #3Feb 18, 2021 09:42PM

ap...@google.com <ap...@google.com> #4Mar 2, 2021 06:27PM

ap...@google.com <ap...@google.com> #5Mar 10, 2021 08:31PM

Add comment

Issue metadata