Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 909ebdab73b8a27e1bf0c1831f858118b7b1ded8
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Tue Mar 16 12:52:26 2021
[GH] [FragmentStrictMode] Detect calls to Fragment#setRetainInstance
## Proposed Changes
- Detect calls to `Fragment#setRetainInstance`
## Testing
Test: See `FragmentStrictModeTest#detectSetRetainInstance`
## Issues Fixed
Fixes: 153737954
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/140 .
Resolves #140
Github-Pr-Head-Sha: d13cb82cc1bd4c7e1d69be78b5a11a73be588d5b
GitOrigin-RevId: a4816146982cbd5875728e973b1b164878bfde4d
Change-Id: I9ea91c239dee7b5d251abf48626998ca277f9d36
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/Fragment.java
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.java
A fragment/fragment/src/main/java/androidx/fragment/app/strictmode/RetainInstanceUsageViolation.java
https://android-review.googlesource.com/1640409
Branch: androidx-main
commit 909ebdab73b8a27e1bf0c1831f858118b7b1ded8
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Tue Mar 16 12:52:26 2021
[GH] [FragmentStrictMode] Detect calls to Fragment#setRetainInstance
## Proposed Changes
- Detect calls to `Fragment#setRetainInstance`
## Testing
Test: See `FragmentStrictModeTest#detectSetRetainInstance`
## Issues Fixed
Fixes: 153737954
This is an imported pull request from
Resolves #140
Github-Pr-Head-Sha: d13cb82cc1bd4c7e1d69be78b5a11a73be588d5b
GitOrigin-RevId: a4816146982cbd5875728e973b1b164878bfde4d
Change-Id: I9ea91c239dee7b5d251abf48626998ca277f9d36
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/Fragment.java
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.java
A fragment/fragment/src/main/java/androidx/fragment/app/strictmode/RetainInstanceUsageViolation.java
Description
Component used: Fragment
Allow developers to detect the usage of retained fragments.
This would hook into calls to
setRetainInstance(true)
and apply the appropriate penalties if this detection was enabled.