Status Update
No update yet.
Comments
yb...@google.com
ap...@google.com
From the other issue:
note that it is never the right approach to attach a
<deeplink>to an<activity>destination as that will never give you the right behavior when using anon another app's task (where the system back should immediately take the user back to the app that triggered your deep link). Instead, you should attach your deep link directly to your second activity (either by manually writing the appropriate implicit deep link <intent-filter>or by adding the<deeplink>to the start destination of a nav host in that second activity).
A lint error saying as such when a <deepLink> element is added in Navigation XML would go a really long way to avoiding this case. Our navigation-runtime-lint artifact that would contain this check.
hu...@google.com
We have some
da...@google.com
Branch: androidx-main
commit cd77b4bbe312dd8892dfbb3c662344d13a96c82d
Author: Julia McClellan <juliamcclellan@google.com>
Date: Thu Apr 14 15:31:46 2022
Deep link in activity destination in navigation lint
Test: Included tests of API version and the lint rule
Bug: 178403185
Change-Id: Ic15a5ec165620b7ef5b3f03538cc83b5576add8d
A navigation/navigation-runtime-lint/src/main/java/androidx/navigation/runtime/lint/DeepLinkInActivityDestinationDetector.kt
A navigation/navigation-runtime-lint/src/test/java/androidx/navigation/runtime/lint/ApiLintVersionsTest.kt
M settings.gradle
A navigation/navigation-runtime-lint/build.gradle
M navigation/navigation-runtime/build.gradle
A navigation/navigation-runtime-lint/src/main/java/androidx/navigation/runtime/lint/NavigationRuntimeIssueRegistry.kt
A navigation/navigation-runtime-lint/src/test/java/androidx/navigation/runtime/lint/DeepLinkInActivityDestinationDetectorTest.kt
A navigation/navigation-runtime-lint/src/main/resources/META-INF/services/com.android.tools.lint.client.api.IssueRegistry
Description
Version used: 1.1.0
Devices/Android versions reproduced on: /
Room annotation processor in some cases incorrectly detects the version of JDK and therefore disable incremental support even tho JVM 11 is used. An example of that would be when using JVM with version string `11.0.6+10-post-Ubuntu-1ubuntu118.04.1`. Room annotation processor expects version string to contain exactly 2 dots, but this is not the case with this particular version string as it has additional dots at the end.