Room incremental annotation processor disable on JVM 11 [155215201]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Apr 29, 2020 03:24PM

Component used: room-compiler
Version used: 1.1.0
Devices/Android versions reproduced on: /

Room annotation processor in some cases incorrectly detects the version of JDK and therefore disable incremental support even tho JVM 11 is used. An example of that would be when using JVM with version string `11.0.6+10-post-Ubuntu-1ubuntu118.04.1`. Room annotation processor expects version string to contain exactly 2 dots, but this is not the case with this particular version string as it has additional dots at the end.

Comments

yb...@google.com <yb...@google.com> Apr 30, 2020 03:34PM

Reassigned to hu...@google.com.

ap...@google.com <ap...@google.com> #2Apr 30, 2020 09:40PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit ebc551e6b20af141729910b6629b5c4afa6a5ad7
Author: Blaz Solar <me@blaz.solar>
Date: Wed Apr 29 17:10:25 2020

Allow more thant 2 dots in JVM version string

Bug: 155215201
Test: Added test cases to androidx.room.util.SimpleJavaVersionTest
Test: ./gradlew :room:room-compiler:test --tests androidx.room.util.SimpleJavaVersionTest

Change-Id: Ie1c7cd963a29bbced649526db588fa7b882ab705

M room/compiler/src/main/kotlin/androidx/room/util/SimpleJavaVersion.kt
M room/compiler/src/test/kotlin/androidx/room/util/SimpleJavaVersionTest.kt

https://android-review.googlesource.com/1298775

hu...@google.com <hu...@google.com> #3May 1, 2020 09:32AM

Reassigned to da...@google.com.

This issue has been fixed. Over to Daniel for release information.

da...@google.com <da...@google.com> #4May 1, 2020 03:23PM

Marked as fixed.

Thanks for the contribution! I have to schedule a release but if you want to a Room version containing head to https://androidx.dev to check out how to use snapshot versions.

da...@google.com <da...@google.com> #5May 1, 2020 03:24PM

Ups, my last comment was horribly worded. *Go to https://androidx.dev to learn how to use snapshot versions of Room containing the fix.

Issue 155215201