Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d61f169b9495a1d8f855a7b6a1c8fce18bc9713d
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Apr 30 15:58:34 2020
Add "clear" methods to FragmentResult APIs
Currently the FragmentResultOwner class only has the setFragmentResult()
and setFragmentResultListener methods. Both of these methods take a
Nullable parameter and in order to clear the result/listener developers
need to pass in null for that parameter. While this does work, it would
be more explicit if there were a separate API.
This change adds clearFragmentResult() and clearFragmentResultListener()
as the method of removing previously set results/listeners. The set
methods above no longer take Nullable parameters.
This change also adds the clear method to the Fragment -ktx.
Test: FragmentResultTest
Bug: 155416778
Change-Id: I3dfeb38a319829c6305e683b0bf335b92daaaa46
M fragment/fragment-ktx/api/1.3.0-alpha05.txt
M fragment/fragment-ktx/api/current.txt
M fragment/fragment-ktx/api/public_plus_experimental_1.3.0-alpha05.txt
M fragment/fragment-ktx/api/public_plus_experimental_current.txt
M fragment/fragment-ktx/api/restricted_1.3.0-alpha05.txt
M fragment/fragment-ktx/api/restricted_current.txt
M fragment/fragment-ktx/src/androidTest/java/androidx/fragment/app/FragmentResultOwnerTest.kt
M fragment/fragment-ktx/src/main/java/androidx/fragment/app/Fragment.kt
M fragment/fragment-ktx/src/main/java/androidx/fragment/app/FragmentResultOwner.kt
M fragment/fragment/api/1.3.0-alpha05.txt
M fragment/fragment/api/current.txt
M fragment/fragment/api/public_plus_experimental_1.3.0-alpha05.txt
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_1.3.0-alpha05.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentResultTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentResultOwner.java
https://android-review.googlesource.com/1299030
Branch: androidx-master-dev
commit d61f169b9495a1d8f855a7b6a1c8fce18bc9713d
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Apr 30 15:58:34 2020
Add "clear" methods to FragmentResult APIs
Currently the FragmentResultOwner class only has the setFragmentResult()
and setFragmentResultListener methods. Both of these methods take a
Nullable parameter and in order to clear the result/listener developers
need to pass in null for that parameter. While this does work, it would
be more explicit if there were a separate API.
This change adds clearFragmentResult() and clearFragmentResultListener()
as the method of removing previously set results/listeners. The set
methods above no longer take Nullable parameters.
This change also adds the clear method to the Fragment -ktx.
Test: FragmentResultTest
Bug: 155416778
Change-Id: I3dfeb38a319829c6305e683b0bf335b92daaaa46
M fragment/fragment-ktx/api/1.3.0-alpha05.txt
M fragment/fragment-ktx/api/current.txt
M fragment/fragment-ktx/api/public_plus_experimental_1.3.0-alpha05.txt
M fragment/fragment-ktx/api/public_plus_experimental_current.txt
M fragment/fragment-ktx/api/restricted_1.3.0-alpha05.txt
M fragment/fragment-ktx/api/restricted_current.txt
M fragment/fragment-ktx/src/androidTest/java/androidx/fragment/app/FragmentResultOwnerTest.kt
M fragment/fragment-ktx/src/main/java/androidx/fragment/app/Fragment.kt
M fragment/fragment-ktx/src/main/java/androidx/fragment/app/FragmentResultOwner.kt
M fragment/fragment/api/1.3.0-alpha05.txt
M fragment/fragment/api/current.txt
M fragment/fragment/api/public_plus_experimental_1.3.0-alpha05.txt
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_1.3.0-alpha05.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentResultTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentResultOwner.java
jb...@google.com <jb...@google.com> #3
This has been fixed internally and will be included in the Fragment 1.3.0-alpha05 release.
re...@lunabee.com <re...@lunabee.com> #4
The javadoc has not been updated (L60)
* @param listener listener for result changes or `null` to remove any previously
* registered listener.
il...@google.com <il...@google.com> #5
Re #4 - please star the
Description
Currently the
setFragmentResult()
andsetFragmentResultListener()
APIs require you to pass in a null object for them to be cleared out.It would be more explicit if we added
clearFragmentResult/Listener()
APIs.