Error for invalid transition types should be better [155574969]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

May 4, 2020 03:44PM

Component used: Fragment
Version used: 1.2.4
Devices/Android versions reproduced on: N/A

If both the platform and AndroidX transitions are both used in a fragment transition you get this error:

    java.lang.IllegalArgumentException: Invalid Transition types
        at androidx.fragment.app.FragmentTransition.chooseImpl(FragmentTransition.java:521)
        at androidx.fragment.app.FragmentTransition.configureTransitionsReordered(FragmentTransition.java:240)
        at androidx.fragment.app.FragmentTransition.startTransitions(FragmentTransition.java:152)
        at androidx.fragment.app.FragmentManager.completeExecute(FragmentManager.java:2121)
        at androidx.fragment.app.FragmentManager$StartEnterTransitionListener.completeTransaction(FragmentManager.java:3022)
        at androidx.fragment.app.FragmentManager.executePostponedTransaction(FragmentManager.java:1895)
        at androidx.fragment.app.FragmentManager.ensureExecReady(FragmentManager.java:1803)
        at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:1843)
        at androidx.fragment.app.FragmentManager$4.run(FragmentManager.java:413)
        at android.os.Handler.handleCallback(Handler.java:873)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:193)
        at android.app.ActivityThread.main(ActivityThread.java:6971)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:865)

It's not very helpful or tell you how to fix it.

It would be very useful if it listed the following:

Which fragment has the problem
Which transitions are conflicting
What you should do to fix it

It's very easy to accidentally import the wrong transition by accident

Comments

il...@google.com <il...@google.com> #2May 4, 2020 04:29PM

Assigned to il...@google.com.

It seems that this ordering is caused by FragmentManager's addAddedFragments(), which is being removed/reworked as part of b/147749580. It should be straightforward to fix this once that is done, but I'll mark this as being blocked by that issue.

il...@google.com <il...@google.com> #3Aug 3, 2020 11:50PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 4ea7d82a7e17dd5a20aa0d581add0ba34874e485
Author: Ian Lake <ilake@google.com>
Date: Mon Jul 20 17:12:55 2020

Ensure fragments move to the expected state in op order

When using the new FragmentStateManager, we
should ensure that fragments move to their expected
state in the same order as the underlying operations -
i.e., in the order that they were added to the
FragmentTransaction.

This ensures that replace()'d fragments are stopped
before their replacement fragments move through
lifecycle methods, avoiding cases where both fragments
are simultaneously started.

Due to how the previous code works, this fix *only*
applies when using the new FragmentStateManager.

Test: new FragmentReorderingTest passes
BUG: 161654580
Change-Id: I32662cf3ec8bc5bd9a232b2572c91b5567a47f2f

M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentReorderingTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java

https://android-review.googlesource.com/1367610

Issue 155574969

Description

Issue summary

Comments

il...@google.com <il...@google.com> #2May 4, 2020 04:29PM

il...@google.com <il...@google.com> #3Aug 3, 2020 11:50PM

Add comment

Issue metadata