Error for invalid transition types should be better [155574969]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

May 4, 2020 03:44PM

Component used: Fragment
Version used: 1.2.4
Devices/Android versions reproduced on: N/A

If both the platform and AndroidX transitions are both used in a fragment transition you get this error:

    java.lang.IllegalArgumentException: Invalid Transition types
        at androidx.fragment.app.FragmentTransition.chooseImpl(FragmentTransition.java:521)
        at androidx.fragment.app.FragmentTransition.configureTransitionsReordered(FragmentTransition.java:240)
        at androidx.fragment.app.FragmentTransition.startTransitions(FragmentTransition.java:152)
        at androidx.fragment.app.FragmentManager.completeExecute(FragmentManager.java:2121)
        at androidx.fragment.app.FragmentManager$StartEnterTransitionListener.completeTransaction(FragmentManager.java:3022)
        at androidx.fragment.app.FragmentManager.executePostponedTransaction(FragmentManager.java:1895)
        at androidx.fragment.app.FragmentManager.ensureExecReady(FragmentManager.java:1803)
        at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:1843)
        at androidx.fragment.app.FragmentManager$4.run(FragmentManager.java:413)
        at android.os.Handler.handleCallback(Handler.java:873)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:193)
        at android.app.ActivityThread.main(ActivityThread.java:6971)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:865)

It's not very helpful or tell you how to fix it.

It would be very useful if it listed the following:

Which fragment has the problem
Which transitions are conflicting
What you should do to fix it

It's very easy to accidentally import the wrong transition by accident

Comments

il...@google.com <il...@google.com> #2May 4, 2020 04:29PM

Assigned to il...@google.com.

While trying to plug a custom build system using the steps listed in the following page (https://developer.android.com/build/cxx-ninja#alternative-build-method) I've run into the following problems:

Not directly matching one of the params listed ("-p:Platform=Foo", "-p:Configuration=Bar") exactly results in an error.
- For example:
  - [bug 213607318] Ninja-generating script must accept a parameter the defines the target Configuration name. Currently accepted examples are: -p:Configuration=Debug, -p:NinjaProject=Teapots, and /DCMAKE_BUILD_TYPE=MinSizeRel Please refer to bug https://issuetracker.google.com/213607318 for more information.
- Because of this using your own generator is painful since I need now support directly options form ninja or cmake (however using CMake's mentioned options also seems to not be accepted)

The generated command file is NOT a valid batch script, calling it directly fails with the following error:

"{ninja.configure}" ^
  "{ninja.path}" ^
  configure ^
  "-p:Configuration=release" ^
  "-p:Platform=arm64-v8a"
 from <path>\build\android_gradle\simple
 =release"" was unexpected at this time.

The configuration is the following:

            experimentalProperties["ninja.abiFilters"] = listOf("arm64-v8a")
            experimentalProperties["ninja.path"] = "arbitrary_file"
            experimentalProperties["ninja.configure"] = "command"
            experimentalProperties["ninja.arguments"] = listOf(
                    "\${ndk.moduleMakeFile}",
                    "configure",
                    "-p:Configuration=\${ndk.variantName}",
                    "-p:Platform=\${ndk.abi}"

Any help resolving the issues either by workarounds or ideas would help a lot! Thanks in advance!

il...@google.com <il...@google.com> #3Aug 3, 2020 11:50PM

Marked as fixed.

100 %

Issue 155574969

Description

Issue summary

Comments

il...@google.com <il...@google.com> #2May 4, 2020 04:29PM

il...@google.com <il...@google.com> #3Aug 3, 2020 11:50PM

Add comment

Issue metadata