Resolved font resource Typeface weight and style have wrong values on API 29 [156853883]

Fixed

Bug

Status Update

No update yet.

Description

dr...@gmail.com

created issue #1

May 18, 2020 07:44AM

When using ResourcesCompat.getFont to resolve a .ttf file in res/font, the returned Typeface instance always has a weight of 400 and a style of NORMAL.

On all APIs < 29, style correctly resolves to ITALIC. On API 28, weight correctly resolves to 300.

The font actually looks correct when displayed on an API 29 device, it just has the wrong values according to the Typeface instance.

The issue is reproducible in this test class. Several tests fail on API 29 only due to this issue. I've also added a temporary typefaceBug test case that uses an ActivityScenario to demonstrate that the text actually appears correctly on API 29.

Comments

dr...@gmail.com <dr...@gmail.com> #2May 18, 2020 07:45AM

Project: platform/frameworks/support
Branch: androidx-main

commit 81120ca77c09c437775232585652b293ed572d45
Author: Clara Fok <clarafok@google.com>
Date: Thu Feb 29 17:29:44 2024

Paging to use common MainThread annotation

Test: ANDROIDX_PROJECTS=INFRAROGUE ./gradlew paging:paging-common:allTest
Bug: 327682438
Change-Id: I78f0d3cf36e3a3a9088e0698c351289cf2dbc1bf

M paging/paging-common/build.gradle
D paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/MainThread.jvm.kt
D paging/paging-common/src/commonMain/kotlin/androidx/paging/MainThread.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingDataPresenter.kt

https://android-review.googlesource.com/2984997

ki...@google.com <ki...@google.com> May 18, 2020 12:30PM

Reassigned to an...@google.com.

no...@google.com <no...@google.com> #3May 27, 2020 11:59PM

Reassigned to no...@google.com.

Fixed internally and available in paging-3.3.0-alpha05

si...@google.com <si...@google.com> #4Jun 3, 2020 04:59PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.paging:paging-common:3.3.0-alpha05
androidx.paging:paging-common-android:3.3.0-alpha05
androidx.paging:paging-common-iosarm64:3.3.0-alpha05
androidx.paging:paging-common-iossimulatorarm64:3.3.0-alpha05
androidx.paging:paging-common-iosx64:3.3.0-alpha05
androidx.paging:paging-common-jvm:3.3.0-alpha05
androidx.paging:paging-common-linuxx64:3.3.0-alpha05
androidx.paging:paging-common-macosarm64:3.3.0-alpha05
androidx.paging:paging-common-macosx64:3.3.0-alpha05

ap...@google.com <ap...@google.com> #5Jun 3, 2020 05:16PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 3d6aa2e9b3243dcc4de1f54bd8d40339bd69cb05
Author: Seigo Nonaka <nona@google.com>
Date: Wed May 27 17:38:05 2020

Adjust the Typeface display style with the style of given font

This behavir is implicitly done by Typeface.Builder and
Typeface.createXXX function but not to be done by
Typeface.CustomFallbackBuilder since it is designed to be working
with multiple font files which has different style.

Looks like the style argument is ignored on older API implementation.

Bug: 156853883
Bug: 152023266
Test: ResourcesCompatTest#testGetFont_adjustDisplayStyle passes on 29
Test: ./gradlew core:core:connectedAndroidTest on API 29, 28, 23
Change-Id: I3a377c339a7aed50973cf11df86ddf0069f4ec25

A core/core/src/androidTest/assets/fonts/thin_italic.ttf
A core/core/src/androidTest/assets/fonts/thin_italic.ttx
M core/core/src/androidTest/java/androidx/core/content/res/ResourcesCompatTest.java
A core/core/src/androidTest/res/font/thin_italic.ttf
M core/core/src/main/java/androidx/core/graphics/TypefaceCompatApi29Impl.java

https://android-review.googlesource.com/1318947

si...@google.com <si...@google.com> Jun 10, 2020 09:53PM

Marked as fixed.

an...@google.com <an...@google.com> #6Jun 11, 2020 11:14AM

The following changes were cherrypicked through Coastguard Release Track: (https://android-build.googleplex.com/coastguard/dashboard/6222780589080576/#/history/all) Changes: aosp/1318947

dr...@gmail.com <dr...@gmail.com> #7Jun 12, 2020 08:01PM

Any way I can tell what version this will land in?

si...@google.com <si...@google.com> #8Jun 17, 2020 04:43PM

should be in 1.5.0-alpha1 https://developer.android.com/jetpack/androidx/releases/core#1.5.0-alpha01

dr...@gmail.com <dr...@gmail.com> #9Jun 17, 2020 07:30PM

Great—works as expected, thanks!