Resolved font resource Typeface weight and style have wrong values on API 29 [156853883]

Fixed

Bug

Status Update

No update yet.

Description

dr...@gmail.com

created issue #1

May 18, 2020 07:44AM

When using ResourcesCompat.getFont to resolve a .ttf file in res/font, the returned Typeface instance always has a weight of 400 and a style of NORMAL.

On all APIs < 29, style correctly resolves to ITALIC. On API 28, weight correctly resolves to 300.

The font actually looks correct when displayed on an API 29 device, it just has the wrong values according to the Typeface instance.

The issue is reproducible in this test class. Several tests fail on API 29 only due to this issue. I've also added a temporary typefaceBug test case that uses an ActivityScenario to demonstrate that the text actually appears correctly on API 29.

Comments

dr...@gmail.com <dr...@gmail.com> #2May 18, 2020 07:45AM

Duplicate of internal issue b/155379937. Fixed in 1.2.0-rc02:

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 45a1bc4a15b5b10d0635d79fb55df2aced5a2a4a
Author: Alan Viverette <alanv@google.com>
Date:   Thu May 14 18:06:25 2020

    Only apply DayNight changes to Activity-hosted delegates
   
    Dialogs can't receive configuration change callbacks, so there's no point
    in updating their configurations. They'll have to be destroyed and re-
    created by their host activities. Also, dialogs were eating the changes.
   
    Fixes: 155379937
    Test: NightModeForegroundDialogTestCase and appcompat test suite
    Change-Id: Ifa18d9d42268ec8821223942dc6c817ecabbed7f

A       appcompat/appcompat/src/androidTest/java/androidx/appcompat/app/NightModeDialogFragment.java
A       appcompat/appcompat/src/androidTest/java/androidx/appcompat/app/NightModeForegroundDialogTestCase.kt
M       appcompat/appcompat/src/main/java/androidx/appcompat/app/AppCompatDelegate.java
M       appcompat/appcompat/src/main/java/androidx/appcompat/app/AppCompatDelegateImpl.java

ki...@google.com <ki...@google.com> May 18, 2020 12:30PM

Reassigned to an...@google.com.

no...@google.com <no...@google.com> #3May 27, 2020 11:59PM

Reassigned to no...@google.com.

I think, sActiveDelegates meant "live" delegates. Anyway, now there's a mess :(

private static final ArraySet<WeakReference<AppCompatDelegate>> sActivityDelegates;
private static final Object sActivityDelegatesLock;

static void addActiveDelegate(@NonNull AppCompatDelegate delegate);
static void removeActivityDelegate(@NonNull AppCompatDelegate delegate);
private static void removeDelegateFromActives(@NonNull AppCompatDelegate toRemove);
private static void applyDayNightToActiveDelegates();

Source: https://android-review.googlesource.com/c/platform/frameworks/support/+/1348308/

si...@google.com <si...@google.com> #4Jun 3, 2020 04:59PM

Re: comment#3, I don't follow. Are you saying there is still an issue in 1.2.0.rc02 or just commenting on the overall code structure?

ap...@google.com <ap...@google.com> #5Jun 3, 2020 05:16PM

Rc02 is work for me, thanks for your work!

si...@google.com <si...@google.com> Jun 10, 2020 09:53PM

Marked as fixed.

an...@google.com <an...@google.com> #6Jun 11, 2020 11:14AM

The following changes were cherrypicked through Coastguard Release Track: (https://android-build.googleplex.com/coastguard/dashboard/6222780589080576/#/history/all) Changes: aosp/1318947

dr...@gmail.com <dr...@gmail.com> #7Jun 12, 2020 08:01PM

Any way I can tell what version this will land in?

si...@google.com <si...@google.com> #8Jun 17, 2020 04:43PM

should be in 1.5.0-alpha1 https://developer.android.com/jetpack/androidx/releases/core#1.5.0-alpha01

dr...@gmail.com <dr...@gmail.com> #9Jun 17, 2020 07:30PM

Great—works as expected, thanks!