AGP should not re-run dexing when user deploy to devices with different API levels from the IDE [157701376]

Fixed

Bug

Status Update

No update yet.

Description

xa...@google.com

created issue #1

May 29, 2020 03:28AM

For tasks that change their behavior based on different values of minSdkVersion, we should ensure that the task input is not actually the minSdkVersion but instead one (or more) boolean based on the value of minSdkVersion.

For example the desugaring value should be something like

abstract val lighterDesugaring: Property<Boolean>

ligherDesugaring.set(minSdkVersion >= 24)

The reason is that deploying to different devices can trigger re-run of the build if the minSdkVersion changed, even though it may not have cross the threshold (in either direction).

For instance see the attached screenshot showing a re-run of the dex merger (AGP 4.0) due to a minSdkVersion change after doing a build from the CLI followed by a deploy in Studio. There may be no need to re-run the task if the threshold was not crossed.

We should also make sure that Build Attribution can get enough information from the re-run so that we can explain why the task re-ran, with more info that jus the threshold boolean value having changed. For instance, it would be good to know what the threshold is, and potentially what the previous minSdkVersion was so that we can explain it all to the users (we are already discussing showing the injected values of minSdkVersion vs the value defined in the build.) The display could show:

Previous build: minSdkVersion 21
Current build: minSdkVersion 24 (injected to match device <blah>).
               Overrides build configuration value: 21

Task re-run because task property lighterDesugaring changed from false to true due to minSdkVersion being >= 24

image.png

17 KB

View

Download

Comments

cm...@google.com <cm...@google.com> #2May 29, 2020 09:18AM

Attached about beta. It constantly telling me it will update gradle plugin, but it seems it already have.

Android Studio 4.1 RC 1
Build #AI-201.8743.12.41.6719854, built on July 29, 2020
Runtime version: 1.8.0_242-release-1644-b01 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 10.0
GC: ParNew, ConcurrentMarkSweep
Memory: 1970M
Cores: 12
Registry: ide.new.welcome.screen.force=true, debugger.watches.in.variables=false
Non-Bundled Plugins: String Manipulation, org.intellij.plugins.markdown, org.jetbrains.kotlin

ga...@google.com <ga...@google.com> #3May 29, 2020 10:04AM

And same for canary.

Also attached the project.

xa...@google.com <xa...@google.com> #4May 29, 2020 05:18PM

Thanks for the report. To let you know about progress on this:

the project won't open on 4.0, as it uses AGP 4.1 features, which Studio 4.0 doesn't support;
the PlayCoreKtx project has been updated so that it should open without trouble on 4.1 RC1;
the issue with Studio looping over upgrading the plugin version is a real one, so it won't open on current canaries, which automatically attempt (and fail) to upgrade the project. I'm expecting that we will fix this before 4.2 Beta.

Thanks again!

ga...@google.com <ga...@google.com> Jun 28, 2021 08:57AM

Reassigned to bu...@google.com.

bu...@google.com <bu...@google.com> Jun 29, 2021 04:12PM

Accepted by bu...@google.com.

bu...@google.com <bu...@google.com> #5Jul 8, 2021 05:12PM

@4 Please always make sure your projects work, and write which Android Studio versions are supported or not.

I've tried now again with the currently latest versions of each.
This time, the canary and the stable failed, but the beta didn't.
See attached.

Android Studio 4.0.1
Build #AI-193.6911.18.40.6626763, built on June 25, 2020
Runtime version: 1.8.0_242-release-1644-b01 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 10.0
GC: ParNew, ConcurrentMarkSweep
Memory: 7954M
Cores: 12
Registry: ide.new.welcome.screen.force=true
Non-Bundled Plugins: String Manipulation, org.jetbrains.kotlin, com.google.services.firebase, ignaciotcrespo.github.com.vector-drawable-thumbnails, org.intellij.plugins.markdown

Android Studio 4.1 RC 1
Build #AI-201.8743.12.41.6719854, built on July 29, 2020
Runtime version: 1.8.0_242-release-1644-b01 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 10.0
GC: ParNew, ConcurrentMarkSweep
Memory: 1970M
Cores: 12
Registry: ide.new.welcome.screen.force=true, debugger.watches.in.variables=false
Non-Bundled Plugins: String Manipulation, org.intellij.plugins.markdown, org.jetbrains.kotlin

Android Studio 4.2 Canary 8
Build #AI-202.6397.94.42.6787931, built on August 25, 2020
Runtime version: 11.0.7+10-b765.53 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 10.0
GC: G1 Young Generation, G1 Old Generation
Memory: 2038M
Cores: 12
Registry: ide.settings.move.mouse.on.default.button=true, debugger.watches.in.variables=false
Non-Bundled Plugins: String Manipulation

xa...@google.com <xa...@google.com> #6Jul 8, 2021 05:26PM

I'm glad that it works for you in 4.1 RC 1 -- as and when new RCs (and 4.1 final) in the 4.1 series are released, the project will need a manual upgrade (which I expect we will do) in order for it to be cleanly openable.

I just tried with 4.2 Canary 10, and the project opened and built cleanly here. In your video from comment #5, one of the fixes suggested was to restart the Gradle daemons; my guess (only a guess) as to what happened there is that you had some stale daemons still running from a different session. I'd definitely be interested if you can reproduce a failure to open with 4.2 Canary 10 and definitively no stale state.

Thanks!

bu...@google.com <bu...@google.com> #7Jul 12, 2021 01:24PM

Marked as fixed.

@6 I don't understand what you mean.
I just open Android Studio and try to open the project. What's wrong with that?

Anyway, tested again.
Still failed with stable, and now with beta too:

Android Studio 4.0.1
Build #AI-193.6911.18.40.6626763, built on June 25, 2020
Runtime version: 1.8.0_242-release-1644-b01 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 10.0
GC: ParNew, ConcurrentMarkSweep
Memory: 7954M
Cores: 12
Registry: ide.new.welcome.screen.force=true
Non-Bundled Plugins: String Manipulation, org.jetbrains.kotlin, com.google.services.firebase, ignaciotcrespo.github.com.vector-drawable-thumbnails, org.intellij.plugins.markdown

On beta, it asked to update gradle multiple times and still fails to open properly. Including when I tell it that I will do it manually.

Android Studio 4.1 RC 2
Build #AI-201.8743.12.41.6776251, built on August 19, 2020
Runtime version: 1.8.0_242-release-1644-b01 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 10.0
GC: ParNew, ConcurrentMarkSweep
Memory: 1970M
Cores: 12
Registry: ide.new.welcome.screen.force=true, debugger.watches.in.variables=false
Non-Bundled Plugins: String Manipulation, org.intellij.plugins.markdown, org.jetbrains.kotlin

Only on canary it worked this time:

Android Studio 4.2 Canary 10
Build #AI-202.6397.94.42.6811877, built on September 3, 2020
Runtime version: 11.0.7+10-b765.53 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 10.0
GC: G1 Young Generation, G1 Old Generation
Memory: 2038M
Cores: 12
Registry: ide.settings.move.mouse.on.default.button=true, debugger.watches.in.variables=false
Non-Bundled Plugins: String Manipulation, org.intellij.plugins.markdown