Fragments call requestInsets() before views are attached [158095749]

Fixed

Bug

Status Update

No update yet.

Description

il...@google.com

created issue #1

Jun 3, 2020 05:39PM

Component used: Fragment Version used: 1.3.0-alpha05

Fragments call ViewCompat.requestApplyInsets() immediately before calling onViewCreated(). However, due to b/149024125, this runs before the View is attached, meaning requestApplyInsets() doesn't actually do anything.

We should consistently wait for the View to be attached before calling requestApplyInsets().

Comments

ap...@google.com <ap...@google.com> #2Jun 4, 2020 09:28PM

Great

il...@google.com <il...@google.com> #3Jun 17, 2020 02:28AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit a735aaa4d06c90454de772fae5a02f6cbde210b3
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Feb 28 22:58:23 2023

Ensure FragmentNavigator destroys intermediate entries on popUpTo

We need to make sure that when Fragment are destroyed their entries are
also always destroyed.

RelNote: "Fixes a regressions in previous release that caused the wrong
BottomNav menu item to be highlighted when using system back to go
between tabs."
Test: Added FragmentNavigatorTest
Bug: 270447657

Change-Id: I634f6047b7016bcb8b690047605a6f66b2dc1438

M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt

https://android-review.googlesource.com/2461556

Issue 158095749

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Jun 4, 2020 09:28PM

il...@google.com <il...@google.com> #3Jun 17, 2020 02:28AM

Add comment

Issue metadata