Lint NullSafeMutableLiveData get ObsoleteLintCustomCheck warning [158699265]

Fixed

Bug

Status Update

No update yet.

Description

ke...@gmail.com

created issue #1

Jun 11, 2020 01:03AM

Component used: lifecycle-livedata-ktx
Version used: 2.3.0-alpha04
Devices/Android versions reproduced on: Android Studio 4.0 (AGP 4.0)

I get below lint warning when running ./gradlew lint.

Lint found an issue registry (androidx.lifecycle.lint.LiveDataCoreIssueRegistry) which requires a newer API level. That means that the custom lint checks are intended for a newer lint version; please upgrade
Lint can be extended with "custom checks": additional checks implemented by developers and libraries to for example enforce specific API usages required by a library or a company coding style guideline.

NullSafeMutableLiveData is not working.

This issue may be related.

I'll attach the reproduction project and lint results. Please check it.

Thanks.

lint-check.zip

163 KB

Download

Comments

se...@google.com <se...@google.com> Jun 11, 2020 11:31AM

Reassigned to jb...@google.com.

jb...@google.com <jb...@google.com> #2Jun 19, 2020 05:29PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

jb...@google.com <jb...@google.com> Jul 8, 2020 09:24PM

Status: Assigned (reopened)

ap...@google.com <ap...@google.com> #3Jul 8, 2020 11:07PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit f891d66d44417ae7298d8306dc5cbca9cfe4b1ee
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Jul 08 14:20:29 2020

Fix lifecycle-livedata-core-ktx-lint ObsoleteLintCustomCheck

Using the latest version of lint-core (27.1.0) as a dependency for the
livedata-core lint rule causes an ObsoleteLintCustomCheck for studio 4.0
and 4.1 (along with the subsequent gradle versions).

Instead of using the latest, using the minimum version seems to work
appropriately.

Added a lintMinVersion variable to the dependcies file and used that to
make updating easier.

Test: tested in studio 4.0 and 4.1-Canary 8
Bug: 158699265
Change-Id: If1636b3e08a368cf25fb268f42754c4c6ff2f463

M buildSrc/src/main/kotlin/androidx/build/dependencies/Dependencies.kt
M lifecycle/lifecycle-livedata-core-ktx-lint/build.gradle

https://android-review.googlesource.com/1358530

jb...@google.com <jb...@google.com> #4Jul 9, 2020 04:16PM

Marked as fixed.

There was a use of a lint version that was too new to work in older studio versions. This has now be fixed and will be released in the Lifecycle 2.3.0-alpha06 release.

de...@gmail.com <de...@gmail.com> #5May 20, 2024 07:07PM

Getting this again in AGP 8.2.2 and Gradle 8.6, please see the attached image file.

Tue May 21 2024 03:07:31 GMT+0800 (Philippine Standard Time).png

196 KB

View

Download

de...@gmail.com <de...@gmail.com> #6May 20, 2024 07:14PM

Just found out that the issue comes after updating androidx.lifecycle:lifecycle-livedata-ktx from 2.7.0 to 2.8.0.

da...@gmail.com <da...@gmail.com> #7Jul 26, 2024 12:57PM

Using AGP 8.5.1 with Gradle 8.7 makes the latest occurrence of this go away for me (with androidx.lifecycle:lifecycle-runtime-ktx 2.8.4).

zo...@gmail.com <zo...@gmail.com> #8Aug 31, 2024 08:17PM

This has come back using on AGP 8.7.0-alpha09 (starting maybe with alpha05 according to my build history? maybe alpha04?).

I'm using Gradle 8.9 as well, if that matters.