AppCompatDelegate.setDefaultNightMode() almost never changes theme [158923881]

Fixed

Bug

Status Update

No update yet.

Description

fg...@gmail.com

created issue #1

Jun 14, 2020 02:00PM

Component used: Activity
Version used: 1.2.0-rc01 and 1.3.0-alpha01
Devices/Android versions reproduced on: Emulator Pixel 3 API 29, Emulator Pixel 2 API 28, Samsung S9 API 29

Calls to AppCompatDelegate.setDefaultNightMode() don't work well on the latest AppCompat versions, but it works on the latest stable version.
Most of the time, the theme doesn't change.

DayNightApplication.zip

2.3 MB

Download

Comments

ki...@google.com <ki...@google.com> Jun 14, 2020 11:43PM

Reassigned to al...@google.com.

al...@google.com <al...@google.com> #2Jun 15, 2020 02:20PM

Marked as fixed.

Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.

e....@gmail.com <e....@gmail.com> #3Jul 22, 2020 06:11PM

Great! Thanks a lot, I'll look for the live updates soon!

al...@google.com <al...@google.com> #4Jul 22, 2020 06:41PM

Re: comment#3, I don't follow. Are you saying there is still an issue in 1.2.0.rc02 or just commenting on the overall code structure?

pe...@gmail.com <pe...@gmail.com> #5Jul 28, 2020 12:37PM

Rc02 is work for me, thanks for your work!

Issue 158923881