[library desugaring] Add an Android resource backed ZoneRulesProvider [159295560]

Obsolete

Feature Request

Status Update

No update yet.

Description

sg...@google.com

created issue #1

Jun 18, 2020 07:18AM

Add a ZoneRulesProvider to the desugared library that can read a tzdb.dat resource as an Android asset and not just a Java resource. Could also be that this should be a separate small support library and not bundled with the desugared library itself.

This should include a way to load the data in the background and making it easier to control when the loading happens.

The current TzdbZoneRulesProvider which is in the desugared library can only read the tzdb.dat data from a Java resource and the reading happens whenever the class ZoneRulesProvider is loaded.

This came up during the internal discussion on documenting how to use the TzdbZoneRulesProvider and an app provided tzdb.dat Java resource together with library desugaring.

Comments

sg...@google.com <sg...@google.com> #2Jun 18, 2020 07:19AM

Can you please provide some more information? I assume this stacktrace is from an exception, but I don't know what type of exception it is or which version of Android is involved.

Can you also give details on how you got this to happen and how often it happens? Do you have a sample project that causes this to occur?

Message last modified on Jun 18, 2020 07:20AM

za...@gmail.com <za...@gmail.com> #3Jun 19, 2020 03:47PM

Sorry for not making it too clear.

The Exception it's throwing is an IllegalArgumentException in android.net.ConnectivityManager in unregisterNetworkCallback (Invalid NetworkCallback)

This is happening in our production app (after we introduced workmanager) and it's been happening for some time now.
It's happening only in Nvidia Shield Tablet and Nvidia Shield Tablet K1. We have around 200 crashes per day.

ih...@gmail.com <ih...@gmail.com> #4Jul 21, 2023 05:34PM

Which Android API version is this?

sg...@google.com <sg...@google.com> #5Sep 13, 2023 11:16AM

Status: Won't Fix (Obsolete)

It's happening 100% on API 24

l....@gmail.com <l....@gmail.com> #6Sep 13, 2023 11:33AM

Do you mind attaching a logcat and a sample of your code?

sg...@google.com <sg...@google.com> #7Sep 13, 2023 11:50AM

I'm unable to reproduce this crash in my dev device. It's happening in out prod build. I've attached the crash log here - Not really sure how helpful that can be

https://gist.github.com/supreethprakash/01bc952ab80eba2d9f2478070cba627f

Our code is not in play here, it could be happening when some scheduled job is about to run

e....@gmail.com <e....@gmail.com> #8Sep 13, 2023 01:38PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 56776a6d2eddef14d8275828f665df1177d52ac6
Author: Sumir Kataria <sumir@google.com>
Date: Thu Nov 15 14:53:31 2018

Speculative fix for IAE on NVIDIA Shield tablets.

We can't reproduce this on other devices, but Shield Tablets on
API 24 can return an IllegalArgumentException for some reason.
Since this isn't something that is fatal to WorkManager, we
will catch the exception and move on safely.

Bug: 119484416
Test: Ran existing tests.
Change-Id: If42c1c9257ebf7d36ddab11a3f24401ead731636

M work/workmanager/src/main/java/androidx/work/impl/constraints/trackers/NetworkStateTracker.java

https://android-review.googlesource.com/828360

https://goto.google.com/android-sha1/56776a6d2eddef14d8275828f665df1177d52ac6

sg...@google.com <sg...@google.com> #9Sep 13, 2023 01:59PM

If an app is built using desugared library and minSdk below 26 then java.time will be desugared (to j$.time for which the implementation will be included in the app), and the desugared code will be used independent of the the API level of the device the app is running on. There is no runtime checking of whether java.time is present. If the app is built using desugared library and a minSdk of 26 or above then java.time will not be desugared and all java.time code will use the runtime java.time implementation.

As explained in comment #5 and comment #7 app specific TZDB is possible with desugared library. That also works when running on devices with an API level of 26 or above. This requires that the app is built with a minSdk of 25 or below to enable library desugaring of java.time.

It is true that when java.time was introduces in Android 8 (API level 26) updating TZDB required a system image update, whereas from Android 8.1 updating TZDB became possible without a system image update.