NullSafeMutableLiveData on 2.3.0-alpha05 [159987480]

Fixed

Bug

Status Update

No update yet.

Description

my...@gmail.com

created issue #1

Jun 26, 2020 04:38PM

Component & version used:

val lifecycleVersion = "2.3.0-alpha05"
implementation("androidx.lifecycle:lifecycle-common-java8:$lifecycleVersion")
implementation("androidx.lifecycle:lifecycle-livedata-ktx:$lifecycleVersion")
implementation("androidx.lifecycle:lifecycle-runtime-ktx:$lifecycleVersion")

Devices/Android versions reproduced on: N/A

Source code: https://github.com/Mygod/VPNHotspot/commit/cc14f607ef48bba755350e68bef68c0f256377fd

Circle CI build: https://app.circleci.com/pipelines/github/Mygod/VPNHotspot/92/workflows/6676d5ec-59eb-4353-845a-4a398c53d90f/jobs/459/steps (should be accessible with any account)

Relevant part of compiler output:

* What went wrong:
Execution failed for task ':mobile:lint'.
> Lint found errors in the project; aborting build.
  
  Fix the issues identified by lint, or add the following to your build script to proceed with errors:
  ...
  android {
      lintOptions {
          abortOnError false
      }
  }
  ...
  The first 3 errors (out of 6) were:
  
  /home/circleci/code/mobile/src/main/java/be/mygod/vpnhotspot/client/ClientViewModel.kt: Error: Unexpected failure during lint analysis of ClientViewModel.kt (this is a bug in lint or one of the libraries it depends on)
  
  Message: null cannot be cast to non-null type org.jetbrains.uast.UAnnotated
  
  The crash seems to involve the detector androidx.lifecycle.lint.NonNullableMutableLiveDataDetector.
  You can try disabling it with something like this:
      android {
          lintOptions {
              disable "NullSafeMutableLiveData"
          }
      }
  
  Stack: TypeCastException:NonNullableMutableLiveDataDetectorKt.isNullable(NonNullableMutableLiveDataDetector.kt:197)←NonNullableMutableLiveDataDetector.visitMethodCall(NonNullableMutableLiveDataDetector.kt:133)←UElementVisitor$DelegatingPsiVisitor.visitMethodCallExpression(UElementVisitor.kt:1079)←UElementVisitor$DelegatingPsiVisitor.visitCallExpression(UElementVisitor.kt:1059)←KotlinUFunctionCallExpression.accept(KotlinUFunctionCallExpression.kt:205)←UQualifiedReferenceExpression$DefaultImpls.accept(UQualifiedReferenceExpression.kt:34)←KotlinUQualifiedReferenceExpression.accept(KotlinUQualifiedReferenceExpression.kt:27)←ImplementationUtilsKt.acceptList(implementationUtils.kt:23)
  
  You can set environment variable LINT_PRINT_STACKTRACE=true to dump a full stacktrace to stdout. [LintError]

Comments

my...@gmail.com <my...@gmail.com> #2Jun 26, 2020 05:34PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 87f4c988b713e43deef88a0df6a31c507f11b4a8
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed May 27 11:20:32 2020

Use setMaxLifecycle for FragmentScenario moveToState

Current FragmentScenario uses ActivityScenario to for the moveToState
method. That means moving to STARTED does not work prior to API 23. This
also means that tests including DialogFragment cannot be moved to
CREATED, only ACTIVITY_CREATED.

This change uses setMaxLifecycle instead, so that FragmentScenario is
decoupled from ActivityScenario and there are no longer any restrictions
on moving to API 23 and DialogFragment's can be properly moved to
CREATED.

Test: ran tests on API 21 device and they passed
Bug: 156527405
Change-Id: I63d5facfcce9875acf06e39029686cb535cc3ea6

M fragment/fragment-testing/src/androidTest/java/androidx/fragment/app/testing/FragmentScenarioDialogFragmentTest.kt
M fragment/fragment-testing/src/androidTest/java/androidx/fragment/app/testing/FragmentScenarioTest.kt
M fragment/fragment-testing/src/main/java/androidx/fragment/app/testing/FragmentScenario.java

https://android-review.googlesource.com/1318600

se...@google.com <se...@google.com> Jul 2, 2020 04:26PM

Reassigned to jb...@google.com.

jb...@google.com <jb...@google.com> #3Jul 8, 2020 09:07PM

This has been fixed internally and will be available in Fragment 1.3.0-alpha07.

my...@gmail.com <my...@gmail.com> #4Jul 8, 2020 09:29PM

The sample at #1 should be using 2.3.0-alpha05 out of the box. I do not have a minimal sample at the time, sorry.

jb...@google.com <jb...@google.com> #5Jul 8, 2020 09:47PM

Status: Won't Fix (Not Reproducible)

That sample was using lifecycle 2.2.0 when I opened it. Upgraded it to 2.3.0-alpha05 and got an ObsoleteLintCustomCheck which is being addressed in this bug.

Gonna close this as not reproducible, and once you get a chance to reproduce it, just upload it here and would be happy to take a look.

my...@gmail.com <my...@gmail.com> #6Jul 9, 2020 12:16AM

Can you try this again: https://github.com/Mygod/VPNHotspot/commit/8674369b5baf7241e734c5ddb4d3f97a19b311c5

Lint produced by Circle CI: https://483-116107171-gh.circle-artifacts.com/0/reports/lint-results.html#LintError

../../src/main/java/be/mygod/vpnhotspot/client/ClientViewModel.kt: Unexpected failure during lint analysis of ClientViewModel.kt (this is a bug in lint or one of the libraries it depends on)

Message: null cannot be cast to non-null type org.jetbrains.uast.UAnnotated

The crash seems to involve the detector androidx.lifecycle.lint.NonNullableMutableLiveDataDetector.
You can try disabling it with something like this:
    android {
        lintOptions {
            disable "NullSafeMutableLiveData"
        }
    }

Stack: TypeCastException:NonNullableMutableLiveDataDetectorKt.isNullable(NonNullableMutableLiveDataDetector.kt:197)
←NonNullableMutableLiveDataDetector.visitMethodCall(NonNullableMutableLiveDataDetector.kt:133)
←UElementVisitor$DelegatingPsiVisitor.visitMethodCallExpression(UElementVisitor.kt:1079)
←UElementVisitor$DelegatingPsiVisitor.visitCallExpression(UElementVisitor.kt:1059)
←KotlinUFunctionCallExpression.accept(KotlinUFunctionCallExpression.kt:205)
←UQualifiedReferenceExpression$DefaultImpls.accept(UQualifiedReferenceExpression.kt:34)
←KotlinUQualifiedReferenceExpression.accept(KotlinUQualifiedReferenceExpression.kt:27)
←ImplementationUtilsKt.acceptList(implementationUtils.kt:23)

You can set environment variable LINT_PRINT_STACKTRACE=true to dump a full stacktrace to stdout.

Also reproducible locally on Android Studio 4.1 beta 3.

jb...@google.com <jb...@google.com> #7Jul 9, 2020 06:13PM

Status: Assigned (reopened)

Still couldn't make see in the app. But was able to reproduce based on the class throwing the error and get a fix.

ap...@google.com <ap...@google.com> #8Jul 9, 2020 06:59PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 236cdbe9c248e30d0120e5c23933b74581ae9198
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jul 09 11:00:56 2020

Fix NullSafeMutableLiveData resolve error

When attempting to assign a MutableList to a MutableLiveData value, the
lint rule can fail to resolve a DOT_EXPRESSION and throw an error.

We should add null checks to avoid the error.

Test: Added NonNullableMutableLiveData test
Bug: 159987480
Change-Id: Ie3136bdd5362e7aa699a2b0b2f42caac03ed5217

M lifecycle/lifecycle-livedata-core-ktx-lint/build.gradle
M lifecycle/lifecycle-livedata-core-ktx-lint/src/main/java/androidx/lifecycle/lint/NonNullableMutableLiveDataDetector.kt
M lifecycle/lifecycle-livedata-core-ktx-lint/src/test/java/androidx/lifecycle/lint/NonNullableMutableLiveDataDetectorTest.kt

https://android-review.googlesource.com/1358935

jb...@google.com <jb...@google.com> #9Jul 9, 2020 07:14PM

Marked as fixed.

This has been fixed internally and will be available in the Lifecycle 2.3.0-alpha06 release.

my...@gmail.com <my...@gmail.com> #10Jul 23, 2020 01:27AM

Hi the error at line 133 seems resolved in alpha06 but the error at line 105 is still there.

b9...@gmail.com <b9...@gmail.com> #11Jul 26, 2020 06:51PM

My lint check passed in 2.3.0-alpha05 but failed in 2.3.0-alpha06 with this same error: `Message: org.jetbrains.kotlin.asJava.elements.KtLightMethodImpl cannot be cast to com.intellij.psi.PsiVariable`

jb...@google.com <jb...@google.com> #12Jul 27, 2020 06:36PM

please file a new bug with a minimal sample project.