NullSafeMutableLiveData on 2.3.0-alpha05 [159987480]

Fixed

Bug

Status Update

No update yet.

Description

my...@gmail.com

created issue #1

Jun 26, 2020 04:38PM

Component & version used:

val lifecycleVersion = "2.3.0-alpha05"
implementation("androidx.lifecycle:lifecycle-common-java8:$lifecycleVersion")
implementation("androidx.lifecycle:lifecycle-livedata-ktx:$lifecycleVersion")
implementation("androidx.lifecycle:lifecycle-runtime-ktx:$lifecycleVersion")

Devices/Android versions reproduced on: N/A

Source code: https://github.com/Mygod/VPNHotspot/commit/cc14f607ef48bba755350e68bef68c0f256377fd

Circle CI build: https://app.circleci.com/pipelines/github/Mygod/VPNHotspot/92/workflows/6676d5ec-59eb-4353-845a-4a398c53d90f/jobs/459/steps (should be accessible with any account)

Relevant part of compiler output:

* What went wrong:
Execution failed for task ':mobile:lint'.
> Lint found errors in the project; aborting build.
  
  Fix the issues identified by lint, or add the following to your build script to proceed with errors:
  ...
  android {
      lintOptions {
          abortOnError false
      }
  }
  ...
  The first 3 errors (out of 6) were:
  
  /home/circleci/code/mobile/src/main/java/be/mygod/vpnhotspot/client/ClientViewModel.kt: Error: Unexpected failure during lint analysis of ClientViewModel.kt (this is a bug in lint or one of the libraries it depends on)
  
  Message: null cannot be cast to non-null type org.jetbrains.uast.UAnnotated
  
  The crash seems to involve the detector androidx.lifecycle.lint.NonNullableMutableLiveDataDetector.
  You can try disabling it with something like this:
      android {
          lintOptions {
              disable "NullSafeMutableLiveData"
          }
      }
  
  Stack: TypeCastException:NonNullableMutableLiveDataDetectorKt.isNullable(NonNullableMutableLiveDataDetector.kt:197)←NonNullableMutableLiveDataDetector.visitMethodCall(NonNullableMutableLiveDataDetector.kt:133)←UElementVisitor$DelegatingPsiVisitor.visitMethodCallExpression(UElementVisitor.kt:1079)←UElementVisitor$DelegatingPsiVisitor.visitCallExpression(UElementVisitor.kt:1059)←KotlinUFunctionCallExpression.accept(KotlinUFunctionCallExpression.kt:205)←UQualifiedReferenceExpression$DefaultImpls.accept(UQualifiedReferenceExpression.kt:34)←KotlinUQualifiedReferenceExpression.accept(KotlinUQualifiedReferenceExpression.kt:27)←ImplementationUtilsKt.acceptList(implementationUtils.kt:23)
  
  You can set environment variable LINT_PRINT_STACKTRACE=true to dump a full stacktrace to stdout. [LintError]

Comments

my...@gmail.com <my...@gmail.com> #2Jun 26, 2020 05:34PM

Please include a sample project that reproduces your issue.

se...@google.com <se...@google.com> Jul 2, 2020 04:26PM

Reassigned to jb...@google.com.

jb...@google.com <jb...@google.com> #3Jul 8, 2020 09:07PM

Sample project attached. Just add to plain project this dependencies allow to reproduce.

def emoji2_version = "1.1.0-beta01"
implementation "androidx.emoji2:emoji2:$emoji2_version"

def lifecycle_version = "2.5.0-alpha01"
implementation "androidx.lifecycle:lifecycle-process:$lifecycle_version"

my...@gmail.com <my...@gmail.com> #4Jul 8, 2020 09:29PM

The reason may be related to this change, which check itself before it is initialized. Use 2.4.0 of lifecycle-process as workaround.

jb...@google.com <jb...@google.com> #5Jul 8, 2020 09:47PM

Status: Won't Fix (Not Reproducible)

Yes, this is due to this change, as well as the fact that EmojiCompatInitializer has a ProcessLifecycleInitializer as a dependency and also re-calls it, but in manual mode.

my...@gmail.com <my...@gmail.com> #6Jul 9, 2020 12:16AM

ProcessLifecycleInitializer is expected to already be initialized (via the manifest provider for App Startup) by the time that code runs - App Startup shouldn't be calling create if that component has already been initialized, hence you shouldn't get any exception. We'll take a look on where things are breaking down though.

jb...@google.com <jb...@google.com> #7Jul 9, 2020 06:13PM

Status: Assigned (reopened)

Thanks for the answer.

As I understand EmojiCompatInitializer has ProcessLifecycleInitializer as a dependency. That is mean, the ProcessLifecycleInitializer must be executed before the EmojiCompatInitializer, which in its create method calls the delayUntilFirstResume method, which in turn calls the ProcessLifecycleInitializer via appInitializer.initializeComponent(ProcessLifecycleInitializer.class)

Maybe it would be more correct to create a bug in emoji-2, but let it be here.

ap...@google.com <ap...@google.com> #8Jul 9, 2020 06:59PM

This issue isn't related to emoji2, it could be reproduced easily with the lifecycle-process (2.4.0 -> 2.5.0-alpha01) only.

jb...@google.com <jb...@google.com> #9Jul 9, 2020 07:14PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 97993ad954cb98211ef52b6e26c7877dbdeeec1c
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Feb 01 17:06:11 2022

Bump lifecycle process start-up dependency to 1.1.1

Bumping the startup dependency to include aosp/1855769.

RelNote: "Updated `lifecycle-process` to depend on [Startup 1.1.1](/jetpack/androidx/releases/startup#1.1.1) to ensure that fixes that prevent `ProcessLifecycleInitializer` from throwing a `StartupException` are available by default."
Bug: 216490724
Test: tested in sample app

Change-Id: Ib01dfbba1d63aa03e43e09ee8886cc76e1050e1b

M lifecycle/lifecycle-process/build.gradle

https://android-review.googlesource.com/1964554

my...@gmail.com <my...@gmail.com> #10Jul 23, 2020 01:27AM

This has been fixed internally and will be released in the Lifecycle 2.5.0-alpha02 release.

b9...@gmail.com <b9...@gmail.com> #11Jul 26, 2020 06:51PM

When will start-up 1.1.1 release?

jb...@google.com <jb...@google.com> #12Jul 27, 2020 06:36PM

It should be out before the end of the week.