Subsequent calls to RemoteMediator#load when load interior is suspending and room db is updating data [160447763]

Duplicate

of 162252536

Bug

Status Update

No update yet.

Description

ro...@gmail.com

created issue #1

Jul 3, 2020 07:35PM

Component used: Paging 3 Version used: 'androidx.paging:paging-runtime-ktx:3.0.0-alpha02' Devices/Android versions reproduced on: Emulator / Device: Samsung S9 w/Q

If this is a bug in the library, we would appreciate if you could attach:

Sample project to trigger the issue.
A screenrecord or screenshots showing the issue (if UI related).

Referencing to: https://issuetracker.google.com/160192222 #12:

It seems that the LoadType.PREPEND requests are legitimate, but there are subsequent LoadType.APPEND reoccurring (with same PID) when load suspends (IE room database query with "withTransaction") on the first LoadType.APPEND. Shouldn't load wait for the returning MediatorResult before calling load again (Look for my arrows to the right in table below)?

2020-07-03 20:38:32.883 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: ( loadType = REFRESH )
2020-07-03 20:38:32.885 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: LoadType.REFRESH returning null (initial load)
2020-07-03 20:38:36.177 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: getNullableDeviceLocation = DeviceLocation(userId=user, location_valid=true, timestamp=2020-07-03 20:35:18, latitude=61.8907267, longitude=6.6761067, locationAccuracy=5.0, hasLocationAccuracy=true, altitude=0.0, altitudeAccuracy=0.5, hasAltitude=true, hasAltitudeAccuracy=true, bearing=90.0, bearingAccuracy=30.0, hasBearing=true, hasBearingAccuracy=true, speed=0.0, speedAccuracy=0.5, hasSpeed=true, hasSpeedAccuracy=true, isFromMockProvider=false, provider=fused, countrycode=NO, countryname=Norway, hasCountry=true, countrysource=GPS)
2020-07-03 20:38:36.190 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: resets range to 1.0
2020-07-03 20:38:36.205 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: range = 1.0
2020-07-03 20:38:36.205 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: countryCode = NO
2020-07-03 20:38:36.205 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: userSelection.selectionArea = Global
2020-07-03 20:38:36.205 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: userSelection.selectionSorting = Nearest
2020-07-03 20:38:36.205 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: global, nearest, range = 1.0
2020-07-03 20:38:40.113 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: req.size = 20
2020-07-03 20:38:40.455 4736-4901/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 123431: Tenden kai: 61.898161, 6.706100 -> 61.8907267, 6.6761067
2020-07-03 20:38:40.602 4736-4901/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 567: Gas Tech Stryn: 61.903396, 6.703216 -> 61.8907267, 6.6761067
2020-07-03 20:38:40.708 4736-4901/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 67335: Shell: 61.90265549999999, 6.7093816 -> 61.8907267, 6.6761067
2020-07-03 20:38:40.757 4736-4901/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 528: Grønn Kontakt Stryn: 61.902648, 6.715088 -> 61.8907267, 6.6761067
2020-07-03 20:38:40.772 4736-4901/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 4: YX Stryn: 61.900956, 6.717184 -> 61.8907267, 6.6761067
2020-07-03 20:38:40.817 4736-4901/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 1: Esso Stryn: 61.902877, 6.717453 -> 61.8907267, 6.6761067
2020-07-03 20:38:40.865 4736-4901/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 243: Rema 1000 Stryn: 61.9036521911621, 6.71779918670654 -> 61.8907267, 6.6761067
2020-07-03 20:38:40.879 4736-4901/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 209: Berge Co: 61.9050559997559, 6.72660493850708 -> 61.8907267, 6.6761067
2020-07-03 20:38:40.943 4736-4901/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 2: Circle K Langesethøgda: 61.899546, 6.613435 -> 61.8907267, 6.6761067
2020-07-03 20:38:41.001 4736-4901/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 44: YX Aut. Innvik : 61.851811, 6.614512 -> 61.8907267, 6.6761067
2020-07-03 20:38:41.073 4736-4901/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 127695: YX Innvik: 61.8517929, 6.614505599999998 -> 61.8907267, 6.6761067
2020-07-03 20:38:41.135 4736-4901/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 3: Circle K Automat Olden: 61.841645, 6.811233 -> 61.8907267, 6.6761067
2020-07-03 20:38:41.280 4736-4901/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 127806: Park Mount Skala: 61.86730249999999, 6.879369699999999 -> 61.8907267, 6.6761067
2020-07-03 20:38:41.403 4736-4901/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 6: YX Hornindal: 61.967029, 6.525517 -> 61.8907267, 6.6761067
2020-07-03 20:38:41.436 4736-4901/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 26876: Grønn Kontakt Grodås: 61.969173, 6.525817 -> 61.8907267, 6.6761067
2020-07-03 20:38:41.475 4736-4901/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 127696: Utvik brygge: 61.8066701, 6.528109599999999 -> 61.8907267, 6.6761067
2020-07-03 20:38:41.482 4736-4901/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 73186: mh24 utvik: 61.8065922, 6.518116999999999 -> 61.8907267, 6.6761067
2020-07-03 20:38:41.494 4736-4901/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 506: MH24 Byrkjelo: 61.734587, 6.5068259 -> 61.8907267, 6.6761067
2020-07-03 20:38:41.539 4736-4901/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 832: Viking Byrkjelo: 61.7332361, 6.507499099999999 -> 61.8907267, 6.6761067
2020-07-03 20:38:41.550 4736-4901/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 96161: Grønn Kontakt Byrkjelo: 61.733450, 6.506469 -> 61.8907267, 6.6761067
2020-07-03 20:38:50.603 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: ( loadType = PREPEND )
2020-07-03 20:38:50.604 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: LoadType.PREPEND state.lastItemOrNull()?.stationId = 96161
2020-07-03 20:38:50.604 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: LoadType.PREPEND returning endOfPaginationReached = true
2020-07-03 20:38:50.625 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: ( loadType = APPEND )
2020-07-03 20:38:50.625 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: LoadType.APPEND state.lastItem.stationId = 96161
2020-07-03 20:38:50.632 4736-4904/no.rogo.emptyfuel I/StationListRemoteMediator2: load: LoadType.APPEND querying remoteKeyFromStationId lastItem.stationID = 96161   <--- Suspends !!
2020-07-03 20:38:51.226 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: ( loadType = APPEND )                                                        <--- Another arrives !!
2020-07-03 20:38:51.226 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: LoadType.APPEND state.lastItem.stationId = 96161
2020-07-03 20:38:51.234 4736-4903/no.rogo.emptyfuel I/StationListRemoteMediator2: load: LoadType.APPEND querying remoteKeyFromStationId lastItem.stationID = 96161   <--- Suspends again !!
2020-07-03 20:38:51.316 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: LoadType.APPEND remoteKeyFromStationId found = StationListRemoteKey(stationId=96161, prevKey=null, nextKey=2)  <---Data arrives
2020-07-03 20:38:51.316 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: LoadType.APPEND returning remoteKey.nextKey = 2
2020-07-03 20:38:51.328 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: getNullableDeviceLocation = DeviceLocation(userId=user, location_valid=true, timestamp=2020-07-03 20:38:40, latitude=61.8907267, longitude=6.6761067, locationAccuracy=5.0, hasLocationAccuracy=true, altitude=0.0, altitudeAccuracy=0.5, hasAltitude=true, hasAltitudeAccuracy=true, bearing=90.0, bearingAccuracy=30.0, hasBearing=true, hasBearingAccuracy=true, speed=0.0, speedAccuracy=0.5, hasSpeed=true, hasSpeedAccuracy=true, isFromMockProvider=false, provider=fused, countrycode=NO, countryname=Norway, hasCountry=true, countrysource=GPS)
2020-07-03 20:38:51.355 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: range = 1.0
2020-07-03 20:38:51.356 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: countryCode = NO
2020-07-03 20:38:51.356 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: userSelection.selectionArea = Global
2020-07-03 20:38:51.356 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: userSelection.selectionSorting = Nearest
2020-07-03 20:38:51.356 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: global, nearest, range = 1.0
2020-07-03 20:38:51.785 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: req.size = 20
2020-07-03 20:38:51.788 4736-4903/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 7: CK Bjørnereim : 61.733405, 6.502145 -> 61.8907267, 6.6761067
2020-07-03 20:38:51.789 4736-4903/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 127692: ???? ???? Esso: 61.732023, 6.5071461 -> 61.8907267, 6.6761067
2020-07-03 20:38:51.789 4736-4903/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 45: Best Byrkjelo: 61.7319488525391, 6.50718832015991 -> 61.8907267, 6.6761067
2020-07-03 20:38:51.790 4736-4903/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 130808: Best Byrkjelo: 61.7318791, 6.5069594 -> 61.8907267, 6.6761067
2020-07-03 20:38:51.791 4736-4903/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 82745: YX Hellesylt: 62.08562499999999, 6.870086000000001 -> 61.8907267, 6.6761067
2020-07-03 20:38:51.792 4736-4903/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 835: Circle K Automat Hjelledalen: 61.91847730000001, 7.169982 -> 61.8907267, 6.6761067
2020-07-03 20:38:51.798 4736-4903/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 8: Best Sandane: 61.769847, 6.232689 -> 61.8907267, 6.6761067
2020-07-03 20:38:51.805 4736-4903/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 836: Best: 61.76977239999999, 6.232649899999999 -> 61.8907267, 6.6761067
2020-07-03 20:38:51.811 4736-4903/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 527: Tesla Supercharge Sandane : 61.777968, 6.213336 -> 61.8907267, 6.6761067
2020-07-03 20:38:51.811 4736-4903/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 629: Circle K Automat Sandane: 61.782930, 6.202792 -> 61.8907267, 6.6761067
2020-07-03 20:38:51.813 4736-4903/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 122547: Uno X Nordfjordeid: 61.910468, 6.003159 -> 61.8907267, 6.6761067
2020-07-03 20:38:51.813 4736-4903/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 76385: SHELL CRT NORDFJORDEID: 61.90404, 5.99887 -> 61.8907267, 6.6761067
2020-07-03 20:38:51.817 4736-4903/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 837: Circle K Eid: 61.90622059999999, 5.993726400000001 -> 61.8907267, 6.6761067
2020-07-03 20:38:51.818 4736-4903/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 43: Circle K Nordfjordeid: 61.906135559082, 5.99368333816528 -> 61.8907267, 6.6761067
2020-07-03 20:38:51.819 4736-4903/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 25790: Esso Eid: 61.9063877, 5.991443400000001 -> 61.8907267, 6.6761067
2020-07-03 20:38:51.820 4736-4903/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 760: Grøn Kontakt Amfi Nordfjordeid: 61.908942, 5.985504 -> 61.8907267, 6.6761067
2020-07-03 20:38:51.821 4736-4903/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 838: Yx Geiranger: 62.1026487, 7.2053619 -> 61.8907267, 6.6761067
2020-07-03 20:38:51.824 4736-4903/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 25791: Eid Servicesenter A/S: 61.9121035, 5.980904 -> 61.8907267, 6.6761067
2020-07-03 20:38:51.834 4736-4903/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 10: Esso Nordfjordeid: 61.912197, 5.980782 -> 61.8907267, 6.6761067
2020-07-03 20:38:51.841 4736-4903/no.rogo.emptyfuel I/StationListRemoteMediator2: load: station map 126658: EID: 61.91230869999999, 5.980252399999999 -> 61.8907267, 6.6761067
2020-07-03 20:38:51.943 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: ( loadType = PREPEND )
2020-07-03 20:38:51.944 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: LoadType.PREPEND state.lastItemOrNull()?.stationId = 96161
2020-07-03 20:38:51.944 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: LoadType.PREPEND returning endOfPaginationReached = true
2020-07-03 20:38:52.441 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: ( loadType = PREPEND )
2020-07-03 20:38:52.441 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: LoadType.PREPEND state.lastItemOrNull()?.stationId = 126658
2020-07-03 20:38:52.441 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: LoadType.PREPEND returning endOfPaginationReached = true
2020-07-03 20:39:26.220 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: ( loadType = PREPEND )
2020-07-03 20:39:26.221 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: LoadType.PREPEND state.lastItemOrNull()?.stationId = 126658
2020-07-03 20:39:26.221 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: LoadType.PREPEND returning endOfPaginationReached = true
2020-07-03 20:49:24.820 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: ( loadType = PREPEND )
2020-07-03 20:49:24.820 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: LoadType.PREPEND state.lastItemOrNull()?.stationId = 126658
2020-07-03 20:49:24.821 4736-4736/no.rogo.emptyfuel I/StationListRemoteMediator2: load: LoadType.PREPEND returning endOfPaginationReached = true

Here's my new implementation for the RemoteMediator:

private const val STATION_LIST_STARTING_PAGE_INDEX = 1

@OptIn(ExperimentalPagingApi::class)
class StationListRemoteMediator2(
    private val appDatabase: AppDatabase
): RemoteMediator<Int, StationWithKindPrice>(){

    private val TAG by lazy { this::class.java.simpleName }

    override suspend fun load(
        loadType: LoadType,
        state: PagingState<Int, StationWithKindPrice>
    ): MediatorResult {
        Log.i(TAG, "load: ( loadType = $loadType )")
        var page = when(loadType){

            LoadType.REFRESH -> {
                Log.i(TAG, "load: LoadType.REFRESH returning null (initial load)")
                null
            }

            LoadType.PREPEND -> {
                Log.i(TAG,
                    "load: LoadType.PREPEND state.lastItemOrNull()?.stationId = " +
                            "${state.lastItemOrNull()?.stationId}")
                Log.i(TAG, "load: LoadType.PREPEND returning endOfPaginationReached = true")
                return MediatorResult.Success(endOfPaginationReached = true)
            }

            LoadType.APPEND -> {
                val lastItem = state.lastItemOrNull()?.let {
                    Log.i(TAG, "load: LoadType.APPEND state.lastItem.stationId = ${it.stationId}")
                    return@let it
                } ?: let {
                    Log.i(TAG, "load: LoadType.APPEND state.lastItem = null, no data to append")
                    return MediatorResult.Success(endOfPaginationReached = true)
                }

                val remoteKey = appDatabase.withTransaction {  //Suspecting this suspend to open up for another 'load' call
                    Log.i(
                        TAG, "load: LoadType.APPEND querying remoteKeyFromStationId " +
                                "lastItem.stationID = ${lastItem.stationId}"
                    )
                    appDatabase.stationListRemoteKeyDao().remoteKeyFromStationId(lastItem.stationId)
                }?.let {
                    Log.i(TAG, "load: LoadType.APPEND remoteKeyFromStationId found = $it")
                    return@let it
                } ?: let {
                    Log.w(TAG, "load: LoadType.APPEND remoteKeyFromStationID found null")
                    return MediatorResult.Success(endOfPaginationReached = true)
                }

                Log.i(
                    TAG,
                    "load: LoadType.APPEND returning remoteKey.nextKey = ${remoteKey.nextKey}"
                )

                remoteKey.nextKey ?: return MediatorResult.Success(endOfPaginationReached = true)


            }

        }

        try {

            if(page==null) page=1

            val apiService = APIFamappClientFactory.makeAPIFamappInterfaceService()

            var endOfPaginationReached = false

            val deviceLocation =
                appDatabase.deviceLocationDao().getNullableDeviceLocation()?.let {
                    Log.i(TAG, "load: getNullableDeviceLocation = $it")
                    return@let it
                } ?:let{
                    Log.w(TAG, "load: getNullableDeviceLocation == null", )
                    return MediatorResult.Error(Throwable("No location data!!"))
                }

            val user = appDatabase.userDao().getUser()
                ?:return MediatorResult.Error(Throwable("No user registered yet !!"))

            val userSelection = appDatabase.userSelectionDao().getNullableUserSelection()
                ?:return MediatorResult.Error(Throwable("No user selections !!"))


            var range:String? = if(page <= 1){
                Log.i(TAG, "load: resets range to 1.0")
                CoroutineScope(Dispatchers.IO).launch {
                    appDatabase.userSelectionDao().updateCurrentRange("1.0")
                }
                "1.0"
            } else userSelection.currentRange;

            Log.i(TAG, "load: range = $range")

            val countryCode: String

            countryCode = if(userSelection.selectionAutoCountry)
            {
                deviceLocation.countrycode
                    ?:user.tmsNWCountryISO?.toUpperCase(Locale.ROOT)
                    ?:user.tmsSIMCountryISO?.toUpperCase(Locale.ROOT)
                    ?:userSelection.selectionCountry?:"--"
            }
            else
            {
                userSelection.selectionCountry
                    ?:user.tmsNWCountryISO?.toUpperCase(Locale.ROOT)
                    ?:user.tmsSIMCountryISO?.toUpperCase(Locale.ROOT)
                    ?:deviceLocation.countrycode?:"--"
            }

            Log.i(TAG,"load: countryCode = $countryCode")
            Log.i(TAG,"load: userSelection.selectionArea = ${userSelection.selectionArea}")
            Log.i(TAG,"load: userSelection.selectionSorting = ${userSelection.selectionSorting}")

            var req: List<APISimpleStation>?=null

            if((userSelection.selectionArea == "Country" )
                &&(userSelection.selectionSorting == "Nearest"))
            {
                do {
                    if (userSelection.selectionAutoCountry) {
                        Log.i(TAG, "load: country, nearest, selectionAutoCountry = true, range = $range")

                        req = apiService.getSimpleStationsCountryNearest(
                            userid = user.userId,
                            passfrase = user.passfrase,
                            country = countryCode,
                            latitude = deviceLocation.latitude.toString().format(Locale.ROOT, "%s"),
                            longitude = deviceLocation.longitude.toString()
                                .format(Locale.ROOT, "%s"),
                            limit = state.config.pageSize.toString(),
                            offset = ((page - 1) * state.config.pageSize).toString(),
                            lastversion = user.currentVersion,
                            killed = if (userSelection.showHidden) "1" else "0",
                            range = range ?: "1.0" //may be changed
                        )

                    } else {
                        Log.i(TAG, "load: country, nearest, selectionAutoCountry = false, range = $range")
                        val countryData = appDatabase.countryDao().getCountryByCode(countryCode)
                        Log.i(TAG, "load: autoCountry not auto set = ${countryData?.isoCC2}")
                        req = apiService.getSimpleStationsCountryNearest(
                            userid = user.userId,
                            passfrase = user.passfrase,
                            country = countryCode,
                            latitude = (countryData?.latitude_center ?: 0.0F).toString()
                                .format(Locale.ROOT, "%s"),
                            longitude = (countryData?.longitude_center ?: 0.0F).toString()
                                .format(Locale.ROOT, "%s"),
                            limit = state.config.pageSize.toString(),
                            offset = ((page - 1) * state.config.pageSize).toString(),
                            lastversion = user.currentVersion,
                            killed = if (userSelection.showHidden) "1" else "0",
                            range = range ?: "1.0" //must be changed
                        )
                    }
                    Log.i(TAG, "load: req.size = ${req.size}")
                    if(req.isEmpty()) range = increaseRange(range)
                    else break
                }while (range != null)

            }else if((userSelection.selectionArea == "Global")
                &&(userSelection.selectionSorting == "Nearest"))
            {
                do{
                    Log.i(TAG, "load: global, nearest, range = $range")
                    req = apiService.getSimpleStationsGlobalNearest(
                        userid = user.userId,
                        passfrase = user.passfrase,
                        latitude = deviceLocation.latitude.toString().format(Locale.ROOT,"%s"),
                        longitude = deviceLocation.longitude.toString().format(Locale.ROOT,"%s"),
                        limit = state.config.pageSize.toString(),
                        offset = ((page-1)*state.config.pageSize).toString(),
                        lastversion = user.currentVersion,
                        killed = if(userSelection.showHidden) "1" else "0",
                        range = range?:"1.0"
                    )
                    Log.i(TAG, "load: req.size = ${req.size}")
                    if(req.isEmpty()) range = increaseRange(range)
                    else break
                }while (range != null)

            }else if((userSelection.selectionArea == "Country")
                &&(userSelection.selectionSorting == "Latest"))
            {

                Log.i(TAG, "load: country, latest")
                req = apiService.getSimpleStationsCountryLatest(
                    userid = user.userId,
                    passfrase = user.passfrase,
                    country = countryCode,
                    limit = state.config.pageSize.toString(),
                    offset = ((page-1)*state.config.pageSize).toString(),
                    lastversion = user.currentVersion,
                    killed = if(userSelection.showHidden) "1" else "0"
                )

            }else if((userSelection.selectionArea == "Global")
                &&(userSelection.selectionSorting == "Latest"))
            {
                Log.i(TAG, "load: global, latest")
                req = apiService.getSimpleStationsGlobalLatest(
                    userid = user.userId,
                    passfrase = user.passfrase,
                    limit = state.config.pageSize.toString(),
                    offset = ((page-1)*state.config.pageSize).toString(),
                    lastversion = user.currentVersion,
                    killed = if(userSelection.showHidden) "1" else "0"
                )
            }


            //TODO: Add rest

            endOfPaginationReached = req?.isEmpty()
                ?:return MediatorResult.Error(Throwable("No data could be read from backend..."))

            appDatabase.withTransaction {

                if(loadType == LoadType.REFRESH)
                {
                    appDatabase.stationListRemoteKeyDao().clearStationListRemoteKeys()
                    appDatabase.stationDao().nukeTable() //Nuke station table
                }

                val prevKey = if(page == STATION_LIST_STARTING_PAGE_INDEX) null else page -1
                val nextKey = if(endOfPaginationReached) null else page + 1
                val keys = req.map {
                    StationListRemoteKey(
                        stationId = it.idsite,
                        prevKey = prevKey,
                        nextKey = nextKey)
                }
                val stations = req.map{
                    Log.i(
                        TAG,
                        "load: station map ${it.idsite}: ${it.stationname}: ${it.latitude}, ${it.longitude} -> ${deviceLocation.latitude}, ${deviceLocation.longitude}"
                    )

                    Station(
                        stationId = it.idsite,
                        stationName = it.stationname,
                        longitude = it.longitude.toDoubleOrNull(),
                        latitude = it.latitude.toDoubleOrNull(),
                        airDistance = (locationDistance(
                            it.latitude.toDoubleOrNull(),
                            it.longitude.toDoubleOrNull(),
                            deviceLocation.latitude,
                            deviceLocation.longitude
                        )?:0.0)/1000.0,
                        enterpriseId = it.enterpriseid,
                        googlePlaceId = it.googleplaceid,
                        stationAddress = it.stationaddress,
                        stationPlace = it.stationplace,
                        stationZip = it.stationzip,
                        stationCountryCode = it.countrycode,
                        killed = it.killed?.equals("1")?:false,
                        dateCreated =it.datecreated,
                        stationCountry = it.stationcountry
                    )
                }

                appDatabase.stationListRemoteKeyDao().insertAll(keys)
                appDatabase.stationDao().insertAll(stations)

            }


            return MediatorResult.Success(endOfPaginationReached = endOfPaginationReached)

        }catch (exception: IOException)
        {
            return MediatorResult.Error(exception)
        }
        catch (exception: HttpException)
        {
            return MediatorResult.Error(exception)
        }


    }


    fun increaseRange(inRange: String?): String? {
        var fRange:Float = inRange?.toFloatOrNull()?:1.0F

        fRange += 1.0F
        Log.i(TAG, "increaseRange: fRange = $fRange")

        val rRange = if(fRange>180.0F) null
        else fRange.toString().format(Locale.ROOT,"%0.1f")

        CoroutineScope(Dispatchers.IO).launch {
            appDatabase.userSelectionDao().updateCurrentRange(rRange)
        }

        return rRange
    }

    fun locationDistance(
        fromLatitude: Double?,
        fromLongitude: Double?,
        toLatitude: Double?,
        toLongitude : Double?
    ):Double?{
        fromLatitude?:return null
        fromLongitude?:return null
        toLatitude?:return null
        toLongitude?:return null
        val fromLocation = Location("FromLocation")
        val toLocation = Location("ToLocation")
        fromLocation.latitude = fromLatitude
        fromLocation.longitude = fromLongitude
        toLocation.latitude = toLatitude
        toLocation.longitude = toLongitude
        return fromLocation.distanceTo(toLocation).toDouble()
    }


}

If I have time, I will give you a working proof-of-concept of the issue.

Comments

du...@google.com <du...@google.com> #2Jul 3, 2020 07:54PM

Same issue.

Try this:
Roll back to AS-C3.
Set gradle back to '...:3.6.0-alpha03'. (The issue is caused by this, I think.)
Clean project.

I'm sure an update will fix it.

ro...@gmail.com <ro...@gmail.com> #3Jul 5, 2020 06:23AM

Same issue.

du...@google.com <du...@google.com> #4Jul 27, 2020 10:30PM

Successfully downgraded projects to use AS3.6C3

RG

ro...@gmail.com <ro...@gmail.com> #5Jul 29, 2020 08:37AM

Same issue here, downgrading to AS3.6C3 works OK

ro...@gmail.com <ro...@gmail.com> #6Jul 29, 2020 08:39AM

New project does not produce this kind of error, will try to drill down to what dependency will break it.

sm...@gmail.com <sm...@gmail.com> #7Sep 3, 2020 02:37PM

Have drilled down and found that the error occures on

dependencies {
...
implementation 'androidx.constraintlayout:constraintlayout:2.0.0-beta2'
...
}

tested with following alphas and betas

"alpha3": OK
"alpha4": Fail
"alpha5": Fail

"beta1": Fail
"beta2": Fail

This was a simple test, have not tested thoroughly with a more complex test yet.

-> Solution : Downgrade 'androidx.constraintlayout:constraintlayout:2.0.0-xxx' to 'androidx.constraintlayout:constraintlayout:2.0.0-alpha3'

RG

du...@google.com <du...@google.com> #8Nov 13, 2020 12:12AM

Status: Duplicate of

162252536

Great catch! rolling back to 'androidx.constraintlayout:constraintlayout:2.0.0-alpha3' enables to keep using 3.6.0-alpha04 android gradle plugin