Hilt Worker Factory incorrectly map inner classes in object. [160524718]

Fixed

Bug

Status Update

No update yet.

Description

jd...@xooloo.com

created issue #1

Jul 6, 2020 10:39AM

Component used: Fragment Version used: Devices/Android versions reproduced on:

When using Hilt Jetpack integration, the Hilt Work factory failed to create Worker with the following exception:

2020-07-06 12:35:22.027 18436-18679/example E/WM-WorkerFactory: Could not instantiate com.example.webservices.Device$Worker
    java.lang.NoSuchMethodException: <init> [class android.content.Context, class androidx.work.WorkerParameters]
        at java.lang.Class.getConstructor0(Class.java:2204)
        at java.lang.Class.getDeclaredConstructor(Class.java:2050)
        at androidx.work.WorkerFactory.createWorkerWithDefaultFallback(WorkerFactory.java:95)
        at androidx.work.impl.WorkerWrapper.runWorker(WorkerWrapper.java:242)
        at androidx.work.impl.WorkerWrapper.run(WorkerWrapper.java:136)
        at androidx.work.impl.utils.SerialExecutor$Task.run(SerialExecutor.java:91)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
        at java.lang.Thread.run(Thread.java:761)

It appears this is due to a but in the class name mapping.

I declared my worker inside a Kotlin object like this:


object Device {
    class Worker @WorkerInject constructor(
            @Assisted appContext: Context,
            @Assisted params: WorkerParameters,
            val buildInfo: BuildInfo) : CoroutineWorker(appContext, params) {
        …
    }
}

Which create a com.example.webservices.Device.Worker entry in the Worker Factory mapping. But this entry do not match the real runtime class name which is com.example.webservices.Device$Worker

workerClassName = "com.example.webservices.Device$Worker"
workerParameters = {WorkerParameters@8051} 
factoryProvider = null
mWorkerFactories = {Collections$UnmodifiableMap@8059}  size = 1
 "com.example.webservices.Device.Worker" -> {DaggerApp_HiltComponents_ApplicationC$SwitchingProvider@8379}

Comments

da...@google.com <da...@google.com> #2Jul 8, 2020 05:42PM

It looks like we have more directories

›../../out/androidx/appsearch/appsearch-local-storage/build/../nativeBuildStaging/cmake/debug/arm64-v8a/build.ninja📋
›../../out/androidx/appsearch/appsearch-local-storage/build/../nativeBuildStaging/cmake/debug/arm64-v8a/build.ninja.txt📋
›../../out/androidx/appsearch/appsearch-local-storage/build/../nativeBuildStaging/cmake/debug/armeabi-v7a/build.ninja📋
›../../out/androidx/appsearch/appsearch-local-storage/build/../nativeBuildStaging/cmake/debug/armeabi-v7a/build.ninja.txt📋
›../../out/androidx/appsearch/appsearch-local-storage/build/../nativeBuildStaging/cmake/debug/x86/build.ninja📋
›../../out/androidx/appsearch/appsearch-local-storage/build/../nativeBuildStaging/cmake/debug/x86/build.ninja.txt📋
›../../out/androidx/appsearch/appsearch-local-storage/build/../nativeBuildStaging/cmake/debug/x86_64/build.ninja📋
›../../out/androidx/appsearch/appsearch-local-storage/build/../nativeBuildStaging/cmake/debug/x86_64/build.ninja.txt📋
›../../out/androidx/appsearch/appsearch-local-storage/build/../nativeBuildStaging/cmake/release/arm64-v8a/build.ninja📋
›../../out/androidx/appsearch/appsearch-local-storage/build/../nativeBuildStaging/cmake/release/arm64-v8a/build.ninja.txt📋
›../../out/androidx/appsearch/appsearch-local-storage/build/../nativeBuildStaging/cmake/release/armeabi-v7a/build.ninja📋
›../../out/androidx/appsearch/appsearch-local-storage/build/../nativeBuildStaging/cmake/release/armeabi-v7a/build.ninja.txt📋
›../../out/androidx/appsearch/appsearch-local-storage/build/../nativeBuildStaging/cmake/release/x86/build.ninja📋
›../../out/androidx/appsearch/appsearch-local-storage/build/../nativeBuildStaging/cmake/release/x86/build.ninja.txt📋
›../../out/androidx/appsearch/appsearch-local-storage/build/../nativeBuildStaging/cmake/release/x86_64/build.ninja📋
›../../out/androidx/appsearch/appsearch-local-storage/build/../nativeBuildStaging/cmake/release/x86_64/build.ninja.txt📋

it also considers all of these input to configuration cache

ap...@google.com <ap...@google.com> #3Jul 9, 2020 08:09PM

Prefab feature also seems to cause the following to be added as configuration ache inputs

›../../out/androidx/external/libyuv/build/intermediates/prefab_package_header_only/prefab_publication.json/debug📋
›../../out/androidx/external/libyuv/build/intermediates/prefab_package_header_only/prefab_publication.json/release📋
›../../out/androidx/test/ext/junit-gtest/build/intermediates/prefab_package_header_only/prefab_publication.json/debug📋
›../../out/androidx/test/ext/junit-gtest/build/intermediates/prefab_package_header_only/prefab_publication.json/release📋

da...@google.com <da...@google.com> #4Jul 9, 2020 10:58PM

Marked as fixed.

./gradlew zipTestConfigsWithApks

Issue 160524718

Description

Issue summary

Comments

da...@google.com <da...@google.com> #2Jul 8, 2020 05:42PM

ap...@google.com <ap...@google.com> #3Jul 9, 2020 08:09PM

da...@google.com <da...@google.com> #4Jul 9, 2020 10:58PM

Add comment

Issue metadata