Provide a composable way to handle pre create use cases [161390636]

Fixed

Feature Request

Status Update

No update yet.

Description

il...@google.com

created issue #1

Jul 15, 2020 10:02PM

Component used: Activity Version used: 1.2.0-alpha06

The APIs of LifecycleOwner provide us with a callback for when you reach the CREATED state, but for activities that is often after some critical code needs to run.

For example:

Calling setTheme to reset your theme from a branded launch theme
Calling setLocalNightMode()

These all need to be called before super.onCreate() and specifically the inflation of any layout.

It would be nice if there was a composable way to get a callback at that exact time without needing to manually add code to onCreate() (which, will fine for app code, is hard to do as a library).

Comments

il...@google.com <il...@google.com> Jul 15, 2020 10:02PM

Accepted by il...@google.com.

ap...@google.com <ap...@google.com> #2Jul 22, 2020 11:56PM

Wow, it seems like a very important bug to fix.

Doing some investigations...

It works fine with CoreTextField as well as BaseTextField.

ap...@google.com <ap...@google.com> #3Aug 4, 2020 04:19PM

Seems to be a duplicate of b/163834907

ap...@google.com <ap...@google.com> #4Aug 4, 2020 04:19PM

It works fine with Material TextFields (both filled and outline) if you use TextFieldValue based overloads.

It doesn't work when you use String based overloads however (both Outline and Filled). I believe this is related to the one-frame lag as we host TextFieldValue internally and proxy only string.

ap...@google.com <ap...@google.com> #5Aug 12, 2020 06:46PM

Chatted with Anastasia.

We have this code

// "value: String" comes as a param in TextField
TextFieldImpl(
        type = TextFieldType.Outlined,
        value = textFieldValue,
        onValueChange = {
            selection = it.selection
            composition = it.composition
            if (value != it.text) {
                onValueChange(it.text)
            }
        },

and this value is always "" for me, as it's captured my lambda when lambda was created and this lambda is saved and reused by CoreTextField.

Anyway, two things we can do:

Remove this if and invoke onValueChange everytime, even on the selection change (which we don't care about). This will allow us to workaround quickly and not to let it slip through.
Find and implement the proper fix in CoreTextField

Let me know what you think

il...@google.com <il...@google.com> #6Aug 12, 2020 08:18PM

Marked as fixed.

Updated the details here b/163834907.

e....@gmail.com <e....@gmail.com> #7Aug 19, 2020 06:17PM

Just a note that this issue affects String overrides of both material text fields as well as any custom String override text fields that developer might create on top of CoreTextField/BaseTextField.

e....@gmail.com <e....@gmail.com> #8Aug 19, 2020 06:34PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 1717097cfa889c564450626af6d5dcc405581d79
Author: Anastasia Soboleva <soboleva@google.com>
Date: Mon Aug 24 16:38:59 2020

Fix lambda value being captured for string override text fields

Fixes: 163834907
Fixes: 163808219
Fixes: 165956313
Test: new test in TextFieldTest#stringOverrideTextField_canDeleteLastSymbol
Test: foundation and material tests passed
Change-Id: I9932a2bddc3859a2a35a54e0b6d7cb525853d3ac

M compose/foundation/foundation-text/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/TextFieldTest.kt

https://android-review.googlesource.com/1408268

il...@google.com <il...@google.com> #9Aug 19, 2020 06:43PM

Which release is this fix going to be a part of? Also, what's the best way to know which version a change will be a part of in general?

sl...@gmail.com <sl...@gmail.com> #10Jan 21, 2021 10:29AM

This fix will be available in the upcoming release.

As for the second question, I'm not sure I've got a good answer for that one. I'd say normally if it's marked as fixed, it'll be available within two next releases.