NavOptions should override equals and hashCode [161586466]

Fixed

Bug

Status Update

No update yet.

Description

ga...@gmail.com

created issue #1

Jul 19, 2020 12:51PM

Component used: Navigation Version used: 2.3.0

In some of our jvm tests we want to check that the right navigation is triggered. Since we are not on an actual device we are checking if the correct NavDirections object and NavOptions object are passed to the navigator. However NavOptions currently does not override equals and hashCode which makes this more complicated than needed. Since all NavOptions fields are either int or boolean this should be straightforward to do.

Comments

il...@google.com <il...@google.com> Jul 20, 2020 09:36PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2Jul 31, 2020 05:51PM

Thanks for trying out Room KMP! This looks like an issue with Android 9+ and armv7 and the way we compile sqlite3.c, specifically linking to the atomic library in C. We'll try to get this fix as soon as possible.

jb...@google.com <jb...@google.com> #3Jul 31, 2020 06:38PM

Marked as fixed.

Very related: https://sqlite.org/forum/info/aa703e86823efca3, as suspected seems like a linking issue.

ga...@gmail.com <ga...@gmail.com> #4Jul 31, 2020 07:48PM

Facing the same issue here, surprisingly using the AndroidSQLiteDriver instead of the bundled one seems to work fine. So for now, others facing the crash can fix it by using the AndroidSQLiteDriver instead of the bundled one

ap...@google.com <ap...@google.com> #5Sep 24, 2020 08:45AM

Project: platform/frameworks/support
Branch: androidx-main

commit cf121571aac008a756b64cda13f76ae4db3e85a6
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Wed May 29 11:14:42 2024

Link to Android's atomic lib in bundled SQLite

Fix Bundled SQLite loading for devices with older ARM architecture by linking to Android's atomic library instead of relying on Clang's extension (c_atomic) or GCC's built-ins as used in sqlite3.c.

Also add support for passing linker args to androidx's native compilation infra.

See also discussion in

https://sqlite.org/forum/forumpost/792d76a592608d8f

Bug: 341639198
Test: Locally tested via BundledSQLiteDriverTest in a Nexus 5 on API 23
Change-Id: Ia818b7c4f1a990a1b5e35f4c7a3c89694aee0503

M buildSrc/private/src/main/kotlin/androidx/build/clang/ClangSharedLibraryTask.kt
M buildSrc/private/src/main/kotlin/androidx/build/clang/KonanBuildService.kt
M buildSrc/private/src/main/kotlin/androidx/build/clang/MultiTargetNativeCompilation.kt
M buildSrc/private/src/main/kotlin/androidx/build/clang/NativeTargetCompilation.kt
M sqlite/sqlite-bundled/build.gradle

https://android-review.googlesource.com/3108157

ap...@google.com <ap...@google.com> #6Sep 24, 2020 08:52AM

Hello, even if I updated to version androidx.sqlite:sqlite-bundled:2.5.0-alpha04 I just received a crash on a nexus 5X with android 8.1.0 and another one on Redmi Note 11 Pro with android 13.
I'm using androidx.room:room-runtime-android:2.7.0-alpha01.

This is the log:
Fatal Exception: java.lang.UnsatisfiedLinkError: dalvik.system.PathClassLoader[DexPathList[[zip file "/data/app/com.myproject-ssibkzVuLAo7tvV0puYoEg==/base.apk"],nativeLibraryDirectories=[/data/app/com.myproject-ssibkzVuLAo7tvV0puYoEg==/lib/x86, /system/lib, /vendor/lib]]] couldn't find "libsqliteJni.so"
at java.lang.Runtime.loadLibrary0(Runtime.java:1011)
at java.lang.System.loadLibrary(System.java:1657)
at androidx.sqlite.driver.bundled.NativeLibraryLoader.loadLibrary(NativeLibraryLoader.android.kt:1)
at androidx.sqlite.driver.bundled.BundledSQLiteDriver.<clinit>(BundledSQLiteDriver.jvmAndroid.kt:1)

Thank you!

ap...@google.com <ap...@google.com> #7Sep 24, 2020 08:57AM

Can you try using androidx.room:room-runtime-android:2.7.0-alpha04 and confirm if the issue is still present?

ap...@google.com <ap...@google.com> #8Sep 24, 2020 09:18AM

I will let you know, in alternative can I use AndroidSQLiteDriver instead of the bundled one just for the android implementation?

ap...@google.com <ap...@google.com> #9Sep 24, 2020 09:34AM

Ideally you could use AndroidSQLiteDriver but Room has a bug with the AndroidSQLiteDriver that is fixed in version 2.7.0-alpha05 that will be released in July 10 so I recommend that if you do switch to using AndroidSQLiteDriver wait for the alpha05 release.

ap...@google.com <ap...@google.com> #10Sep 24, 2020 09:36AM

I believe this error still exists.

I just received two errors from Crashlytics using androidx.sqlite:sqlite-bundled version 2.5.0-alpha06 and BundledSQLiteDriver for both Android and iOS.

Fatal Exception: java.lang.UnsatisfiedLinkError
dalvik.system.PathClassLoader[DexPathList[[zip file "/data/app/app/com.example.app-ACdqnxIlCwzIlzMdaeegRw==/base.apk"],nativeLibraryDirectories=[/data/app/com.example.app-ACdqnxIlCwzIlzMdaeegRw==/lib/x86, /system/lib, /vendor/lib]]] couldn't find "libsqliteJni.so"

And the exception is in .setDriver(BundledSQLiteDriver())

Both crashes were from a Nexus 5X running Android 8.1.0

I would say it is the same exception as in

comment #6

ap...@google.com <ap...@google.com> #11Sep 24, 2020 10:08AM

Same crash on Nexus 5X running Android 8.1.0 on androidx.sqlite:sqlite-bundled version 2.5.0-alpha10 with room version 2.7.0-alpha10.

ap...@google.com <ap...@google.com> #12Sep 24, 2020 10:10AM

Same crash on Pixel 6 Pro(android12),Nexus 5X(android8.1) on androidx.sqlite:sqlite-bundled version 2.5.0-alpha11 with room version 2.7.0-alpha11.

ap...@google.com <ap...@google.com> #13Sep 24, 2020 11:29AM

Same crash on Android 12, Pixel 6 Pro.
androidx.sqlite:sqlite-bundled version 2.5.0-alpha11 with room version 2.7.0-alpha11

ap...@google.com <ap...@google.com> #14Sep 24, 2020 11:32AM

For those experiencing this issue, can you provide any more detail: stacktrace, bug report, trends (specific API versions, specific manufacturer)?

Usually with UnsatisfiedLinkError there is more in the logs / error mentioning why the native library couldn't be used, specifically the missing symbol. I have so far validated we are linking against the right atomic library in the NDK, so I suspect it must be another symbol.

ap...@google.com <ap...@google.com> #15Sep 24, 2020 11:52AM

Same crash on Pixel 6 pro

androidx-room = "2.7.0-alpha11"

androidx-sqlite = "2.5.0-alpha11"

Attached a stack trace