Status Update
Comments
ti...@google.com <ti...@google.com> #2
Branch: main
commit 6dc78fbbbbadac9c2dc2065150a7af2422c6115c
Author: Rupert Ben Wiser <bewise@chromium.org>
Date: Thu Sep 12 16:16:14 2024
webview: Add support configuration for CHIPS
Adding a boundary interface to let Android developers configure
if partitioned cookies should be enabled or not.
go/chips-android-apis-webview
Bug: 364904765
Change-Id: I683ab5ec157a11aa081db5763380e692ab02c5e6
Reviewed-on:
Reviewed-by: Peter Pakkenberg <pbirk@chromium.org>
Auto-Submit: Rupert Wiser <bewise@chromium.org>
Commit-Queue: Peter Pakkenberg <pbirk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1354607}
M android_webview/expectations/system_webview_32_64_bundle.AndroidManifest.expected
M android_webview/expectations/system_webview_32_bundle.AndroidManifest.expected
M android_webview/expectations/system_webview_64_bundle.AndroidManifest.expected
M android_webview/expectations/system_webview_bundle.AndroidManifest.expected
M android_webview/expectations/trichrome_webview_32_64_bundle.AndroidManifest.expected
M android_webview/expectations/trichrome_webview_32_bundle.AndroidManifest.expected
M android_webview/expectations/trichrome_webview_64_32_bundle.AndroidManifest.expected
M android_webview/expectations/trichrome_webview_64_bundle.AndroidManifest.expected
M android_webview/expectations/trichrome_webview_bundle.AndroidManifest.expected
M android_webview/glue/java/src/com/android/webview/chromium/AndroidXProcessGlobalConfig.java
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
M android_webview/nonembedded/java/AndroidManifest.xml
M android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/ProcessGlobalConfigConstants.java
M chrome/android/expectations/monochrome_32_64_public_bundle__base.AndroidManifest.expected
M chrome/android/expectations/monochrome_32_public_bundle__base.AndroidManifest.expected
M chrome/android/expectations/monochrome_64_32_public_bundle__base.AndroidManifest.expected
M chrome/android/expectations/monochrome_64_public_bundle__base.AndroidManifest.expected
M chrome/android/expectations/monochrome_public_bundle__base.AndroidManifest.expected
al...@gmail.com <al...@gmail.com> #3
There is already test coverage of CHIPS behavior inside of Chromium in
Due to limitations of AndroidX test infra, manual test instructions are necessary to exercise the toggling of the enable partitioned cookies API. WebView toggles CHIPS behavior with the disable-partitioned-cookies
command line switch.
To demonstrate the API's correctness in toggling this, log statements were inspected when this flag was toggled during WebView startup.
See the diff below for details:
diff --git a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
index 63c5f5a5b2795..ee589176bdab2 100644
--- a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
+++ b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
@@ -490,6 +490,9 @@ public class WebViewChromiumFactoryProvider implements WebViewFactoryProvider {
if (!androidXConfig.getPartitionedCookiesEnabled()) {
cl.appendSwitch("disable-partitioned-cookies");
+ Log.e(TAG, "Partitioned cookies disabled");
+ } else {
+ Log.e(TAG, "Partitioned cookies enabled");
}
// Now safe to use WebView data directory.
ta...@mercury.com <ta...@mercury.com> #4
Note: Will add testing when more of the API has been implemented.
kl...@google.com <kl...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-main
Author: Adam Walls <
Link:
[WebView] Add API to configure CHIPS
Expand for full commit details
[WebView] Add API to configure CHIPS
This adds an API to allow Android developers to configure CHIPS globally. This is done with ProcessGlobalConfig. In order to prevent this from being published/used prior to Android B's release, RestrictTo annotation is used.
Design: go/chips-android-apis-webview
Test: Will add testing in a follow-up CL.
Bug: 364904765
Change-Id: If6d630562be7209eb2ab00da2dbad9398ba0553e
Files:
- M
webkit/webkit/src/main/java/androidx/webkit/ProcessGlobalConfig.java
- M
webkit/webkit/src/main/java/androidx/webkit/WebViewFeature.java
- M
webkit/webkit/src/main/java/androidx/webkit/internal/StartupFeatures.java
- M
webkit/webkit/src/main/java/androidx/webkit/internal/WebViewFeatureInternal.java
Hash: 4fe72afdcf64cad8b2399ca7a28d1aa57a05f976
Date: Thu Oct 24 17:35:26 2024
ti...@google.com <ti...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-main
Author: Adam Walls <
Link:
Refactor common Webkit test classes into test.common module.
Expand for full commit details
Refactor common Webkit test classes into test.common module.
This is intended to enable new androidx.webkit test targets so that we
do not need to use the Orchestrator annotation to create new test
processes. This is intended as a refactor to reduce the CL size in
aosp/3371538.
The new androidx.webkit.test.common module was created using
the development/project-creator/create_project.py script.
Test: ./webkit/run_instrumentation_tests.sh
Bug: 364904765
Change-Id: If68173a88bd5267d3aa19986ba3f4486d9e17b64
Files:
- M
settings.gradle
- A
webkit/integration-tests/common/build.gradle
- M
webkit/integration-tests/common/src/main/java/androidx/webkit/test/common/PollingCheck.java
- A
webkit/integration-tests/common/src/main/java/androidx/webkit/test/common/TestWebMessageListener.java
- M
webkit/integration-tests/common/src/main/java/androidx/webkit/test/common/WebViewOnUiThread.java
- M
webkit/integration-tests/common/src/main/java/androidx/webkit/test/common/WebkitUtils.java
- M
webkit/integration-tests/instrumentation/build.gradle
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/AsyncStartUpTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/CookieManagerCompatTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/MultiProfileTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/PostMessageTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/ProxyControllerTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/ServiceWorkerClientCompatTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/ServiceWorkerWebSettingsCompatTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/TracingControllerTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebSettingsCompatDarkModeTestBase.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebSettingsCompatTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebSettingsCompatUserAgentMetadataTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebStorageTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebViewClientCompatTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebViewCompatTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebViewDocumentStartJavaScriptTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebViewRenderProcessClientTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebViewRenderProcessTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebViewWebMessageCompatTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebViewWebMessageListenerTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/internal/AssetHelperTest.java
- M
webkit/integration-tests/instrumentation/src/androidTestTargetSdk32/java/androidx/webkit/WebSettingsCompatForceDarkTest.java
- M
webkit/integration-tests/instrumentation/src/androidTestTargetSdkLatest/java/androidx/webkit/WebSettingsCompatDarkThemeTest.java
- M
webkit/integration-tests/instrumentation/src/androidTestTargetSdkLatest/java/androidx/webkit/WebSettingsCompatLightThemeTest.java
Hash: 463387393fce755928325a57d49cec218631a6a3
Date: Fri Dec 13 23:24:49 2024
ap...@google.com <ap...@google.com> #7
Project: platform/frameworks/support
Branch: androidx-main
Author: Adam Walls <
Link:
[WebView] Add CHIPS testing via integration tests.
Expand for full commit details
[WebView] Add CHIPS testing via integration tests.
In order to test the enable partitioned cookies API added in
aosp/3318854, integration tests are added.
Note: Since test process restarts are not supported, and the startup
APIs can only be called once per process lifetime, this will avoid
errors by only testing with a single test case that covers a few
use cases.
Test: ./webkit/run_instrumentation_tests.sh
Bug: 364904765
Change-Id: I89354cb04bb92b954a5a51fac06133ebd6a3ae3a
Files:
- M
settings.gradle
- A
webkit/chips-enabled-integration-tests/instrumentation/build.gradle
- A
webkit/chips-enabled-integration-tests/instrumentation/src/androidTest/AndroidManifest.xml
- A
webkit/chips-enabled-integration-tests/instrumentation/src/androidTest/java/androidx/webkit/EnablePartitionedCookiesTest.java
- M
webkit/integration-tests/common/src/main/java/androidx/webkit/test/common/WebViewOnUiThread.java
- M
webkit/run_instrumentation_tests.sh
Hash: 200afa93c09543d6c7320a025fed7f2944689055
Date: Thu Dec 12 03:20:20 2024
ae...@google.com <ae...@google.com> #8
Project: platform/frameworks/support
Branch: androidx-main
Author: Adam Walls <
Link:
[WebView] Expose Enable CHIPS API
Expand for full commit details
[WebView] Expose Enable CHIPS API
aosp/3318854 introduced the enable CHIPS API hidden until it was
deemed ready for release. This exposes the API for use in apps.
Relnote: "Add setPartitionedCookiesEnabled API. This will allow
developers to enable and disable partitioned cookies in WebView. The
feature is available in WebView starting in M130."
Bug: 364904765
Test: ./webkit/run_instrumentation_tests.sh
Change-Id: Ic506a23471946d31b797397e2f71aef0f3ae481a
Files:
- M
webkit/webkit/api/current.txt
- M
webkit/webkit/api/restricted_current.txt
- M
webkit/webkit/src/main/java/androidx/webkit/ProcessGlobalConfig.java
- M
webkit/webkit/src/main/java/androidx/webkit/WebViewFeature.java
- M
webkit/webkit/src/main/java/androidx/webkit/internal/StartupFeatures.java
Hash: 512bc1b685e6c5bbb563c33948b1c3b6b0ec9197
Date: Fri Dec 20 18:03:50 2024
ap...@google.com <ap...@google.com> #9
Project: platform/frameworks/support
Branch: androidx-main
Author: Adam Walls <
Link:
Reformat affected classes from aosp/3406800.
Expand for full commit details
Reformat affected classes from aosp/3406800.
aosp/3406800 refactored some common classes that were not formatted
properly.
Bug: 364904765
Test: ./webkit/run_instrumentation_tests.sh
Change-Id: I328af103b753e575c25a383dd709e355a973b98f
Files:
- M
webkit/integration-tests/common/src/main/java/androidx/webkit/test/common/PollingCheck.java
- M
webkit/integration-tests/common/src/main/java/androidx/webkit/test/common/TestWebMessageListener.java
- M
webkit/integration-tests/common/src/main/java/androidx/webkit/test/common/WebViewOnUiThread.java
- M
webkit/integration-tests/common/src/main/java/androidx/webkit/test/common/WebkitUtils.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/AsyncStartUpTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/MultiProfileTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/PostMessageTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/ProxyControllerTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/ServiceWorkerClientCompatTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/ServiceWorkerWebSettingsCompatTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/TracingControllerTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebSettingsCompatDarkModeTestBase.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebSettingsCompatTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebSettingsCompatUserAgentMetadataTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebStorageTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebViewClientCompatTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebViewCompatTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebViewDocumentStartJavaScriptTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebViewRenderProcessClientTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebViewRenderProcessTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebViewWebMessageCompatTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/WebViewWebMessageListenerTest.java
- M
webkit/integration-tests/instrumentation/src/androidTest/java/androidx/webkit/internal/AssetHelperTest.java
Hash: 818530aa0c71b1b6e1cba00a39494794b45ed6c8
Date: Wed Dec 18 00:18:27 2024
Description
- Window animation scale
- Transition animation scale
- Animator duration scale
in Developer options has no effect on transitions right now.
Not sure if there's a public API for them but they're important for debugging.