ActivityResultFragmentVersionDetector uses an API that breaks in Lint 27.1.0+ (AGP 4.1.0+) [162155191]

Fixed

Bug

Status Update

No update yet.

Description

za...@gmail.com

created issue #1

Jul 26, 2020 07:08AM

Component used: Fragment
Version used: 1.3.0-alpha07
Devices/Android versions reproduced on: N/A

This code snippet will no longer work with lint tools 27.1.0+ (which is what's used in AGP 4.1.0+).

https://github.com/androidx/androidx/blob/c5ff35e40fbf353262ac22013e8c16e45b9017a3/activity/activity-lint/src/main/java/androidx/activity/lint/ActivityResultFragmentVersionDetector.kt#L97

It looks like it should be changed to buildVariant, and then there are changed APIs for accessing library info (the .libraries call at the end will also need fixing).

This results in the following failure when I build with newer lint tools and AGP 4.1.0-beta05 in our project

NoSuchMethodError:ActivityResultFragmentVersionDetector.checkDslPropertyAssignment(ActivityResultFragmentVersionDetector.kt:97)←Detector.checkDslPropertyAssignment(Detector.kt:418)←UastGradleVisitor.handleMethodCall(UastGradleVisitor.kt:190)←UastGradleVisitor.access$handleMethodCall(UastGradleVisitor.kt:34)←UastGradleVisitor$visitBuildScript$1.visitCallExpression(UastGradleVisitor.kt:40)←KotlinUFunctionCallExpression.accept(KotlinUFunctionCallExpression.kt:205)←ImplementationUtilsKt.acceptList(implementationUtils.kt:23)←UBlockExpression$DefaultImpls.accept(UBlockExpression.kt:21)

Sun Jul 26 2020 03:07:28 GMT-0400 (Eastern Daylight Time).png

23 KB

View

Download

Comments

il...@google.com <il...@google.com> #2Jul 26, 2020 11:28PM

ViewModels need to be cleared on Fragments that are being really destroyed, where "really destroyed" means that they are being destroyed without their state being saved, indicating that there's no chance they are going to be restored at a later time.

Unfortunately, isStateSaved(), despite its name, does double duty as a check on whether it is safe to do Fragment Transactions and is always true after onStop(), meaning it can be true even if the state has really not been saved, oddly enough.

We'll just not use isStateSaved() here and rely on a separate indicator for the "really destroyed" case.

my...@gmail.com <my...@gmail.com> #3Jul 27, 2020 09:28PM

comment #2

Fixed in which version?

jb...@google.com <jb...@google.com> Jul 30, 2020 10:34PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #4Jul 31, 2020 05:51PM

comment #3

Fixed in 28.0.0-alpha1

https://developer.android.com/topic/libraries/support-library/revisions.html#28-0-0-alpha1

ap...@google.com <ap...@google.com> #5Jul 31, 2020 11:57PM

We have to update compile SDK to 28 to adapt this fix?!

ap...@google.com <ap...@google.com> #6Jul 31, 2020 11:58PM

It was mentioned that it will released in 27.1.1

https://www.reddit.com/r/androiddev/comments/824m81/support_lib_2710_bug_viewmodeloncleared_is_not/dv8d4ua/

jb...@google.com <jb...@google.com> #7Aug 12, 2020 02:30AM

Marked as fixed.

When will 27.1.1 be released? It is a critical bug seriously.

ap...@google.com <ap...@google.com> #8Dec 21, 2023 05:34PM

This also seems to have caused a side effect / bug where a ViewModel instance is recreated when its Activity is in the background when device is rotated.