ActivityResultFragmentVersionDetector uses an API that breaks in Lint 27.1.0+ (AGP 4.1.0+) [162155191]

Fixed

Bug

Status Update

No update yet.

Description

za...@gmail.com

created issue #1

Jul 26, 2020 07:08AM

Component used: Fragment
Version used: 1.3.0-alpha07
Devices/Android versions reproduced on: N/A

This code snippet will no longer work with lint tools 27.1.0+ (which is what's used in AGP 4.1.0+).

https://github.com/androidx/androidx/blob/c5ff35e40fbf353262ac22013e8c16e45b9017a3/activity/activity-lint/src/main/java/androidx/activity/lint/ActivityResultFragmentVersionDetector.kt#L97

It looks like it should be changed to buildVariant, and then there are changed APIs for accessing library info (the .libraries call at the end will also need fixing).

This results in the following failure when I build with newer lint tools and AGP 4.1.0-beta05 in our project

NoSuchMethodError:ActivityResultFragmentVersionDetector.checkDslPropertyAssignment(ActivityResultFragmentVersionDetector.kt:97)←Detector.checkDslPropertyAssignment(Detector.kt:418)←UastGradleVisitor.handleMethodCall(UastGradleVisitor.kt:190)←UastGradleVisitor.access$handleMethodCall(UastGradleVisitor.kt:34)←UastGradleVisitor$visitBuildScript$1.visitCallExpression(UastGradleVisitor.kt:40)←KotlinUFunctionCallExpression.accept(KotlinUFunctionCallExpression.kt:205)←ImplementationUtilsKt.acceptList(implementationUtils.kt:23)←UBlockExpression$DefaultImpls.accept(UBlockExpression.kt:21)

Sun Jul 26 2020 03:07:28 GMT-0400 (Eastern Daylight Time).png

23 KB

View

Download

Comments

il...@google.com <il...@google.com> #2Jul 26, 2020 11:28PM

I don't think #1 makes a lot of sense. There are already potentially libraries out there without that metadata.

#2 makes the most sense to me, but in case we cannot be 100% reliable we should allow blacklisting libraries as described in #3. This should probably be handled globally for a project (in gradle.properpies rather than in the DSL)

my...@gmail.com <my...@gmail.com> #3Jul 27, 2020 09:28PM

As I have mentioned I don't think there is a silver bullet. #2 does not work on 100% and #1 will take time before devs will provide the metadata. #3 is in my opinion very important to introduce asap, as the developers have no way how to workaround it at this stage. Also in the future there can be any other issue and there is nothing wrong in doing #3 until we figure out something robust (or for instance finally migrate work manager and navigation to androidx that would make #2 a feasible solution).

jb...@google.com <jb...@google.com> Jul 30, 2020 10:34PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #4Jul 31, 2020 05:51PM

Yes, I'm working on #3 right now to unblock users. We can continue thinking about #2.

ap...@google.com <ap...@google.com> #5Jul 31, 2020 11:57PM

Starting with AGP 3.3.0-rc01 and 3.4.0-alpha04, to blacklist libraries that should not be jetified, users can add a comma-separated list of regular expressions to the following property in the gradle.properties file:
android.jetifier.blacklist = ...

If a library's absolute path contains a substring that matches one of the regular expressions, the library won't be jetified.

For example, if the property is
android.jetifier.blacklist = doNot.*\\.jar, foo
then "/path/to/doNotJetify.jar" won't be jetified.

Change-Id: I6531fe0faafa45dc2811c5223ba199ccce5fee53

Note that this is only a temporary workaround while we work on a proper solution.

ap...@google.com <ap...@google.com> #6Jul 31, 2020 11:58PM

Hi. I'm trying to use the `android.jetifier.blacklist` workaround to prevent jetify from processing lombok (which generates a DuplicateEntry exception when trying to transform). I can't see to get it working though. Here are the relevant files:

gradle.properties:
```
android.enableJetifier=true
android.jetifier.blacklist = .*lombok.*
android.useAndroidX=true
```

build.gradle:
```
buildscript {
repositories {
google()
jcenter()
}
dependencies {
classpath 'com.android.tools.build.jetifier:jetifier-processor:1.0.0-beta02'
classpath 'com.android.tools.build:gradle:3.3.0-beta03'
}
}

plugins {
id 'com.android.application' //version '3.3.0-beta03'
id 'jacoco'
}
```

jb...@google.com <jb...@google.com> #7Aug 12, 2020 02:30AM

Marked as fixed.

As mentioned at

comment #5

, you will need to use AGP 3.3.0-rc01+ or 3.4.0-alpha04+ for the workaround to take effect.

ap...@google.com <ap...@google.com> #8Dec 21, 2023 05:34PM

I am interested in the ability to blacklist dependencies from being jettified as well. The binary rewrite messes with AspectJ aspect classes. It re-introduces this problem:

https://issuetracker.google.com/issues/119153999