ActivityResultFragmentVersionDetector uses an API that breaks in Lint 27.1.0+ (AGP 4.1.0+) [162155191]

Fixed

Bug

Status Update

No update yet.

Description

za...@gmail.com

created issue #1

Jul 26, 2020 07:08AM

Component used: Fragment
Version used: 1.3.0-alpha07
Devices/Android versions reproduced on: N/A

This code snippet will no longer work with lint tools 27.1.0+ (which is what's used in AGP 4.1.0+).

https://github.com/androidx/androidx/blob/c5ff35e40fbf353262ac22013e8c16e45b9017a3/activity/activity-lint/src/main/java/androidx/activity/lint/ActivityResultFragmentVersionDetector.kt#L97

It looks like it should be changed to buildVariant, and then there are changed APIs for accessing library info (the .libraries call at the end will also need fixing).

This results in the following failure when I build with newer lint tools and AGP 4.1.0-beta05 in our project

NoSuchMethodError:ActivityResultFragmentVersionDetector.checkDslPropertyAssignment(ActivityResultFragmentVersionDetector.kt:97)←Detector.checkDslPropertyAssignment(Detector.kt:418)←UastGradleVisitor.handleMethodCall(UastGradleVisitor.kt:190)←UastGradleVisitor.access$handleMethodCall(UastGradleVisitor.kt:34)←UastGradleVisitor$visitBuildScript$1.visitCallExpression(UastGradleVisitor.kt:40)←KotlinUFunctionCallExpression.accept(KotlinUFunctionCallExpression.kt:205)←ImplementationUtilsKt.acceptList(implementationUtils.kt:23)←UBlockExpression$DefaultImpls.accept(UBlockExpression.kt:21)

Sun Jul 26 2020 03:07:28 GMT-0400 (Eastern Daylight Time).png

23 KB

View

Download

Comments

il...@google.com <il...@google.com> #2Jul 26, 2020 11:28PM

alpha01? That's so old! :D

We've found the issue in alpha10 and are working on a fix.

my...@gmail.com <my...@gmail.com> #3Jul 27, 2020 09:28PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 37ed64d4de87bd4a4365f5c0dfee7b33c8043013
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Wed Jan 23 15:46:00 2019

Add missing import of parent Directions class in generated Safe Args.

When generating a parent direction action method in a child directions
class,correctly import the parent direction if its located in another
package. Both JavaPoet and KotlinPoet generate import statements but the
NavWriters were incorrectly creating the class name of the parent type,
specifically it missed the package name which caused the import to be
missing.

Bug: 123307342
Test: ./gradlew navigation:navigation-safe-args-gradle-plugin:test \
navigation:navigation-safe-args-generator:test

Change-Id: Ibeda7a7ec6f31bb1c860dfe1f5cd2a7e7ea6d47d

M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/java/JavaNavWriter.kt
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/kotlin/KotlinNavWriter.kt
M navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/NavGeneratorTest.kt
M navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/NavParserTest.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/java/nested/LoginFragmentDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/java/nested/RegisterFragmentDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/java/nested_overridden_action/InnerSettingsFragmentDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/java/nested_overridden_action/SettingsFragmentDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/kotlin/nested/LoginFragmentDirections.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/kotlin/nested/RegisterFragmentDirections.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/kotlin/nested_overridden_action/InnerSettingsFragmentDirections.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/kotlin/nested_overridden_action/SettingsFragmentDirections.kt
M navigation/safe-args-generator/src/tests/test-data/nested_login_test.xml
M navigation/safe-args-gradle-plugin/src/test/test-data/app-project-kotlin/src/main/res/navigation/nav_nested_test.xml
A navigation/safe-args-gradle-plugin/src/test/test-data/app-project/src/main/res/navigation/nav_nested_test.xml

https://android-review.googlesource.com/883592

https://goto.google.com/android-sha1/37ed64d4de87bd4a4365f5c0dfee7b33c8043013

jb...@google.com <jb...@google.com> Jul 30, 2020 10:34PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #4Jul 31, 2020 05:51PM

Hi, I'm still having the issue with 1.0.0-alpha11. Generated classes for fragments in nested navigation throws error for global actions.

ap...@google.com <ap...@google.com> #5Jul 31, 2020 11:57PM

I am also having the issue with 1.0.0-alpha11. I'm going to see what the Kotlin generator does with this.

ap...@google.com <ap...@google.com> #6Jul 31, 2020 11:58PM

Re #4 and #5 - please file a new bug with a sample project that reproduces your issue.

jb...@google.com <jb...@google.com> #7Aug 12, 2020 02:30AM

Marked as fixed.

Re #6 will do. I think it has to do with naming arguments with capital first letters but I'll see if I can make a minimal example app to demonstrate, as a new bug.

ap...@google.com <ap...@google.com> #8Dec 21, 2023 05:34PM

How do i fix this?