ActivityResultFragmentVersionDetector uses an API that breaks in Lint 27.1.0+ (AGP 4.1.0+) [162155191]

Fixed

Bug

Status Update

No update yet.

Description

za...@gmail.com

created issue #1

Jul 26, 2020 07:08AM

Component used: Fragment
Version used: 1.3.0-alpha07
Devices/Android versions reproduced on: N/A

This code snippet will no longer work with lint tools 27.1.0+ (which is what's used in AGP 4.1.0+).

https://github.com/androidx/androidx/blob/c5ff35e40fbf353262ac22013e8c16e45b9017a3/activity/activity-lint/src/main/java/androidx/activity/lint/ActivityResultFragmentVersionDetector.kt#L97

It looks like it should be changed to buildVariant, and then there are changed APIs for accessing library info (the .libraries call at the end will also need fixing).

This results in the following failure when I build with newer lint tools and AGP 4.1.0-beta05 in our project

NoSuchMethodError:ActivityResultFragmentVersionDetector.checkDslPropertyAssignment(ActivityResultFragmentVersionDetector.kt:97)←Detector.checkDslPropertyAssignment(Detector.kt:418)←UastGradleVisitor.handleMethodCall(UastGradleVisitor.kt:190)←UastGradleVisitor.access$handleMethodCall(UastGradleVisitor.kt:34)←UastGradleVisitor$visitBuildScript$1.visitCallExpression(UastGradleVisitor.kt:40)←KotlinUFunctionCallExpression.accept(KotlinUFunctionCallExpression.kt:205)←ImplementationUtilsKt.acceptList(implementationUtils.kt:23)←UBlockExpression$DefaultImpls.accept(UBlockExpression.kt:21)

Sun Jul 26 2020 03:07:28 GMT-0400 (Eastern Daylight Time).png

23 KB

View

Download

Comments

il...@google.com <il...@google.com> #2Jul 26, 2020 11:28PM

There is no error when I use kotlin versions: 1.6.21, but issue/error starts appearing when kotlin version is 1.7.0

my...@gmail.com <my...@gmail.com> #3Jul 27, 2020 09:28PM

I have the same problem, i think no stable version of room 2.4.2 with kotlin 1.7.0

jb...@google.com <jb...@google.com> Jul 30, 2020 10:34PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #4Jul 31, 2020 05:51PM

usage implementation 'androidx.room:room-ktx:2.5.0-alpha02'

ap...@google.com <ap...@google.com> #5Jul 31, 2020 11:57PM

me too

ap...@google.com <ap...@google.com> #6Jul 31, 2020 11:58PM

Thanks for the report I was able to reproduce the issue and indeed it occurs when using Kotlin 1.7.0. Sadly I don't have a workaround yet, but will investigate further.

jb...@google.com <jb...@google.com> #7Aug 12, 2020 02:30AM

Marked as fixed.

and just to clarify, we see the issue when using Room 2.4.2, but not with Room 2.5.0-alpha02.

ap...@google.com <ap...@google.com> #8Dec 21, 2023 05:34PM

it occurs when kotlin version 1.7.0 and room 2.5.0-alpha02 as well to me. I solved the problem by downgrading kotlin version to 1.6.20