Throw Error when attempting to registerForActivityResult after onCreate() [162255449]

Fixed

Feature Request

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Jul 27, 2020 08:23PM

When using the ActivityResultAPIs with fragment, the latest possible time that registerForActivityResult() should be called is in onCreate(). Any calls made to registerForActivityResult() made after onCreate() will be ignored.

Instead of ignoring these calls and allowing developers to assume that their callback is registered, we should throw an exception notifying that they are attempting to register too late.

Comments

ap...@google.com <ap...@google.com> #2Jul 31, 2020 12:41AM

It looks like this was fixed in https://android.googlesource.com/platform/frameworks/support/+/b6fb33662acd6608a29e4610b9d9cf73a191a92c, which is included in 1.3.0-alpha01. I'll follow up internally whether it's worth making a quick 1.2.6 release to fix this issue.

jb...@google.com <jb...@google.com> #3Jul 31, 2020 12:45AM

Marked as fixed.

For the avoidance of doubt, I think it's just the three lines in RemotePlaybackClient that are needed from the ref'd commit to fix the issue.

Issue 162255449

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Jul 31, 2020 12:41AM

jb...@google.com <jb...@google.com> #3Jul 31, 2020 12:45AM

Add comment

Issue metadata