Throw error when attempting to registerForActivityResult after CREATED [165435866]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Aug 19, 2020 03:09AM

Much like was done for Fragments in b/162255449, When using the ActivityResultRegistry with a LifecycleOwner, the latest possible time that register() should be called is while the lifecycle is CREATED. This ensures that any registered callbacks are always registered in the same exact order.

If there is an attempt to register after the LifecycleOwner is STARTED, we should throw.

This is different from b/162255449 because fragments don't move their Lifecycle until after their lifecycle callbacks (another joy of the multiple fragment lifecycles). Once b/127528777 is fixed, this will go for fragments as well.

Comments

ap...@google.com <ap...@google.com> #2Sep 1, 2020 08:10PM

Feel free to disable the link check as a workaround.

The Gradle equivalent is:

android {
    lintOptions {
        disable "DialogFragmentCallbacksDetector"
    }
}

jb...@google.com <jb...@google.com> #3Sep 1, 2020 09:05PM

Marked as fixed.

Not all of our builds depend on androidx.fragment and if you do not use androidx.fragment and you add this disable flag, lint fails due to non-existant check DialogFragmentCallbacksDetector. If you do not plan on fixing this soon, I can try and see if we can only disable the check if we depend on androidx.fragment.

pe...@gmail.com <pe...@gmail.com> #4Oct 9, 2020 11:43AM

Project: platform/frameworks/support
Branch: androidx-main

commit 52b166175eabed99d14515190bfa0a7cea787004
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon May 10 16:11:44 2021

Fix OnCreateDialogIncorrectCallback lint on empty java classes

The OnCreateDialogIncorrectCallbackDetector lint rule currently checks
the first element of a list without verifying the item is actually
there. We should check if the item is null before we do anything else.

RelNote: "The `OnCreateDialogIncorrectCallbackDetector` no longer fails
on empty java classes/interfaces"
Test: java empty interface clean
Bug: 187524311

Change-Id: Iaff6c041370bd5a7c2ac8ef8c32a2e6f7a15e456

M fragment/fragment-lint/src/main/java/androidx/fragment/lint/OnCreateDialogIncorrectCallbackDetector.kt
M fragment/fragment-lint/src/test/java/androidx/fragment/lint/OnCreateDialogIncorrectCallbackDetectorTest.kt

https://android-review.googlesource.com/1702325

jb...@google.com <jb...@google.com> #5Oct 9, 2020 04:59PM

This has been fixed internally and will be available in the Fragment 1.4.0-alpha01 release.

ba...@gmail.com <ba...@gmail.com> #6Nov 6, 2020 08:17PM

I am using 1.4.0-alpha01 of the Fragment Library but I am still getting this error.

ba...@gmail.com <ba...@gmail.com> #7Nov 6, 2020 08:18PM

Re #6 - please file a new bug with a sample that reproduces your error.

il...@google.com <il...@google.com> #8Nov 6, 2020 08:26PM

deleted

am...@gmail.com <am...@gmail.com> #9Mar 25, 2021 01:56PM

Still getting this annoying lint error. For some reason this probably happens after updating to AGP 7.4.0-alpha03. The error is pointing to DaggerApplication which is even more confusing

wa...@gmail.com <wa...@gmail.com> #10Nov 17, 2021 02:30PM

My phone is hacked ..what should I do will I start to pay a fresh

re...@gmail.com <re...@gmail.com> #11Oct 13, 2022 01:33AM

promote:

https://posts.google.com/url?q=https://rekart.live

ku...@gmail.com <ku...@gmail.com> #12Sep 9, 2023 01:29PM

Comment has been deleted.

Message last modified on Sep 9, 2023 01:29PM

ow...@gmail.com <ow...@gmail.com> #13Sep 19, 2023 02:51AM

So this update completely broke our ability to launch a file picker on button click as the function to invoke the file picker is in an entirely different class and by the time it's invoked is going to just kill the app. Not really sure what the actual logic was here.

jb...@google.com <jb...@google.com> #14Sep 19, 2023 02:14PM

Please see #8.