Throw error when attempting to registerForActivityResult after CREATED [165435866]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Aug 19, 2020 03:09AM

Much like was done for Fragments in b/162255449, When using the ActivityResultRegistry with a LifecycleOwner, the latest possible time that register() should be called is while the lifecycle is CREATED. This ensures that any registered callbacks are always registered in the same exact order.

If there is an attempt to register after the LifecycleOwner is STARTED, we should throw.

This is different from b/162255449 because fragments don't move their Lifecycle until after their lifecycle callbacks (another joy of the multiple fragment lifecycles). Once b/127528777 is fixed, this will go for fragments as well.

Comments

ap...@google.com <ap...@google.com> #2Sep 1, 2020 08:10PM

Building note: run ./gradlew ... -x processReleaseMetadata

jb...@google.com <jb...@google.com> #3Sep 1, 2020 09:05PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 5f6e46e40a7e47924ac1d04426230466de7b6f38
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Tue Aug 07 15:57:10 2018

Fix ViewModel proguard rules

It removes allowshrinking modifier: a constructor
shouldn't be removed if it is unused, because it is
called through reflection

Test: manual =\
bug: 112230489
Change-Id: I215fe895fa12eb04172e9380a296e2d74567907c

M lifecycle/viewmodel/proguard-rules.pro

https://android-review.googlesource.com/727573

https://goto.google.com/android-sha1/5f6e46e40a7e47924ac1d04426230466de7b6f38

pe...@gmail.com <pe...@gmail.com> #4Oct 9, 2020 11:43AM

Thanks!

jb...@google.com <jb...@google.com> #5Oct 9, 2020 04:59PM

I had the similar problem. Hoping the problem will be fixed in the next release. Thank team!

ba...@gmail.com <ba...@gmail.com> #6Nov 6, 2020 08:17PM

it will be part of rc02

ba...@gmail.com <ba...@gmail.com> #7Nov 6, 2020 08:18PM

When will rc02 be released?

il...@google.com <il...@google.com> #8Nov 6, 2020 08:26PM

RC2 was released already -

https://developer.android.com/topic/libraries/support-library/revisions#28-0-0-rc2

am...@gmail.com <am...@gmail.com> #9Mar 25, 2021 01:56PM

But it's not fixed:

https://twitter.com/ianhlake/status/1035260731665436672

wa...@gmail.com <wa...@gmail.com> #10Nov 17, 2021 02:30PM

Well, it wasn't released properly.

re...@gmail.com <re...@gmail.com> #11Oct 13, 2022 01:33AM

They updated version 2.0.0 in the today so I can update my app for now :D. Thanks!

ku...@gmail.com <ku...@gmail.com> #12Sep 9, 2023 01:29PM

Comment has been deleted.

Message last modified on Sep 9, 2023 01:29PM

ow...@gmail.com <ow...@gmail.com> #13Sep 19, 2023 02:51AM

Hi want to play

jb...@google.com <jb...@google.com> #14Sep 19, 2023 02:14PM

Alluda