Throw error when attempting to registerForActivityResult after CREATED [165435866]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Aug 19, 2020 03:09AM

Much like was done for Fragments in b/162255449, When using the ActivityResultRegistry with a LifecycleOwner, the latest possible time that register() should be called is while the lifecycle is CREATED. This ensures that any registered callbacks are always registered in the same exact order.

If there is an attempt to register after the LifecycleOwner is STARTED, we should throw.

This is different from b/162255449 because fragments don't move their Lifecycle until after their lifecycle callbacks (another joy of the multiple fragment lifecycles). Once b/127528777 is fixed, this will go for fragments as well.

Comments

ap...@google.com <ap...@google.com> #2Sep 1, 2020 08:10PM

Is this fixed? I'm still seeing this issue with AGP 8.1.0-beta01 + Gradle 8.1

jb...@google.com <jb...@google.com> #3Sep 1, 2020 09:05PM

Marked as fixed.

The fix has not been landed.

pe...@gmail.com <pe...@gmail.com> #4Oct 9, 2020 11:43AM

Due to this bug in CI we hit configuration cache invalidation 100% of the time. Can we make sure the fix lands soon? And especially before 8.1.0 stable.

jb...@google.com <jb...@google.com> #5Oct 9, 2020 04:59PM

I cc'ed you on the CL which should be landed this week.

ba...@gmail.com <ba...@gmail.com> #6Nov 6, 2020 08:17PM

Aurimas, is this 8.1 blocking for Androidx? If not, feel free to remove the "Blocking release" label.

ba...@gmail.com <ba...@gmail.com> #7Nov 6, 2020 08:18PM

cherry pick to G is landed.

il...@google.com <il...@google.com> #8Nov 6, 2020 08:26PM

This was still broken when running lint, but that is fixed here, which will be included in AGP 8.2.0-alpha10.

TBD if it will be included in 8.1.0 and/or 8.1.1

am...@gmail.com <am...@gmail.com> #9Mar 25, 2021 01:56PM

Reassigning to Xav to review CP to 8.1 branch

wa...@gmail.com <wa...@gmail.com> #10Nov 17, 2021 02:30PM

Scott, do we have a cherry-pick ready for the lint fix?

re...@gmail.com <re...@gmail.com> #11Oct 13, 2022 01:33AM

Yes, Change-Id: I994677cebb63de5472bb8ea561bdad0336c72f55

ku...@gmail.com <ku...@gmail.com> #12Sep 9, 2023 01:29PM

Comment has been deleted.

Message last modified on Sep 9, 2023 01:29PM

ow...@gmail.com <ow...@gmail.com> #13Sep 19, 2023 02:51AM

Hey Saurabh, ag/I994677cebb63de5472bb8ea561bdad0336c72f55 still needs DrNo approval. Can you give approval, or can you reassign to someone who can?

jb...@google.com <jb...@google.com> #14Sep 19, 2023 02:14PM

I still see it being broken in AGP 8.2.0-alpha15.

See me trying to remove the entry from the allow list: