Throw error when attempting to registerForActivityResult after CREATED [165435866]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Aug 19, 2020 03:09AM

Much like was done for Fragments in b/162255449, When using the ActivityResultRegistry with a LifecycleOwner, the latest possible time that register() should be called is while the lifecycle is CREATED. This ensures that any registered callbacks are always registered in the same exact order.

If there is an attempt to register after the LifecycleOwner is STARTED, we should throw.

This is different from b/162255449 because fragments don't move their Lifecycle until after their lifecycle callbacks (another joy of the multiple fragment lifecycles). Once b/127528777 is fixed, this will go for fragments as well.

Comments

ap...@google.com <ap...@google.com> #2Sep 1, 2020 08:10PM

Hi, thanks for reporting, we'll have a look. If you could provide us with a minimum sample app to reproduce the issue, that'd be very helpful.

jb...@google.com <jb...@google.com> #3Sep 1, 2020 09:05PM

Marked as fixed.

I confirm I managed to reproduce with API 23 emulator and the following patch on the sample app. Will investigate further.

Patch below.

***

Index: app/src/main/java/androidx/viewpager2/integration/testapp/cards/CardView.kt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- app/src/main/java/androidx/viewpager2/integration/testapp/cards/CardView.kt (revision 38ea42c142729c777dcf8f3e4bd5100aeca981ec)
+++ app/src/main/java/androidx/viewpager2/integration/testapp/cards/CardView.kt (date 1565281963000)
@@ -16,9 +16,11 @@

package androidx.viewpager2.integration.testapp.cards

+import android.text.SpannableStringBuilder
import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
+import android.widget.EditText
import android.widget.TextView

import androidx.annotation.ColorRes
@@ -28,7 +30,7 @@
/** Inflates and populates a [View] representing a [Card] */
class CardView(layoutInflater: LayoutInflater, container: ViewGroup?) {
val view: View = layoutInflater.inflate(R.layout.item_card_layout, container, false)
- private val textSuite: TextView
+ private val textSuite: EditText
private val textCorner1: TextView
private val textCorner2: TextView

@@ -42,7 +44,7 @@
* Updates the view to represent the passed in card
*/
fun bind(card: Card) {
- textSuite.text = card.suit
+ textSuite.text = SpannableStringBuilder(card.suit)
view.setBackgroundResource(getColorRes(card))

val cornerLabel = card.cornerLabel
Index: app/src/main/res/layout/item_card_layout.xml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- app/src/main/res/layout/item_card_layout.xml (revision 38ea42c142729c777dcf8f3e4bd5100aeca981ec)
+++ app/src/main/res/layout/item_card_layout.xml (date 1565281963000)
@@ -31,13 +31,15 @@
android:textAppearance="@android:style/TextAppearance.Large"
tools:text="A"/>

- <TextView
+ <EditText
android:id="@+id/label_center"
- android:layout_width="wrap_content"
+ android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_gravity="center"
+ android:inputType="text"
+ android:maxLines="1"
android:textAppearance="@android:style/TextAppearance.Large"
- tools:text="♠"/>
+ tools:text="♠" />

<TextView
android:id="@+id/label_bottom"

pe...@gmail.com <pe...@gmail.com> #4Oct 9, 2020 11:43AM

Corrected video

jb...@google.com <jb...@google.com> #5Oct 9, 2020 04:59PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 47ac9fee0e3d43b4da33f53b8a2ff590f0d46079
Author: Jakub Gielzak <jgielzak@google.com>
Date: Tue Aug 20 13:57:06 2019

Addressed issues with EditText causing scroll

EditText methods: bringPointIntoView, and handleFocusGainInternal
trigger requestChildRectangleOnScreen in ViewPager2's internal
RecyclerView.

This can cause:
- unwanted scrolling -- e.g. when typing on some API versions
- a jump to page 0 -- EditText sometimes reports over -1M px mScrollX

This fix bypasses requestChildRectangleOnScreen calculations taking
advantage of the fact that PagerSnapHelper constraints valid scroll
values to a snapped position ones, and as a result, the problem is
reduced to choosing the correct currentItem.

Bug: 138044582
Bug: 139432498
Test: ./gradlew viewpager2:connectedCheck

Change-Id: Ia4d3e4e6734183e64f261c7cc76d669deae78da5

A viewpager2/src/androidTest/java/androidx/viewpager2/widget/EditTextFocusTest.kt
M viewpager2/src/main/java/androidx/viewpager2/widget/ViewPager2.java

https://android-review.googlesource.com/1107013

https://goto.google.com/android-sha1/47ac9fee0e3d43b4da33f53b8a2ff590f0d46079

ba...@gmail.com <ba...@gmail.com> #6Nov 6, 2020 08:17PM

Fix [1] for this is planned to be released in 1.0.0-beta04.

[1]

http://aosp/1107013

ba...@gmail.com <ba...@gmail.com> #7Nov 6, 2020 08:18PM

beta04 with a fix for this was released today

il...@google.com <il...@google.com> #8Nov 6, 2020 08:26PM

Re #6 - You should be using the ActivityResultRegistry's register() method that does not take a LifecycleOwner from a composable (as you must manually tie the register and unregister calls to onCommit and onDispose). That method is unaffected by these changes.

am...@gmail.com <am...@gmail.com> #9Mar 25, 2021 01:56PM

Re #8 - Thanks. This fixed my issues.

I have a dynamic ui Screen that rendered based on the response. and this solved it.

wa...@gmail.com <wa...@gmail.com> #10Nov 17, 2021 02:30PM

My phone is hacked ..what should I do will I start to pay a fresh

re...@gmail.com <re...@gmail.com> #11Oct 13, 2022 01:33AM

promote:

https://posts.google.com/url?q=https://rekart.live

ku...@gmail.com <ku...@gmail.com> #12Sep 9, 2023 01:29PM

Comment has been deleted.

Message last modified on Sep 9, 2023 01:29PM

ow...@gmail.com <ow...@gmail.com> #13Sep 19, 2023 02:51AM

So this update completely broke our ability to launch a file picker on button click as the function to invoke the file picker is in an entirely different class and by the time it's invoked is going to just kill the app. Not really sure what the actual logic was here.

jb...@google.com <jb...@google.com> #14Sep 19, 2023 02:14PM

Please see #8.