Throw error when attempting to registerForActivityResult after CREATED [165435866]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Aug 19, 2020 03:09AM

Much like was done for Fragments in b/162255449, When using the ActivityResultRegistry with a LifecycleOwner, the latest possible time that register() should be called is while the lifecycle is CREATED. This ensures that any registered callbacks are always registered in the same exact order.

If there is an attempt to register after the LifecycleOwner is STARTED, we should throw.

This is different from b/162255449 because fragments don't move their Lifecycle until after their lifecycle callbacks (another joy of the multiple fragment lifecycles). Once b/127528777 is fixed, this will go for fragments as well.

Comments

ap...@google.com <ap...@google.com> #2Sep 1, 2020 08:10PM

Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.

jb...@google.com <jb...@google.com> #3Sep 1, 2020 09:05PM

Marked as fixed.

Great! Thanks a lot, I'll look for the live updates soon!

pe...@gmail.com <pe...@gmail.com> #4Oct 9, 2020 11:43AM

I am totally confused about this fix purpose. After it I started to get the next crash:

java.lang.IllegalStateException: LifecycleOwner app.application.activities.GalleryActivity$Gallery@5abd1ee is attempting to register while current state is RESUMED. LifecycleOwners must call register before they are STARTED.
at androidx.activity.result.ActivityResultRegistry.register(ActivityResultRegistry.java:116)
at androidx.activity.ComponentActivity.registerForActivityResult(ComponentActivity.java:653)
at androidx.activity.ComponentActivity.registerForActivityResult(ComponentActivity.java:662)
at app.application.activities.EditorCreativeActivity.open(EditorCreativeActivity.java:179)

A use case example. An activity is already running, the user presses a button to open a second activity which will return a result. Since the first activity is already started and running it will throw the above exception.

jb...@google.com <jb...@google.com> #5Oct 9, 2020 04:59PM

The call to register() should be before the activity's Lifecycle is STARTED, and the onClickListener on your button should be calling launch() on the ActivityResultLauncher returned from the call to register as mentioned in the documentation.

If that is what you are doing and you are still seeing an issue, please file a bug with a minimal sample app that reproduces the issue.

ba...@gmail.com <ba...@gmail.com> #6Nov 6, 2020 08:17PM

The resolution to this issue means that Composable functions can no longer call activity.registerForActivityResult() via user interaction.

Is this intentional, and if so, what is the solution?

ba...@gmail.com <ba...@gmail.com> #7Nov 6, 2020 08:18PM

Maybe I should clarify that by "Composable functions" I of course mean functions with the @Composable flag created using Jetpack Compose.

il...@google.com <il...@google.com> #8Nov 6, 2020 08:26PM

Re #6 - You should be using the ActivityResultRegistry's register() method that does not take a LifecycleOwner from a composable (as you must manually tie the register and unregister calls to onCommit and onDispose). That method is unaffected by these changes.

am...@gmail.com <am...@gmail.com> #9Mar 25, 2021 01:56PM

Re #8 - Thanks. This fixed my issues.

I have a dynamic ui Screen that rendered based on the response. and this solved it.

wa...@gmail.com <wa...@gmail.com> #10Nov 17, 2021 02:30PM

My phone is hacked ..what should I do will I start to pay a fresh

re...@gmail.com <re...@gmail.com> #11Oct 13, 2022 01:33AM

promote:

https://posts.google.com/url?q=https://rekart.live

ku...@gmail.com <ku...@gmail.com> #12Sep 9, 2023 01:29PM

Comment has been deleted.

Message last modified on Sep 9, 2023 01:29PM

ow...@gmail.com <ow...@gmail.com> #13Sep 19, 2023 02:51AM

So this update completely broke our ability to launch a file picker on button click as the function to invoke the file picker is in an entirely different class and by the time it's invoked is going to just kill the app. Not really sure what the actual logic was here.

jb...@google.com <jb...@google.com> #14Sep 19, 2023 02:14PM

Please see #8.