TextField doesn't allow backspace removal of last character [165956313]

Fixed

Bug

Status Update

No update yet.

Description

se...@google.com

created issue #1

Aug 22, 2020 04:45AM

dev 17
kotlin 1.4

1-function repro :)

@Preview
@Composable
fun PreviewTextField() {
    val (text, setText) = remember { mutableStateOf("") }
    TextField(value = text, onValueChange = setText, label = { })
}

TextField works as expected until user presses backspace to remove last character. setText is not called, but the cursor position is modified.

Selecting the text and using cut does cause setText to be cleared.

Thanks!

Comments

ma...@google.com <ma...@google.com> #2Aug 24, 2020 10:43AM

At least make BottomSheet can be launched from local like AlertDialog. Right now, it's too hard to have multiple BottomSheets on one screen with BottomSheetScaffold.

so...@google.com <so...@google.com> #3Aug 24, 2020 10:48AM

(Maybe I don't where this lives in documentation) I'm looking for a similar behavior in SwiftUI where you can call `.sheet()` to invoke a bottom sheet at any point which overtakes the screen. This behaves just like `.alert` in SwiftUI.

ma...@google.com <ma...@google.com> #4Aug 24, 2020 10:51AM

Re comment#2 and comment#3 - this issue is only tracking the integration of bottom sheets into Navigation Compose so that you can use navController.navigate() to make a bottom sheet appear.

If you'd like to request changes to the ModalBottomSheetLayout and similar APIs, you'll want to file a separate request against Compose.

ma...@google.com <ma...@google.com> #5Aug 24, 2020 12:08PM

Fwiw this change does enable treating bottom sheets more like a window-esque thing, but they definitely won't be local.

so...@google.com <so...@google.com> #6Aug 24, 2020 01:25PM

Accompanist now supports this with Navigation Material.

so...@google.com <so...@google.com> #7Aug 24, 2020 01:31PM

This feature will be super useful!

Message last modified on Aug 24, 2020 01:31PM

si...@google.com <si...@google.com> Aug 24, 2020 05:43PM

Reassigned to so...@google.com.

ap...@google.com <ap...@google.com> #8Aug 26, 2020 08:58AM

Marked as fixed.

Until this is implemented, could we at least get a warning notice in the documentation?

Not great to find out half way through a migration that this isn't possible.

Looks like we'll need to rework our app's navigation system (currently based on Fragments) just to support bottom sheets with a Bottom Navigation Bar at first glance. From the docs this wasn't clear.

vi...@airbnb.com <vi...@airbnb.com> #9Aug 27, 2020 05:45AM

Re comment#6 - can you explain what you are talking about? A fragment based navigation system is not going to be using Navigation Compose, which is what this issue is about and which is already available via Accompanist Navigation Material to unblock any migration to Navigation Compose from a fragment based system.

BottomSheetDialogFragment, which is what you'd use in a fragment based system, has been supported since dialog destinations were added in Navigation 2.1.0-alpha03 back in 2019.

so...@google.com <so...@google.com> #10Aug 27, 2020 09:48AM

Project: platform/frameworks/support
Branch: androidx-main

commit d65d5731e4f0dfe560b43eae886a4fabfa949b84
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Feb 21 02:14:42 2024

Add Navigation Material from Accompanists to androidx

Now that the needed compose material API are stable, we can move the
navigation material module from Accompanists to Androidx. This means we
will have a new compose-material-navigation module that provides support
for bottomsheets.

RelNote: "Providing new Compose Material Navigation module that adds
support for Bottomsheets in Compose Material."
Test: Added tests and samples
Bug: 180247978

Change-Id: Ia93eb757a32b04dac8ab3ebd2d73207a68635b80

A compose/material/material-navigation/api/current.txt
A compose/material/material-navigation/api/res-current.txt
A compose/material/material-navigation/api/restricted_current.txt
A compose/material/material-navigation/build.gradle
A compose/material/material-navigation/samples/build.gradle
A compose/material/material-navigation/samples/src/main/java/androidx/compose/material/navigation/samples/ComposeMaterialNavigationSamples.kt
A compose/material/material-navigation/src/androidTest/java/androidx/compose/material/navigation/BottomSheetNavigatorTest.kt
A compose/material/material-navigation/src/androidTest/java/androidx/compose/material/navigation/NavGraphBuilderTest.kt
A compose/material/material-navigation/src/androidTest/java/androidx/compose/material/navigation/SheetContentHostTest.kt
A compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/BottomSheet.kt
A compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/BottomSheetNavigator.kt
A compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/NavGraphBuilder.kt
A compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/SheetContentHost.kt
M compose/material/material/integration-tests/material-demos/build.gradle
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/MaterialDemos.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ModalBottomSheet.kt
M docs-tip-of-tree/build.gradle
M settings.gradle

https://android-review.googlesource.com/2953937