Change default navigation animations to be animators [167430145]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Sep 1, 2020 10:32PM

The current Navigation default effects are not only Animations, but they are also inside of sets. This causes issues (like this one) that do not happen when using Animator, Transition, or Androidx Transition. Animator was built as a follow up to Animation, specifically to handle its short comings. We should be using Animator as our default effects instead of Animation.

Because these resources are part of the public API and we don't want to remove or change their directory, we will attempt to have them remain in the same R.anim res location, and just change their underlying implementation.

Comments

ap...@google.com <ap...@google.com> #2Sep 2, 2020 10:50PM

This has been fixed internally in

https://android-review.googlesource.com/870975 and will be available in Navigation 1.0.0-alpha10.

Now, instead of crashing, we ignore invalid deep links, printing a log message saying as much.

ap...@google.com <ap...@google.com> #3Sep 14, 2020 05:47PM

Hi team.
The problem still occurs on version 2.2.0-rc04

ap...@google.com <ap...@google.com> #4Sep 16, 2020 04:26PM

Hi, still getting crash for 2.1.0

jb...@google.com <jb...@google.com> #5Sep 22, 2020 10:39PM

Marked as fixed.

still getting crash on version 2.2.0

ap...@google.com <ap...@google.com> #6Sep 24, 2020 09:34AM

getting crash with 2.2.1

ap...@google.com <ap...@google.com> #7Sep 24, 2020 09:36AM

still getting crash with 2.2.1

ap...@google.com <ap...@google.com> #8Sep 24, 2020 10:08AM

findInvalidDestinationDisplayNameInDeepLink always return null if deepLink length == 1 (deep link destination is start destination of any navGraph of BottomNavigationView)

NavDestination node = i == 0 ? mGraph : graph.findNode(destinationId);
if deepLink.length == 1 node never will be null and this will cause IllegalStateException

Bug demo:

get NavigationAdvancedSample from github

on R.id.about_btn click

NavDeepLinkBuilder(it.context)
.setGraph(R.navigation.list)
.setDestination(R.id.leaderboard)
.createTaskStackBuilder()
.startActivities()

will crash because R.id.leaderboard is start destination (findInvalidDestinationDisplayNameInDeepLink will have deepLink length == 1)

NavDeepLinkBuilder(it.context)
.setGraph(R.navigation.list)
.setDestination(R.id.userProfile)
.createTaskStackBuilder()
.startActivities()

will work because findInvalidDestinationDisplayNameInDeepLink will return NOT null

ap...@google.com <ap...@google.com> #9Sep 24, 2020 10:10AM

It still crash with the latest version 2.2.1. I think the problem lies somewhere around this code

NavDestination node = i == 0 ? mGraph : graph.findNode(destinationId);

When i is 0, just return mGraph itself. When the deep link destination is a root of bottom_nav tab, the deeplink.length becomes 1. Which means this function still says there's no invalid Destination in deep link even if deepLink[0] is totally irrelevant tomGraph.

So this step passes and when findDestination() is actually triggered down the road, it won't find any destination and thus lead to unknown destination crash.

All NavControllers of bottom nav automatically call handleDeepLink() as part of onGraphCreated(). The problem arises the moment NavController whose graph is irrelevant to the root deep link destination calls handleDeepLink().

ap...@google.com <ap...@google.com> #10Sep 24, 2020 11:29AM

It still crashes with 2.3.0-alpha03 version but only if you try to deeplink to startDestination fragment inside navigation graph. Repro steps (described in #8, but lets repeat it in hope issue will be reopened):

download NavigationAdvancedSample
send pending intent to any startDestination screen, e.g.

val pendingIntent = NavDeepLinkBuilder(applicationContext)
                .setGraph(R.navigation.list)
                .setDestination(R.id.leaderboard)
                .setArguments(bundle) // no matter if it is empty in this use case
                .createPendingIntent()
pendingIntent.send()

Exception:

     Caused by: java.lang.IllegalStateException: unknown destination during deep link: com.example.android.navigationadvancedsample:id/list
        at androidx.navigation.NavController.handleDeepLink(NavController.java:689)
        at androidx.navigation.NavController.onGraphCreated(NavController.java:602)
        at androidx.navigation.NavController.setGraph(NavController.java:563)
        at androidx.navigation.NavController.setGraph(NavController.java:528)
        at androidx.navigation.fragment.NavHostFragment.onCreate(NavHostFragment.java:246)
        at androidx.fragment.app.Fragment.performCreate(Fragment.java:2684)
        at androidx.fragment.app.FragmentStateManager.create(FragmentStateManager.java:280)
        at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1175)
        at androidx.fragment.app.FragmentTransition.addToFirstInLastOut(FragmentTransition.java:1255)
        at androidx.fragment.app.FragmentTransition.calculateFragments(FragmentTransition.java:1138)
        at androidx.fragment.app.FragmentTransition.startTransitions(FragmentTransition.java:136)
        at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:1989)
        at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:1947)
        at androidx.fragment.app.FragmentManager.execSingleAction(FragmentManager.java:1818)
        at androidx.fragment.app.BackStackRecord.commitNow(BackStackRecord.java:297)
        at com.example.android.navigationadvancedsample.NavigationExtensionsKt.obtainNavHostFragment(NavigationExtensions.kt:269)
        at com.example.android.navigationadvancedsample.NavigationExtensionsKt.setupWithNavController(NavigationExtensions.kt:61)
        at com.example.android.navigationadvancedsample.MainActivity.setupBottomNavigationBar(MainActivity.kt:121)
        at com.example.android.navigationadvancedsample.MainActivity.onCreate(MainActivity.kt:54)

Reopening would be a good sign that issue is recognized.

ap...@google.com <ap...@google.com> #11Sep 24, 2020 11:32AM

Just in a case Reopen feature is not implemented in IssueTracker :), new ticket is created: https://issuetracker.google.com/issues/151164638

ap...@google.com <ap...@google.com> #12Sep 24, 2020 11:52AM

I heard a rumour that instead of "Reopen" they implemented a "delete and block contributors" button 🙂