Fail fast in image capture is save location is invalid [167697553]

Fixed

Bug

Status Update

No update yet.

Description

hu...@google.com

created issue #1

Sep 3, 2020 06:55PM

When the user specifies a destination to store the result of an image capture (with the use of outputFileOptions), the ImageCapture use case should verify whether this destination is valid before triggering the image capture request to the camera. If the destination is not valid, the operation should fail fast and the user should be notified about it.

Comments

ap...@google.com <ap...@google.com> #2Sep 10, 2020 05:41PM

Might be related to

https://issuetracker.google.com/issues/118020865. BTW, I'm using 1.1.0-alpha01.

Project:

https://github.com/SUPERCILEX/Robot-Scouter/tree/2e3100276e5fe2cbad8a2cbb36303694e9f46bbd
Setup: ./gradlew setup

hu...@google.com <hu...@google.com> Sep 10, 2020 05:42PM

Marked as fixed.

ap...@google.com <ap...@google.com> #3Sep 11, 2020 04:17PM

This is due to a bug in Fragment - using 1.1.0-alpha02 of Preference uses a newer Fragment dependency, and fixes this issue.

ap...@google.com <ap...@google.com> #4Sep 18, 2020 09:00PM

Actually, I just checked and it still crashes using 1.1.0-alpha02.

ap...@google.com <ap...@google.com> #5Sep 18, 2020 09:07PM

Could you maybe upload a simpler project with reproduction steps? Or at least provide reproduction steps for the project you linked - Does it crash when using Preference 1.0.0?

This still seems suspiciously similar to

https://issuetracker.google.com/issues/120240628, which can not be reproduced with 1.1.0-alpha02 (following the reproduction steps in the first comment).

ap...@google.com <ap...@google.com> #6Sep 18, 2020 09:08PM

Hi guys. I can also confirm that it still crashes using preferences 1.1.0-alpha02. I ran the barebones sample project included in

https://issuetracker.google.com/issues/120240628 on a Samsung Galaxy J2 Prime running Android 6.0.1.

If I use 1.0.0 version, the NPE issue will not appear. If I use any of the 1.1.0 alphas with/without fragments 1.1.0-alpha02, the NPE issue is there. This issue also exists for MultiSelectListPreference.

an...@google.com <an...@google.com> #7Sep 18, 2020 10:03PM

I also ran it on a Samsung Galaxy J4+ running Android 8.1.0, and it is the same story. There is no NPE issue using preferences 1.0.0, but using any of the 1.1.0 alphas with/without fragments 1.1.0-alpha02 will cause the NPE.

ap...@google.com <ap...@google.com> #8Sep 18, 2020 10:04PM

Thanks for the further details - it appears there are two similar issues here with Fragment - one has been fixed, but there is still one that exists, causing this bug.

Apologies for the inconvenience.