Fail fast in image capture is save location is invalid [167697553]

Fixed

Bug

Status Update

No update yet.

Description

hu...@google.com

created issue #1

Sep 3, 2020 06:55PM

When the user specifies a destination to store the result of an image capture (with the use of outputFileOptions), the ImageCapture use case should verify whether this destination is valid before triggering the image capture request to the camera. If the destination is not valid, the operation should fail fast and the user should be notified about it.

Comments

ap...@google.com <ap...@google.com> #2Sep 10, 2020 05:41PM

Please attach a sample project that reproduces your issue.

hu...@google.com <hu...@google.com> Sep 10, 2020 05:42PM

Marked as fixed.

ap...@google.com <ap...@google.com> #3Sep 11, 2020 04:17PM

Sure, here is a sample one at

https://github.com/Ethan1983/NavToolbarTitle. Steps are available in README.md

ap...@google.com <ap...@google.com> #4Sep 18, 2020 09:00PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bd065925676170c8453321e970d455fac06b8d3d
Author: Ian Lake <ilake@google.com>
Date: Mon Jan 28 15:47:16 2019

Add ProGuard rules for DrawerArrowDrawable.setProgress()

setProgress() is called via an ObjectAnimator and
therefore needs to be specifically kept when
obfuscating with ProGuard.

Test: tested in sample project attached to bug
Change-Id: I9c420ce728c5cb887d29df9f856bfd31f5bdbcdf
Fixes: 123449431

M navigation/ui/build.gradle
A navigation/ui/proguard-rules.pro

https://android-review.googlesource.com/887876

https://goto.google.com/android-sha1/bd065925676170c8453321e970d455fac06b8d3d

ap...@google.com <ap...@google.com> #5Sep 18, 2020 09:07PM

We've added the appropriate ProGuard configuration and it'll be available in the next release.

As a workaround, you can add the following to your ProGuard configuration:

-keepclassmembers class android.support.v7.graphics.drawable.DrawerArrowDrawable {
void setProgress(float);
}

ap...@google.com <ap...@google.com> #6Sep 18, 2020 09:08PM

Sure, thanks for the quick fix.

an...@google.com <an...@google.com> #7Sep 18, 2020 10:03PM

I had to use the androidx version for proguard rules

-keepclassmembers class androidx.appcompat.graphics.drawable.DrawerArrowDrawable {
void setProgress(float);
}

ap...@google.com <ap...@google.com> #8Sep 18, 2020 10:04PM

Yep, Jetifier will automatically convert ProGuard rules packaged with libraries, but if you're adding the ProGuard files to your own project, you'll need to make sure to use the AndroidX equivalents if your project is using AndroidX.