IssueTracker

Only the `argType="reference"` accepts resource IDs (and returns an int that you'd pass to getContext().getString()), so it is working as intended that a "string" type is exactly what you put into your XML. It was important that the build time code gen and the runtime behavior always matches and that was not possible in the general cases - see edge cases such as https://issuetracker.google.com/issues/111736515 for some background.

Please star https://issuetracker.google.com/issues/36994900 to track progress towards allowing placeholders in XML files, which would be the recommended way of filling in placeholders at compile time.

Ok thanks, I understand now, I wasn't aware of argType="reference". Anyway I think it is a bit strange that behavior is different if we navigate using safe args gen code (navController.navigate(WebPageFragmentDirections.actionGlobalHomeFragment())) and code without safe args (navController.navigate(R.id.homeFragment)) if the navigation xml file is the same.

Yes, I think we can make it more explicit that only reference types can have references to other resources.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bb456e84a524d4e5cd241a6a839a1062297b9cf4
Author: Ian Lake <ilake@google.com>
Date:   Thu Jan 31 15:46:55 2019

    Enforce "reference" types for reference default values
   
    In order to ensure that inflation of a navigation
    graph results in the same arguments as Safe Args,
    we now enforce usage of the "reference" type for any
    argument that has a defaultValue that references
    another resource (i.e., @string/app_name, etc).
   
    This makes it much more obvious that the default value
    in Safe Args is in the form of R.string.app_name and
    any provided override for that should also be in the
    form of R.string.some_value.
   
    In these cases, it is expected that developers either
    1) Use the ids directly (for example, passing an
    R.string to a method that takes a resource id)
    2) Specifically call context.getString() with the
    resource id they retrieve from their NavArgs instance.
   
    Test: updated NavInflaterTest
    Change-Id: I06b8c9a0d1420821b8c0064c22f176788da43d7a
    Fixes: 123551990

M       navigation/runtime/src/androidTest/java/androidx/navigation/NavInflaterTest.kt
M       navigation/runtime/src/androidTest/res/navigation/nav_default_arguments.xml
A       navigation/runtime/src/androidTest/res/navigation/nav_invalid_argument_arg_type.xml
A       navigation/runtime/src/androidTest/res/navigation/nav_invalid_argument_default_value.xml
M       navigation/runtime/src/main/java/androidx/navigation/NavInflater.java

https://android-review.googlesource.com/891680
https://goto.google.com/android-sha1/bb456e84a524d4e5cd241a6a839a1062297b9cf4

Navigation now enforces use of the "reference" type if you have a defaultValue referencing another resource. This ensures that Safe Args and Navigation's runtime behavior are always in sync.

Please star https://issuetracker.google.com/issues/36994900 to track allowing build time placeholders in XML files.

Ok, great, now it is much more straightforward. Thanks!

This "fix" broke our app and our navigation XML, the file looked like the one described in the first message by OP and that's exactly how we wanted it to work.

Let me describe the use case.

Our Fragments load content based on the argument "url" (coming from backend) and the default value is required to load the initial content when the user starts the app.

Previously we had this default value stored in string resources where all the app strings can be easily accessed and reused across the app.

After this "fix" in beta01, we have to hardcode the default path in the navigation XML file and we have lost the ability to reference the same default path in the code (now the string is duplicated in string resources and in the navigation XML file).
Another undesired side-effect is that another argument used the default value of @string/null_ and now this doesn't work anymore forcing us to use an ugly empty string with a space character and in the Fragment check for blank string.

Could you enable resources references again just for default XML arguments for other argTypes?

Re #8:
- String, object, and array argument types support using android:defaultValue="@null" for null default values. This continues to be the case. https://issuetracker.google.com/issues/120627532 tracks adding documentation around that fact
- I've filed https://issuetracker.google.com/issues/124248602 for supporting an empty (i.e., 0) default value for reference types

Resources cannot be statically resolved at build time - they are inherently only resolvable at runtime, so there's no way for Safe Args to know what default value to add to the generate code. Given that, there's no plans on supporting resource references on anything other than "reference" types.

you need to remove the default value from the nav_graph and figure out an alternative logic to set it .. I do not think that would be so hard to do.

Project: platform/frameworks/support
Branch: snap-temp-L25200000699921867

commit c9e5aa95317da82d339c362a3dae64a9f331e214
Author: Jeremy Woods <jbwoods@google.com>
Date:   Wed Sep 23 14:44:52 2020

    Keep long arg names from wrapping
   
    When using safe-args with a long argument name, kotlin does an
    automatic line wrap at 100 characters which makes it place the argument
    return and variable on different lines, which fails.
   
    We should add `·` to emit a space that never wraps.
   
    Test: Added KotlinNavWriterTest
    Bug: 168584987
    Change-Id: Ibc31f91fd6b1c4a94f0b7c05b9b9679ffa09b625
    (cherry picked from commit 766a3ad47da73e1179ce6419693a825c4d665cfd)

M       navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/kotlin/KotlinNavWriter.kt
M       navigation/navigation-safe-args-generator/src/test/kotlin/androidx/navigation/safe/args/generator/KotlinNavWriterTest.kt
A       navigation/navigation-safe-args-generator/src/test/test-data/expected/kotlin_nav_writer_test/ReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyLongNameMainFragmentArgs.kt

https://android-review.googlesource.com/1436925

Project: platform/frameworks/support
Branch: snap-temp-L07700000699933785

commit f3069dc913eb8d41e6cc3859df5d6ef204fdf18c
Author: Jeremy Woods <jbwoods@google.com>
Date:   Wed Sep 23 14:44:52 2020

    Keep long arg names from wrapping
   
    When using safe-args with a long argument name, kotlin does an
    automatic line wrap at 100 characters which makes it place the argument
    return and variable on different lines, which fails.
   
    We should add `·` to emit a space that never wraps.
   
    Test: Added KotlinNavWriterTest
    Bug: 168584987
    Change-Id: Ibc31f91fd6b1c4a94f0b7c05b9b9679ffa09b625
    (cherry picked from commit 766a3ad47da73e1179ce6419693a825c4d665cfd)

M       navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/kotlin/KotlinNavWriter.kt
M       navigation/navigation-safe-args-generator/src/test/kotlin/androidx/navigation/safe/args/generator/KotlinNavWriterTest.kt
A       navigation/navigation-safe-args-generator/src/test/test-data/expected/kotlin_nav_writer_test/ReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyLongNameMainFragmentArgs.kt

https://android-review.googlesource.com/1436930