Navigation component not accepting arguments in Dialogs that doesn't inherit from DialogFragment directly [168584987]

Fixed

Bug

Status Update

No update yet.

Description

ca...@gmail.com

created issue #1

Sep 15, 2020 05:57PM

Component used:
- androidx.navigation:navigation-fragment-ktx:2.2.1
- androidx.navigation:navigation-ui-ktx:2.2.1
Version used:
Devices/Android versions reproduced on: Cannot compile

STEPS:

Create a DialogFragment class called MyDialog
Now create another class called MyNewDialog that inherits from MyDialog instead of DialogFragment(for example, to inherit styles or UI)

Now in a XML graph, try to add it and put it some arguments:

<dialog
    android:id="@+id/my_new_dialog"
    android:name="com.example.app.dialogs.MyNewDialog"
    tools:layout="@layout/my_dialog">

    <argument
        android:name="argument_1"
        app:argType="string"/>

    <action
        android:id="@+id/action_1"
        app:destination="@id/destination_1" />

</dialog>

Then, when trying to build the application, it won't compile and the navigation generated code will throw:

This function must return a value of type MyNewDialogArgs

However, no problem with actions (Why it doesn't throw same error with type MyNewDialogDirections??)

No problem if we use MyDialog(that inherits directly from DialogFragment) instead of MyNewDialog(that inherits from MyDialogand this last, from DialogFragment

Comments

il...@google.com <il...@google.com> #2Sep 15, 2020 06:28PM

What about Enums? Enum is a type-safe way to pass navigation arguments.
Will Enums be covered in this issue as part of Serializable or will have own handled separately?
Because for enum you can provide a reasonable default value but for Parcelable or Serializable only @null

ca...@gmail.com <ca...@gmail.com> #3Sep 16, 2020 01:06PM

Please add support for Serializable objects so Enums can be used.

NavTestApp.zip

26 MB

Download

il...@google.com <il...@google.com> #4Sep 16, 2020 04:21PM

Assigned to jb...@google.com.

Support of Serializable objects is not enough for enums, you definitely need also the support of default values.

ap...@google.com <ap...@google.com> #5Sep 24, 2020 01:37AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 6f59e3d74d0da5a4bf79c8480f56964e3af47f1c
Author: Wojtek Kaliciński <wkal@google.com>
Date: Mon Jul 23 20:17:19 2018

Support more types for args

Provides support for Serializable, enums,
as well as arrays of primitive types and Parcelables
in Navigation arguments.

Only enums support default values other than @null,
in the form of the enum literal (without class name),
e.g. app:defaultValue="READ"

Test: unit tests updated
BUG: 111487504
BUG: 111316353
Change-Id: I7e5abbc8ed0950bfdef292342dbe1fb34a5c4b17

M navigation/runtime/src/androidTest/java/androidx/navigation/NavInflaterTest.kt
A navigation/runtime/src/androidTest/java/androidx/navigation/test/TestEnum.java
M navigation/runtime/src/androidTest/res/navigation/nav_default_arguments.xml
M navigation/runtime/src/main/java/androidx/navigation/NavInflater.java
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/NavParser.kt
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/NavParserErrors.kt
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/NavWriter.kt
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/Types.kt
M navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/NavParserTest.kt
M navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/NavWriterTest.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/MainFragmentArgs.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/Next.java
M navigation/safe-args-generator/src/tests/test-data/naive_test.xml

https://android-review.googlesource.com/720246

https://goto.google.com/android-sha1/6f59e3d74d0da5a4bf79c8480f56964e3af47f1c

jb...@google.com <jb...@google.com> #6Sep 24, 2020 08:37AM

Marked as fixed.

This is fixed internally and will be available in 1.0.0-alpha08

ap...@google.com <ap...@google.com> #7Sep 24, 2020 09:34AM

What happened if I declaire app:argType="androidx.navigation.test.TestEnum" and turn on proguard/R8? Because both ProGuard and R8 will optimize trivial enums into ints.

ap...@google.com <ap...@google.com> #8Sep 24, 2020 09:36AM

Since you need to explicitly keep argTypes as per

https://issuetracker.google.com/issues/122634648, they'll be kept.

ap...@google.com <ap...@google.com> #9Sep 24, 2020 10:08AM

Thanks. Just saw the latest documentation.

ap...@google.com <ap...@google.com> #10Sep 24, 2020 10:10AM

Project: platform/frameworks/support
Branch: snap-temp-L31300000699869852

commit 998afa5a45306f1096a053e0f9eb275481fe79ab
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Sep 23 14:44:52 2020

Keep long arg names from wrapping

When using safe-args with a long argument name, kotlin does an
automatic line wrap at 100 characters which makes it place the argument
return and variable on different lines, which fails.

We should add `·` to emit a space that never wraps.

Test: Added KotlinNavWriterTest
Bug: 168584987
Change-Id: Ibc31f91fd6b1c4a94f0b7c05b9b9679ffa09b625
(cherry picked from commit 766a3ad47da73e1179ce6419693a825c4d665cfd)

M navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/kotlin/KotlinNavWriter.kt
M navigation/navigation-safe-args-generator/src/test/kotlin/androidx/navigation/safe/args/generator/KotlinNavWriterTest.kt
A navigation/navigation-safe-args-generator/src/test/test-data/expected/kotlin_nav_writer_test/ReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyLongNameMainFragmentArgs.kt

https://android-review.googlesource.com/1436918

ap...@google.com <ap...@google.com> #11Sep 24, 2020 11:30AM

Project: platform/frameworks/support
Branch: snap-temp-L53700000699921463

commit 0e594474451b1e1a2f6927179c703f1547dbfe7c
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Sep 23 14:44:52 2020

Keep long arg names from wrapping

When using safe-args with a long argument name, kotlin does an
automatic line wrap at 100 characters which makes it place the argument
return and variable on different lines, which fails.

We should add `·` to emit a space that never wraps.

Test: Added KotlinNavWriterTest
Bug: 168584987
Change-Id: Ibc31f91fd6b1c4a94f0b7c05b9b9679ffa09b625
(cherry picked from commit 766a3ad47da73e1179ce6419693a825c4d665cfd)

M navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/kotlin/KotlinNavWriter.kt
M navigation/navigation-safe-args-generator/src/test/kotlin/androidx/navigation/safe/args/generator/KotlinNavWriterTest.kt
A navigation/navigation-safe-args-generator/src/test/test-data/expected/kotlin_nav_writer_test/ReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyLongNameMainFragmentArgs.kt

https://android-review.googlesource.com/1436921

ap...@google.com <ap...@google.com> #12Sep 24, 2020 11:32AM

Project: platform/frameworks/support
Branch: snap-temp-L25200000699921867

commit c9e5aa95317da82d339c362a3dae64a9f331e214
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Sep 23 14:44:52 2020

Keep long arg names from wrapping

When using safe-args with a long argument name, kotlin does an
automatic line wrap at 100 characters which makes it place the argument
return and variable on different lines, which fails.

We should add `·` to emit a space that never wraps.

Test: Added KotlinNavWriterTest
Bug: 168584987
Change-Id: Ibc31f91fd6b1c4a94f0b7c05b9b9679ffa09b625
(cherry picked from commit 766a3ad47da73e1179ce6419693a825c4d665cfd)

M navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/kotlin/KotlinNavWriter.kt
M navigation/navigation-safe-args-generator/src/test/kotlin/androidx/navigation/safe/args/generator/KotlinNavWriterTest.kt
A navigation/navigation-safe-args-generator/src/test/test-data/expected/kotlin_nav_writer_test/ReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyLongNameMainFragmentArgs.kt

https://android-review.googlesource.com/1436925

ap...@google.com <ap...@google.com> #13Sep 24, 2020 11:52AM

Project: platform/frameworks/support
Branch: snap-temp-L07700000699933785

commit f3069dc913eb8d41e6cc3859df5d6ef204fdf18c
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Sep 23 14:44:52 2020

Keep long arg names from wrapping

When using safe-args with a long argument name, kotlin does an
automatic line wrap at 100 characters which makes it place the argument
return and variable on different lines, which fails.

We should add `·` to emit a space that never wraps.

Test: Added KotlinNavWriterTest
Bug: 168584987
Change-Id: Ibc31f91fd6b1c4a94f0b7c05b9b9679ffa09b625
(cherry picked from commit 766a3ad47da73e1179ce6419693a825c4d665cfd)

M navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/kotlin/KotlinNavWriter.kt
M navigation/navigation-safe-args-generator/src/test/kotlin/androidx/navigation/safe/args/generator/KotlinNavWriterTest.kt
A navigation/navigation-safe-args-generator/src/test/test-data/expected/kotlin_nav_writer_test/ReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyLongNameMainFragmentArgs.kt

https://android-review.googlesource.com/1436930

ma...@syslogic.io <ma...@syslogic.io> #14Jun 3, 2022 01:44PM

Just gotten into a similar situation (the title matches): When calling method getArguments() in the constructor, it returns null. While in public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) it returns the Bundle Alike this I can obtain the arguments of a DialogFragment inside a library, which doesn't know about the Navigation at all.