Navigation component not accepting arguments in Dialogs that doesn't inherit from DialogFragment directly [168584987]

Fixed

Bug

Status Update

No update yet.

Description

ca...@gmail.com

created issue #1

Sep 15, 2020 05:57PM

Component used:
- androidx.navigation:navigation-fragment-ktx:2.2.1
- androidx.navigation:navigation-ui-ktx:2.2.1
Version used:
Devices/Android versions reproduced on: Cannot compile

STEPS:

Create a DialogFragment class called MyDialog
Now create another class called MyNewDialog that inherits from MyDialog instead of DialogFragment(for example, to inherit styles or UI)

Now in a XML graph, try to add it and put it some arguments:

<dialog
    android:id="@+id/my_new_dialog"
    android:name="com.example.app.dialogs.MyNewDialog"
    tools:layout="@layout/my_dialog">

    <argument
        android:name="argument_1"
        app:argType="string"/>

    <action
        android:id="@+id/action_1"
        app:destination="@id/destination_1" />

</dialog>

Then, when trying to build the application, it won't compile and the navigation generated code will throw:

This function must return a value of type MyNewDialogArgs

However, no problem with actions (Why it doesn't throw same error with type MyNewDialogDirections??)

No problem if we use MyDialog(that inherits directly from DialogFragment) instead of MyNewDialog(that inherits from MyDialogand this last, from DialogFragment

Comments

il...@google.com <il...@google.com> #2Sep 15, 2020 06:28PM

Building note: run ./gradlew ... -x processReleaseMetadata

ca...@gmail.com <ca...@gmail.com> #3Sep 16, 2020 01:06PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 5f6e46e40a7e47924ac1d04426230466de7b6f38
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Tue Aug 07 15:57:10 2018

Fix ViewModel proguard rules

It removes allowshrinking modifier: a constructor
shouldn't be removed if it is unused, because it is
called through reflection

Test: manual =\
bug: 112230489
Change-Id: I215fe895fa12eb04172e9380a296e2d74567907c

M lifecycle/viewmodel/proguard-rules.pro

https://android-review.googlesource.com/727573

https://goto.google.com/android-sha1/5f6e46e40a7e47924ac1d04426230466de7b6f38

NavTestApp.zip

26 MB

Download

il...@google.com <il...@google.com> #4Sep 16, 2020 04:21PM

Assigned to jb...@google.com.

Thanks!

ap...@google.com <ap...@google.com> #5Sep 24, 2020 01:37AM

I had the similar problem. Hoping the problem will be fixed in the next release. Thank team!

jb...@google.com <jb...@google.com> #6Sep 24, 2020 08:37AM

Marked as fixed.

it will be part of rc02

ap...@google.com <ap...@google.com> #7Sep 24, 2020 09:34AM

When will rc02 be released?

ap...@google.com <ap...@google.com> #8Sep 24, 2020 09:36AM

RC2 was released already -

https://developer.android.com/topic/libraries/support-library/revisions#28-0-0-rc2

ap...@google.com <ap...@google.com> #9Sep 24, 2020 10:08AM

But it's not fixed:

https://twitter.com/ianhlake/status/1035260731665436672

ap...@google.com <ap...@google.com> #10Sep 24, 2020 10:10AM

Well, it wasn't released properly.

ap...@google.com <ap...@google.com> #11Sep 24, 2020 11:30AM

They updated version 2.0.0 in the today so I can update my app for now :D. Thanks!

ap...@google.com <ap...@google.com> #12Sep 24, 2020 11:32AM

<LinearLayout xmlns:android="

http://schemas.android.com/apk/res/android"
android:orientation="vertical"
android:layout_width="match_parent"
android:layout_height="match_parent">
<LinearLayout android:layout_width="match_parent"
android:id="@+id/linearLayout1"
android:gravity="center"
android:layout_height="50dp">
<ImageView android:id="@+id/imageView1"
android:layout_height="wrap_content"
android:layout_width="wrap_content"
android:src="@drawable/logo"
android:paddingRight="30dp"
android:layout_gravity="left"
android:layout_weight="0" />
<View android:layout_height="wrap_content"
android:id="@+id/view1"
android:layout_width="wrap_content"
android:layout_weight="1" />
<Button android:id="@+id/categorybutton"
android:background="@drawable/button_bg"
android:layout_height="match_parent"
android:layout_weight="0"
android:layout_width="120dp"
style="@style/CategoryButtonStyle"/>
</LinearLayout>

<fragment android:id="@+id/headlines"
android:layout_height="fill_parent"
android:name="com.example.android.newsreader.HeadlinesFragment"
android:layout_width="match_parent" />
</LinearLayout>

ap...@google.com <ap...@google.com> #13Sep 24, 2020 11:52AM

Hi want to play

ma...@syslogic.io <ma...@syslogic.io> #14Jun 3, 2022 01:44PM

Alluda