PausingDispatcher should always dispatch when calling yield() [168777346]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Sep 17, 2020 06:44PM

Component used: lifecycle-runtime-ktx
Version used: 2.2.0-alpha01 up to 2.3.0-alpha07

The following example should print "1", "2" then "3" but prints "1", "3", "2":

lifecycleScope.launchWhenResumed {
  launch {
    println("1")
    yield()
    println("3")
  }
  println("2")
}

A similar problem existed in Dispatchers.Main but was fixed: https://github.com/Kotlin/kotlinx.coroutines/issues/1474

Comments

yb...@google.com <yb...@google.com> #2Sep 21, 2020 04:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit 10279986f24d1648952e740ea38c72b7bc44fdc7
Author: Elif Bilgin <elifbilgin@google.com>
Date: Tue Oct 26 16:59:42 2021

Resolving auto migration issue where SQLite keywords are failed to be escaped in column names.

The issue was arising from the part of AutoMigrationWriter generating code to transfer data from the old table to the new table, preserving the order of the columns. The SQL statement used did not utilize `` to escape the column names, resulting in a compiler error in scenarios where a SQLite keyword was being used as a column name.

Issue was repro'd in the tests by using the column name "index" and confirming the escape is working as expected with the new changes.

Test: AutoMigrationTest.java
Bug: 197133152
Change-Id: Idbed488acb2027fb1c0d9c302d1cc83ed5bfba2c

M room/room-compiler/src/main/kotlin/androidx/room/writer/AutoMigrationWriter.kt
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/migration/AutoMigrationDb.java
M room/integration-tests/testapp/schemas/androidx.room.integration.testapp.migration.AutoMigrationDb/1.json

https://android-review.googlesource.com/1870037

yb...@google.com <yb...@google.com> #3Sep 21, 2020 04:19PM

oh nevermind, i wrote the test wrong, thats why it went into a loop.

ap...@google.com <ap...@google.com> #4Oct 5, 2020 05:38PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b9e8c46f4b3151d119058c5224471a913f0b92ac
Author: Nicklas Ansman Giertz <nicklas@ansman.se>
Date: Thu Sep 17 15:45:10 2020

Make PausingDispatcher behave like the main dispatcher when yielding

The default android main dispatcher supports yielding inside the
immediate dispatcher (see

https://github.com/Kotlin/kotlinx.coroutines/commit/3ab34d808b5aa2c8673754bd43e4879b9d4af8c9).

The pausing dispatcher has not worked liked this and yield() calls are
essentially a no-op. This change fixes this and will respect yield()
calls.

Fixes: 168777346
Test: PausingDispatcherTest
Change-Id: Iffa89a264f8566e584eccc1a6ce844863cca2ad9

M lifecycle/lifecycle-runtime-ktx/src/androidTest/java/androidx/lifecycle/Expectations.kt
M lifecycle/lifecycle-runtime-ktx/src/androidTest/java/androidx/lifecycle/PausingDispatcherTest.kt
M lifecycle/lifecycle-runtime-ktx/src/main/java/androidx/lifecycle/DispatchQueue.kt
M lifecycle/lifecycle-runtime-ktx/src/main/java/androidx/lifecycle/PausingDispatcher.kt

https://android-review.googlesource.com/1430830

Issue 168777346

Description

Issue summary

Comments

yb...@google.com <yb...@google.com> #2Sep 21, 2020 04:16PM

yb...@google.com <yb...@google.com> #3Sep 21, 2020 04:19PM

ap...@google.com <ap...@google.com> #4Oct 5, 2020 05:38PM

Add comment

Issue metadata